Remove simple-tcp and simple-udp #1992

markmandel · 2021-02-11T05:21:48Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This covers:

Moving the windows build scripts from simple-udp to simple-game-server
Moving all the documentation to use simple-game-server (tested this by
hand)
Updated all the examples to use simple-game-servers
Removal of both simple-udp and simple-tcp

Which issue(s) this PR fixes:

Closes #1890

Special notes for your reviewer:

97% of this is replacing udp-server with simple-game-server

Release Notes: Make a note that we're no longer developing simple-udp and simple-tcp, but the previous versions of the example images will continue to be hosted.

This covers: * Moving the windows build scripts from simple-udp to simple-game-server * Moving all the documentation to use simple-game-server (tested this by hand) * Updated all the examples to use simple-game-servers * Removal of both simple-udp and simple-tcp Closes googleforgames#1890

agones-bot · 2021-02-11T05:39:34Z

Build Failed 😱

Build Id: 6fcde9ac-bc35-429d-af85-3dc0a6053a50

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2021-02-11T05:58:34Z

e2e failure:

time="2021-02-11 05:38:50.166" level=info msg="Waiting for states to match" awaitingState=Ready currentState=RequestReady gs=udp-servers4z97
--- FAIL: TestGameServerWithPortsMappedToMultipleContainers (315.13s)
    gameserver_test.go:545: Could not get a GameServer ready: waiting for {udp-server [{gameport Dynamic <nil> 7654 0 UDP} {second-gameport Dynamic 0xc0003ec1d0 5000 0 UDP}] {false 0 0 0}  { 0 0} {{      0 0001-01-01 00:00:00 +0000 UTC <nil> <nil> map[] map[] [] []  []} {[] [] [{udp-server gcr.io/agones-images/simple-game-server:0.1 [] []  [] [] [] {map[] map[]} [] [] nil nil nil nil   IfNotPresent nil false false false} {second-udp-server gcr.io/agones-images/simple-game-server:0.1 [] [-port 5000]  [] [] [] {map[] map[]} [] [] nil nil nil nil   IfNotPresent nil false false false}] []  <nil> <nil>  map[]   <nil>  false false false <nil> nil []   nil  [] []  <nil> nil [] <nil> <nil> <nil> map[] []}} <nil>} GameServer instance readiness timed out (): waiting for GameServer to be Ready 1613021550/udp-servers4z97: timed out waiting for the condition
FAIL

agones-bot · 2021-02-11T06:20:46Z

Build Succeeded 👏

Build Id: 940557d8-4d84-4667-81b5-ce64d83a509e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.13.0-104c86d
image: gcr.io/agones-images/agones-sdk:1.13.0-104c86d
image: gcr.io/agones-images/agones-ping:1.13.0-104c86d
Linux C++ SDK (build): agonessdk-1.13.0-104c86d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.13.0-104c86d.zip

A preview of the website (the last 30 builds are retained):

https://104c86d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1992/head:pr_1992 && git checkout pr_1992
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-104c86d

roberthbailey

There are a lot of website changes included in your change that aren't guarded to be part of the next release. Many of them seem ok to push now, but there are some that seem like they should wait until the release (e.g. removing references to the old images, since those exist in the current release).

roberthbailey · 2021-02-11T06:48:42Z

site/content/en/docs/Examples/_index.md

@@ -21,8 +21,6 @@ These are full examples for each of the resource types of Agones

 These are all examples of simple game server implementations, that integrate the Agones game server SDK. 

- {{< ghlink href="examples/simple-udp" >}}Simple UDP{{< /ghlink >}} (Go) - simple server and client that send UDP packets back and forth.


Should this be deleted now or with the next release?

So I didn't see any specific reason not to delete it now, given that it is a duplicated example that has almost identical code already stored in the simple-game-server. But if you feel strongly we should keep it until next release, I'm happy to do so.

I think this was the main place I wanted to gate the change. In the rest of the site it seems ok to flip it over, but removing these links separate from a release (where we remove support for the code) didn't feel quite right.

site/content/en/docs/Getting Started/create-fleet.md

roberthbailey · 2021-02-11T06:57:14Z

test/load/locust-files/fleet_autoscaling.py

@@ -34,7 +34,7 @@ def scaleUpFleet(self):
            "apiVersion": "agones.dev/v1",
            "kind": "Fleet",
            "metadata": {
-                "generateName": "fleet-simple-udp",
+                "generateName": "simple-game-server",


simple-game-server-fleet?

Sure. 🤷 I don't think anyone is using this anyway.

Switched to "fleet-simple-game-server" since the previous version started with "fleet"

Since this is in the locust dir, I agree that it isn't being used actively (the old udp-server version was 0.5 whereas everywhere else it was 0.21).

Not a big deal, but it doesn't look like you actually pushed a change with the updated fleet name.

huh, I changed it here:
3152f31#diff-29dc460d65f66644f6c926f4f634a479e9167383eaeb8c8078f76090cd391fcbR174

Did I do the wrong file... 🤔 ?

OIC THE SPOT! Pushing up a fix.

agones-bot · 2021-02-11T19:02:41Z

Build Succeeded 👏

Build Id: 458b55dc-4020-4df8-be60-3215972bdfad

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.13.0-3152f31
image: gcr.io/agones-images/agones-sdk:1.13.0-3152f31
image: gcr.io/agones-images/agones-ping:1.13.0-3152f31
Linux C++ SDK (build): agonessdk-1.13.0-3152f31-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.13.0-3152f31.zip

A preview of the website (the last 30 builds are retained):

https://3152f31-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1992/head:pr_1992 && git checkout pr_1992
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-3152f31

google-oss-robot · 2021-02-11T21:55:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Only remove example links on release (had to add `&zwnj;` because of strange markdown formatting issues) * Update fleet_autoscaling.py fleet name

google-oss-robot · 2021-02-12T22:46:22Z

New changes are detected. LGTM label has been removed.

agones-bot · 2021-02-12T23:10:35Z

Build Succeeded 👏

Build Id: d95dde7c-355e-4ca3-8ffb-71a63033e326

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.13.0-bae35f4
image: gcr.io/agones-images/agones-sdk:1.13.0-bae35f4
image: gcr.io/agones-images/agones-ping:1.13.0-bae35f4
Linux C++ SDK (build): agonessdk-1.13.0-bae35f4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.13.0-bae35f4.zip

A preview of the website (the last 30 builds are retained):

https://bae35f4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1992/head:pr_1992 && git checkout pr_1992
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.13.0-bae35f4

markmandel added kind/documentation Documentation for Agones area/examples Examples. Usually found in the `examples` directory kind/breaking Breaking change labels Feb 11, 2021

markmandel requested review from roberthbailey and pooneh-m February 11, 2021 05:21

google-cla bot added the cla: yes label Feb 11, 2021

google-oss-robot requested review from aLekSer and EricFortin February 11, 2021 05:21

google-oss-robot added approved size/XXL labels Feb 11, 2021

roberthbailey reviewed Feb 11, 2021

View reviewed changes

roberthbailey approved these changes Feb 11, 2021

View reviewed changes

google-oss-robot assigned roberthbailey Feb 11, 2021

google-oss-robot added the lgtm label Feb 11, 2021

Review updates:

bae35f4

* Only remove example links on release (had to add `&zwnj;` because of strange markdown formatting issues) * Update fleet_autoscaling.py fleet name

markmandel force-pushed the cleanup/remove-simple-tcp-udp branch from 3152f31 to bae35f4 Compare February 12, 2021 22:46

google-oss-robot removed the lgtm label Feb 12, 2021

markmandel merged commit c833e5d into googleforgames:main Feb 12, 2021

markmandel deleted the cleanup/remove-simple-tcp-udp branch February 12, 2021 23:21

markmandel added this to the 1.13.0 milestone Feb 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove simple-tcp and simple-udp #1992

Remove simple-tcp and simple-udp #1992

markmandel commented Feb 11, 2021

agones-bot commented Feb 11, 2021

markmandel commented Feb 11, 2021

agones-bot commented Feb 11, 2021

roberthbailey left a comment

roberthbailey Feb 11, 2021

markmandel Feb 11, 2021

roberthbailey Feb 11, 2021

roberthbailey Feb 11, 2021

markmandel Feb 11, 2021

markmandel Feb 11, 2021

roberthbailey Feb 11, 2021

markmandel Feb 11, 2021

markmandel Feb 12, 2021

agones-bot commented Feb 11, 2021

google-oss-robot commented Feb 11, 2021

google-oss-robot commented Feb 12, 2021

agones-bot commented Feb 12, 2021

		@@ -21,8 +21,6 @@ These are full examples for each of the resource types of Agones

		These are all examples of simple game server implementations, that integrate the Agones game server SDK.

		- {{< ghlink href="examples/simple-udp" >}}Simple UDP{{< /ghlink >}} (Go) - simple server and client that send UDP packets back and forth.

Remove simple-tcp and simple-udp #1992

Remove simple-tcp and simple-udp #1992

Conversation

markmandel commented Feb 11, 2021

agones-bot commented Feb 11, 2021

markmandel commented Feb 11, 2021

agones-bot commented Feb 11, 2021

roberthbailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agones-bot commented Feb 11, 2021

google-oss-robot commented Feb 11, 2021

google-oss-robot commented Feb 12, 2021

agones-bot commented Feb 12, 2021