Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate SDKGracefulTermination to beta #2831

Closed
zmerlynn opened this issue Nov 29, 2022 · 3 comments · Fixed by #2836
Closed

Graduate SDKGracefulTermination to beta #2831

zmerlynn opened this issue Nov 29, 2022 · 3 comments · Fixed by #2836
Assignees
@zmerlynn
Labels
kind/feature New features for Agones
Milestone
1.29.0

Comments

@zmerlynn
Copy link
Collaborator

I propose graduating SDKGracefulTermination to Beta. I would like to rely on this in #2794, and the gate combinatorics may get complicated.

In support of graduation:

cc @roberthbailey @markmandel for thoughts and @bennetty @theminecoder as original authors.
@zmerlynn zmerlynn added the kind/feature New features for Agones label Nov 29, 2022
@zmerlynn zmerlynn self-assigned this Nov 29, 2022
@roberthbailey
Copy link
Member

+1 to promoting for the next release.

@markmandel
Copy link
Member

+1 from me too. Let's do it!

@theminecoder
Copy link

Yay!

This was referenced Nov 30, 2022
Merged
Closed
zmerlynn added a commit to zmerlynn/agones that referenced this issue Dec 8, 2022
@zmerlynn
SDKGracefulTermination: Promote to beta
3daf877 
Follows checklist in features.go.

Closes googleforgames#2831
zmerlynn added a commit to zmerlynn/agones that referenced this issue Dec 8, 2022
@zmerlynn
SDKGracefulTermination: Promote to beta
b829f0c 
Follows checklist in features.go.

Closes googleforgames#2831
markmandel added a commit that referenced this issue Dec 8, 2022
@zmerlynn @markmandel
SDKGracefulTermination: Promote to beta (#2836)
9fb1eef 
Follows checklist in features.go.

Closes #2831

Co-authored-by: Mark Mandel <markmandel@google.com>
zmerlynn added a commit that referenced this issue Dec 8, 2022
@zmerlynn
Rename LifecycleContract feature gate to SafeToEvict (#2849)
981b873 
* SDKGracefulTermination: Promote to beta

Follows checklist in features.go.

Closes #2831

* Rename `LifecycleContract` feature gate to `SafeToEvict`

Per #2794, rename `LifecycleContract` to `SafeToEvict`.
chiayi pushed a commit to chiayi/agones that referenced this issue Dec 13, 2022
@zmerlynn @markmandel @chiayi
SDKGracefulTermination: Promote to beta (googleforgames#2836)
ddc2aa3 
Follows checklist in features.go.

Closes googleforgames#2831

Co-authored-by: Mark Mandel <markmandel@google.com>
chiayi pushed a commit to chiayi/agones that referenced this issue Dec 13, 2022
@zmerlynn @chiayi
Rename LifecycleContract feature gate to SafeToEvict (googleforga…
5d66aab 
…mes#2849)

* SDKGracefulTermination: Promote to beta

Follows checklist in features.go.

Closes googleforgames#2831

* Rename `LifecycleContract` feature gate to `SafeToEvict`

Per googleforgames#2794, rename `LifecycleContract` to `SafeToEvict`.
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmerlynn zmerlynn

Labels
kind/feature New features for Agones
Projects
None yet
Milestone
1.29.0
Development

Successfully merging a pull request may close this issue.

SDKGracefulTermination: Promote to beta zmerlynn/agones
5 participants
@markmandel @theminecoder @zmerlynn @roberthbailey @Kalaiselvi84