Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LifecycleContract feature gate to SafeToEvict #2849

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Rename LifecycleContract feature gate to SafeToEvict #2849

merged 1 commit into from
Dec 8, 2022

Conversation

zmerlynn
Copy link
Collaborator

@zmerlynn zmerlynn commented Dec 5, 2022

Per #2794, rename LifecycleContract to SafeToEvict.

Special notes for your reviewer:

Sits on top of #2836 - merge that one first.

@zmerlynn zmerlynn changed the title Lifecycle-contract-to-safe-to-evict Rename LifecycleContract feature gate to SafeToEvict Dec 5, 2022
@zmerlynn zmerlynn added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Dec 5, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b1dfdf85-3668-492d-89cc-1f0dd56d7710

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2849/head:pr_2849 && git checkout pr_2849
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-7480e9a-amd64

gongmax
gongmax approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename part LGTM

@google-oss-prow google-oss-prow bot added the lgtm label Dec 5, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please ask for approval from roberthbailey by writing /assign @roberthbailey in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmerlynn zmerlynn mentioned this pull request Dec 7, 2022
Merged
@mangalpalli mangalpalli removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Dec 7, 2022
@markmandel markmandel enabled auto-merge (squash) December 8, 2022 17:43
@zmerlynn zmerlynn force-pushed the lifecycle-contract-to-safe-to-evict branch from 7480e9a to 042d25b Compare December 8, 2022 18:24
@google-oss-prow google-oss-prow bot removed the lgtm label Dec 8, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b386083c-bd70-4484-a7e6-36284ad2191d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2849/head:pr_2849 && git checkout pr_2849
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.29.0-042d25b-amd64

@zmerlynn
Rename LifecycleContract feature gate to SafeToEvict
e5b1d87 
Per googleforgames#2794, rename `LifecycleContract` to `SafeToEvict`.
@zmerlynn zmerlynn force-pushed the lifecycle-contract-to-safe-to-evict branch from 042d25b to e5b1d87 Compare December 8, 2022 19:18
@zmerlynn zmerlynn enabled auto-merge (squash) December 8, 2022 19:19
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f82e2f58-66e2-4061-966b-fe1f28104dbd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2849/head:pr_2849 && git checkout pr_2849
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.29.0-e5b1d87-amd64

@zmerlynn zmerlynn merged commit 981b873 into googleforgames:main Dec 8, 2022
chiayi pushed a commit to chiayi/agones that referenced this pull request Dec 13, 2022
@zmerlynn @chiayi
Rename LifecycleContract feature gate to SafeToEvict (googleforga…
5d66aab 
…mes#2849)

* SDKGracefulTermination: Promote to beta

Follows checklist in features.go.

Closes googleforgames#2831

* Rename `LifecycleContract` feature gate to `SafeToEvict`

Per googleforgames#2794, rename `LifecycleContract` to `SafeToEvict`.
@Kalaiselvi84 Kalaiselvi84 added this to the 1.29.0 milestone Jan 17, 2023
@zmerlynn zmerlynn deleted the lifecycle-contract-to-safe-to-evict branch January 25, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@roberthbailey roberthbailey

@gongmax gongmax

Labels
size/M
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zmerlynn @agones-bot @gongmax @roberthbailey @mangalpalli @Kalaiselvi84