Use environment variables to dynamically set the grpc port in the golang sdk. #1086

roberthbailey · 2019-09-28T07:45:38Z

I wrote some code to show what option 1 from #851 (comment) would look like, since it seemed like the best option to me.

I'll add tests and do some more checking if we decide to go this route, but I've already verified:

The sdk / sdkserver can be set to different ports and the gameserver becomes ready
If you specify the env vars they get overridden
If you specify the env vars in a configmap using EnvFromSource they get overridden

so it seems pretty robust.

agones-bot · 2019-09-28T08:09:28Z

Build Succeeded 👏

Build Id: 7edbe592-fb1d-48ef-ab27-7542d2f7f964

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-9fea6df
image: gcr.io/agones-images/agones-sdk:1.1.0-9fea6df
image: gcr.io/agones-images/agones-ping:1.1.0-9fea6df
Linux C++ SDK (build): agonessdk-1.1.0-9fea6df-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-9fea6df.zip

A preview of the website (the last 30 builds are retained):

https://9fea6df-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1086/head:pr_1086 && git checkout pr_1086
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-9fea6df

markmandel

👍 I'm in 100% agreement on approach here, it's the most robust and flexible. Just think we should remove the fiter on only the gameserver and apply to all.

We should also include some docs on these environment variables - some people have written their own REST API clients, so will want to be able to know what the ports are going forward.

pkg/gameservers/controller.go

roberthbailey · 2019-09-30T07:27:11Z

We should also include some docs on these environment variables

I was waiting for a +1 on the approach before finishing the PR. I've added unit tests and documentation.

agones-bot · 2019-09-30T07:49:42Z

Build Succeeded 👏

Build Id: 73fe4792-e376-43ce-83c7-dfe618b80e7b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-2842cc0
image: gcr.io/agones-images/agones-sdk:1.1.0-2842cc0
image: gcr.io/agones-images/agones-ping:1.1.0-2842cc0
Linux C++ SDK (build): agonessdk-1.1.0-2842cc0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-2842cc0.zip

A preview of the website (the last 30 builds are retained):

https://2842cc0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1086/head:pr_1086 && git checkout pr_1086
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2842cc0

agones-bot · 2019-09-30T22:17:29Z

Build Succeeded 👏

Build Id: dc087191-257a-46c8-9a2d-07d90df864f6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-2dd4893
image: gcr.io/agones-images/agones-sdk:1.1.0-2dd4893
image: gcr.io/agones-images/agones-ping:1.1.0-2dd4893
Linux C++ SDK (build): agonessdk-1.1.0-2dd4893-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-2dd4893.zip

A preview of the website (the last 30 builds are retained):

https://2dd4893-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1086/head:pr_1086 && git checkout pr_1086
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-2dd4893

markmandel

Couple of small things, but otherwise, this looks great 👍

pkg/gameservers/controller.go

sdks/go/sdk.go

roberthbailey · 2019-10-01T07:34:46Z

I found a few more places on the website to update with the new environment variable.

I also noticed that https://agones.dev/site/docs/guides/client-sdks/unreal/#settings is rendering the list content incorrectly. It looks correct in my markdown preview window, so I'm not sure what docsy/hugo is doing to it.

agones-bot · 2019-10-01T07:57:36Z

Build Succeeded 👏

Build Id: 3e14458e-ff94-4d8d-944f-e7f2902b846e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-009ec47
image: gcr.io/agones-images/agones-sdk:1.1.0-009ec47
image: gcr.io/agones-images/agones-ping:1.1.0-009ec47
Linux C++ SDK (build): agonessdk-1.1.0-009ec47-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-009ec47.zip

A preview of the website (the last 30 builds are retained):

https://009ec47-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1086/head:pr_1086 && git checkout pr_1086
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-009ec47

in the golang sdk.

agones-bot · 2019-10-01T19:15:10Z

Build Succeeded 👏

Build Id: 0c0d2661-3e1c-413b-a667-296ad37a5c0a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-bb3c0fb
image: gcr.io/agones-images/agones-sdk:1.1.0-bb3c0fb
image: gcr.io/agones-images/agones-ping:1.1.0-bb3c0fb
Linux C++ SDK (build): agonessdk-1.1.0-bb3c0fb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-bb3c0fb.zip

A preview of the website (the last 30 builds are retained):

https://bb3c0fb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1086/head:pr_1086 && git checkout pr_1086
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-bb3c0fb

markmandel

LGTM!

Also https://bb3c0fb-dot-preview-dot-agones-images.appspot.com/site/docs/guides/client-sdks/unreal/ looks correct - maybe the updated hugo version fixed it?

google-oss-robot · 2019-10-01T22:27:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: markmandel, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot added do-not-merge/work-in-progress size/M labels Sep 28, 2019

roberthbailey mentioned this pull request Sep 28, 2019

Sidecar occasionally fails to start up #851

Closed

markmandel reviewed Sep 28, 2019

View reviewed changes

pkg/gameservers/controller.go Outdated Show resolved Hide resolved

pkg/gameservers/controller.go Outdated Show resolved Hide resolved

roberthbailey force-pushed the go-sdk-dynamic-port branch from 9fea6df to 2842cc0 Compare September 30, 2019 07:25

google-oss-robot added size/L and removed size/M labels Sep 30, 2019

roberthbailey marked this pull request as ready for review September 30, 2019 07:27

google-oss-robot removed the do-not-merge/work-in-progress label Sep 30, 2019

roberthbailey changed the title ~~Prototype of using env variables to dynamically set the grpc port in the golang sdk.~~ Use environment variables to dynamically set the grpc port in the golang sdk. Sep 30, 2019

roberthbailey force-pushed the go-sdk-dynamic-port branch from 2842cc0 to 2dd4893 Compare September 30, 2019 21:52

markmandel added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Sep 30, 2019

markmandel reviewed Sep 30, 2019

View reviewed changes

pkg/gameservers/controller.go Outdated Show resolved Hide resolved

sdks/go/sdk.go Show resolved Hide resolved

sdks/go/sdk.go Show resolved Hide resolved

roberthbailey force-pushed the go-sdk-dynamic-port branch 2 times, most recently from b93b806 to 009ec47 Compare October 1, 2019 07:32

Prototype of using env variables to dynamically set the grpc port

bb3c0fb

in the golang sdk.

roberthbailey force-pushed the go-sdk-dynamic-port branch from 009ec47 to bb3c0fb Compare October 1, 2019 18:49

markmandel approved these changes Oct 1, 2019

View reviewed changes

google-oss-robot assigned markmandel Oct 1, 2019

google-oss-robot added the lgtm label Oct 1, 2019

markmandel merged commit c64de9f into googleforgames:master Oct 1, 2019

roberthbailey mentioned this pull request Oct 16, 2019

Added dynamic configuration of http port in the unity sdk #1121

Merged

markmandel added this to the 1.1.0 milestone Oct 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use environment variables to dynamically set the grpc port in the golang sdk. #1086

Use environment variables to dynamically set the grpc port in the golang sdk. #1086

roberthbailey commented Sep 28, 2019

agones-bot commented Sep 28, 2019

markmandel left a comment

roberthbailey commented Sep 30, 2019

agones-bot commented Sep 30, 2019

agones-bot commented Sep 30, 2019

markmandel left a comment

roberthbailey commented Oct 1, 2019

agones-bot commented Oct 1, 2019

agones-bot commented Oct 1, 2019

markmandel left a comment

google-oss-robot commented Oct 1, 2019

Use environment variables to dynamically set the grpc port in the golang sdk. #1086

Use environment variables to dynamically set the grpc port in the golang sdk. #1086

Conversation

roberthbailey commented Sep 28, 2019

agones-bot commented Sep 28, 2019

markmandel left a comment

Choose a reason for hiding this comment

roberthbailey commented Sep 30, 2019

agones-bot commented Sep 30, 2019

agones-bot commented Sep 30, 2019

markmandel left a comment

Choose a reason for hiding this comment

roberthbailey commented Oct 1, 2019

agones-bot commented Oct 1, 2019

agones-bot commented Oct 1, 2019

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Oct 1, 2019