Added dynamic configuration of http port in the unity sdk #1121

roberthbailey · 2019-10-16T07:13:31Z

@dzlier-gcp -- I'm looking for feedback on the way that I'm getting the environment variable and converting it to an integer. This follows the pattern I implemented for Go / nodejs, but in the C++ sdk I went with a more concise solution (with less logging / error checking) since that was considered more stylistically correct.

Part of #851.

agones-bot · 2019-10-16T07:44:11Z

Build Succeeded 👏

Build Id: 97744ec9-8924-4d7a-87ec-9a7be37dfc2d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-b67ec4a
image: gcr.io/agones-images/agones-sdk:1.1.0-b67ec4a
image: gcr.io/agones-images/agones-ping:1.1.0-b67ec4a
Linux C++ SDK (build): agonessdk-1.1.0-b67ec4a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-b67ec4a.zip

A preview of the website (the last 30 builds are retained):

https://b67ec4a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1121/head:pr_1121 && git checkout pr_1121
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b67ec4a

agones-bot · 2019-10-16T07:45:13Z

Build Succeeded 👏

Build Id: 774a885e-c59a-43a0-8349-b5fc402cb63e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-d8eefaf
image: gcr.io/agones-images/agones-sdk:1.1.0-d8eefaf
image: gcr.io/agones-images/agones-ping:1.1.0-d8eefaf
Linux C++ SDK (build): agonessdk-1.1.0-d8eefaf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-d8eefaf.zip

A preview of the website (the last 30 builds are retained):

https://d8eefaf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1121/head:pr_1121 && git checkout pr_1121
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-d8eefaf

pooneh-m · 2019-10-17T17:56:24Z

sdks/unity/AgonesSdk.cs

@@ -153,7 +184,7 @@ private async Task<bool> SendRequestAsync(string api, string json, string method
            // To prevent that an async method leaks after destroying this gameObject.
            cancellationTokenSource.Token.ThrowIfCancellationRequested();

-            var req = new UnityWebRequest(sidecarAddress + api, method)
+            var req = new UnityWebRequest(sidecarHost + ":" + sidecarPort + api, method)
            {


This is more readable: String.Format("{0}:{1}{2}", sidecarHost, sidecarPort, api);

I've changed this back to how it looked originally.

sdks/unity/AgonesSdk.cs

dzlier-gcp

Yes this is fine. In fact when this file was added I asked if that port was constant or if it should be a variable, and was assured it was a constant heh.

roberthbailey · 2019-10-18T20:28:24Z

In fact when this file was added I asked if that port was constant or if it should be a variable, and was assured it was a constant heh.

It was ... until we found a bug and decided it needed to be changed. Since we can't ensure that whatever port we pick will always be free of conflicts, we decided to make it configurable.

pooneh-m · 2019-10-18T20:29:03Z

sdks/unity/AgonesSdk.cs

@@ -58,6 +58,8 @@ private struct KeyValueMessage
        // Use this for initialization.
        private void Start()
        {
+            String port = Environment.GetEnvironmentVariable("AGONES_SDK_HTTP_PORT");
+            sidecarAddress = "http://localhost:" + (port != null ? port : "59358");


you can replace it with ??
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/null-coalescing-operator

Sweet. I've updated it.

google-oss-robot · 2019-10-18T20:29:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dzlier-gcp, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dzlier-gcp,pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-10-18T20:34:16Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-10-18T20:55:48Z

Build Succeeded 👏

Build Id: a591ca96-320c-448a-a441-fecee380eae7

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-ecb609e
image: gcr.io/agones-images/agones-sdk:1.1.0-ecb609e
image: gcr.io/agones-images/agones-ping:1.1.0-ecb609e
Linux C++ SDK (build): agonessdk-1.1.0-ecb609e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-ecb609e.zip

A preview of the website (the last 30 builds are retained):

https://ecb609e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1121/head:pr_1121 && git checkout pr_1121
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-ecb609e

agones-bot · 2019-10-18T21:08:07Z

Build Succeeded 👏

Build Id: 44c11c59-0413-4c37-a544-48954ba47d46

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-a343963
image: gcr.io/agones-images/agones-sdk:1.1.0-a343963
image: gcr.io/agones-images/agones-ping:1.1.0-a343963
Linux C++ SDK (build): agonessdk-1.1.0-a343963-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-a343963.zip

A preview of the website (the last 30 builds are retained):

https://a343963-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1121/head:pr_1121 && git checkout pr_1121
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-a343963

agones-bot · 2019-10-18T21:10:25Z

Build Succeeded 👏

Build Id: e0bee085-f4e0-4e44-aad9-4c8b469569c5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-98d2ffa
image: gcr.io/agones-images/agones-sdk:1.1.0-98d2ffa
image: gcr.io/agones-images/agones-ping:1.1.0-98d2ffa
Linux C++ SDK (build): agonessdk-1.1.0-98d2ffa-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-98d2ffa.zip

A preview of the website (the last 30 builds are retained):

https://98d2ffa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1121/head:pr_1121 && git checkout pr_1121
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-98d2ffa

google-oss-robot requested review from joeholley and markmandel October 16, 2019 07:13

google-oss-robot added approved size/M labels Oct 16, 2019

roberthbailey force-pushed the unity-sdk-dynamic-port branch from b67ec4a to d8eefaf Compare October 16, 2019 07:15

roberthbailey changed the title ~~Added dynamic configuration of http port.~~ Added dynamic configuration of http port in the unity sdk Oct 16, 2019

pooneh-m reviewed Oct 17, 2019

View reviewed changes

roberthbailey force-pushed the unity-sdk-dynamic-port branch from d8eefaf to ecb609e Compare October 18, 2019 20:21

google-oss-robot added size/XS and removed size/M labels Oct 18, 2019

dzlier-gcp approved these changes Oct 18, 2019

View reviewed changes

google-oss-robot assigned dzlier-gcp Oct 18, 2019

google-oss-robot added the lgtm label Oct 18, 2019

pooneh-m approved these changes Oct 18, 2019

View reviewed changes

google-oss-robot assigned pooneh-m Oct 18, 2019

roberthbailey force-pushed the unity-sdk-dynamic-port branch from ecb609e to a343963 Compare October 18, 2019 20:34

google-oss-robot removed the lgtm label Oct 18, 2019

Added dynamic configuration of http port.

98d2ffa

roberthbailey force-pushed the unity-sdk-dynamic-port branch from a343963 to 98d2ffa Compare October 18, 2019 20:35

roberthbailey merged commit 1cded0a into googleforgames:master Oct 19, 2019

markmandel added this to the 1.1.0 milestone Oct 22, 2019

markmandel added the area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc label Oct 22, 2019

markmandel added the kind/feature New features for Agones label Oct 22, 2019

roberthbailey deleted the unity-sdk-dynamic-port branch August 24, 2020 23:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added dynamic configuration of http port in the unity sdk #1121

Added dynamic configuration of http port in the unity sdk #1121

roberthbailey commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

pooneh-m Oct 17, 2019

roberthbailey Oct 18, 2019

dzlier-gcp left a comment

roberthbailey commented Oct 18, 2019

pooneh-m Oct 18, 2019

roberthbailey Oct 18, 2019

google-oss-robot commented Oct 18, 2019

google-oss-robot commented Oct 18, 2019

agones-bot commented Oct 18, 2019

agones-bot commented Oct 18, 2019

agones-bot commented Oct 18, 2019

Added dynamic configuration of http port in the unity sdk #1121

Added dynamic configuration of http port in the unity sdk #1121

Conversation

roberthbailey commented Oct 16, 2019

agones-bot commented Oct 16, 2019

agones-bot commented Oct 16, 2019

pooneh-m Oct 17, 2019

Choose a reason for hiding this comment

roberthbailey Oct 18, 2019

Choose a reason for hiding this comment

dzlier-gcp left a comment

Choose a reason for hiding this comment

roberthbailey commented Oct 18, 2019

pooneh-m Oct 18, 2019

Choose a reason for hiding this comment

roberthbailey Oct 18, 2019

Choose a reason for hiding this comment

google-oss-robot commented Oct 18, 2019

google-oss-robot commented Oct 18, 2019

agones-bot commented Oct 18, 2019

agones-bot commented Oct 18, 2019

agones-bot commented Oct 18, 2019