Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the port to connect to the sdkserver based on the AGONES_SDK_GRPC_PORT environment variable #1092

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Set the port to connect to the sdkserver based on the AGONES_SDK_GRPC_PORT environment variable #1092

merged 1 commit into from
Oct 16, 2019

Conversation

roberthbailey
Copy link
Member

@devjgm -- looking for some feedback on the way that I'm getting the environment variable and converting it to an integer. I'm not sure whether either is proper C++ (it felt like I was writing C so I'm guessing there's a better way to do it).

Part of #851.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ff83615a-654f-48f3-bc01-b023b676de44

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e8bc3b3a-9f09-45d9-81ed-61ccd38bace9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-6cd12f8

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 138fdc1a-f3f7-4ca6-944d-fb311ce66333

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-7cd75d9

@aLekSer aLekSer mentioned this pull request Oct 2, 2019
Merged
devjgm
devjgm reviewed Oct 10, 2019
View reviewed changes
sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7a7dc901-849a-4194-964d-29d9dbb65fec

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-322c81f

devjgm
devjgm reviewed Oct 15, 2019
View reviewed changes
sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ec93a7b6-2fd5-4579-a404-9be74307a877

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-3127ef4

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d21b2333-aaf6-447b-9f1b-b8b04f882dd0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-265c197

devjgm
devjgm approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This looks better to me.

sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
sdks/cpp/src/agones/sdk.cc Outdated Show resolved Hide resolved
@google-oss-robot
Copy link

@devjgm: changing LGTM is restricted to collaborators

In response to this:

Thanks. This looks better to me.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey roberthbailey force-pushed the cpp-sdk-dynamic-port branch 2 times, most recently from 41412ed to 872ebaa Compare October 16, 2019 03:32
@roberthbailey
Copy link
Member Author

/assign @pooneh-m

(for approval, since @devjgm already lgtm'd it)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a3055946-fd81-4d2e-b528-82dc54d108fd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-41412ed

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 72a180c3-551a-4e91-aa55-f29f12c7f401

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-872ebaa

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devjgm, pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bfa32a18-2381-42f7-ac9b-09879bd1c2c8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1092/head:pr_1092 && git checkout pr_1092
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-10990b1

@roberthbailey roberthbailey merged commit 4c6c07a into googleforgames:master Oct 16, 2019
@roberthbailey roberthbailey mentioned this pull request Oct 16, 2019
Merged
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Oct 22, 2019
@roberthbailey roberthbailey deleted the cpp-sdk-dynamic-port branch August 24, 2020 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devjgm devjgm devjgm approved these changes

@pooneh-m pooneh-m pooneh-m approved these changes

Assignees

@pooneh-m pooneh-m

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones size/S
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@roberthbailey @agones-bot @google-oss-robot @devjgm @pooneh-m @markmandel