Document agones-allocator and multi-cluster allocation #1155

pooneh-m · 2019-10-28T07:32:49Z

No description provided.

agones-bot · 2019-10-28T07:42:08Z

Build Failed 😱

Build Id: d1cbb1ab-1d64-4c64-9f9f-3cedb67df210

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-28T17:19:04Z

Build Failed 😱

Build Id: 8afe0aca-f362-4105-9660-1f888dbe76cb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-10-28T18:20:10Z

Because the builds are failing I can't see a nice version of the markdown rendered in docsy.

This change seems unrelated to the build failures (as does #1119 which also failed last time I rebased) so I think something is going on with the CI system right now....

roberthbailey · 2019-10-28T18:22:51Z

I found this in the build logs:

Error: Error building site: logged 2 error(s)
make[3]: *** [site-static] Error 255
docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.helm:/root/.helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build --workdir=/go/src/agones.dev/agones/site  agones-build:418360257b rm -r ./public
includes/website.mk:35: recipe for target 'site-static' failed

If you run make site-static locally does it succeed?

pooneh-m · 2019-10-28T18:30:43Z

There was a reference to an image and the reference could not be resolved. I removed the reference as it is not needed. I'll add later, when I figured out the issue.

agones-bot · 2019-10-28T18:44:14Z

Build Failed 😱

Build Id: 2f4d9507-9d98-4368-8e94-16caa566dee1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-28T19:27:29Z

Build Succeeded 👏

Build Id: f5d5f767-df5e-4dce-a510-03573e2338c2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-12da9f2
image: gcr.io/agones-images/agones-sdk:1.1.0-12da9f2
image: gcr.io/agones-images/agones-ping:1.1.0-12da9f2
Linux C++ SDK (build): agonessdk-1.1.0-12da9f2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-12da9f2.zip

A preview of the website (the last 30 builds are retained):

https://12da9f2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1155/head:pr_1155 && git checkout pr_1155
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-12da9f2

roberthbailey · 2019-10-28T20:32:51Z

There was a reference to an image and the reference could not be resolved.

If you add a property data-proofer-ignore to the image it should be possible to leave it in and have the tests pass.

pooneh-m · 2019-10-28T21:32:30Z

There was a reference to an image and the reference could not be resolved.

If you add a property data-proofer-ignore to the image it should be possible to leave it in and have the tests pass.

Thanks. I'll leave it out for now. I hope to get the documentation reviewed by release to merge it in in-time. @roberthbailey will you have time for the review?

site/content/en/docs/Advanced/allocator-service.md

roberthbailey · 2019-10-28T21:51:00Z

site/content/en/docs/Advanced/allocator-service.md

+title: "Allocator Service"
+date: 2019-10-25T05:45:05Z
+description: >
+  Agones provides mTLS based allocator service that is accessible from outside the cluster using a load balancer. The service is deployed and scales independent to Agones controller.


Is the service always deployed? And an ELB always created by default using helm / yaml? Are there flags to turn it on / off?

It is by default deployed. Because the service is of type LoadBalancer, the cloud provider or GKE on-prem provides the LB.

site/content/en/docs/Advanced/allocator-service.md

site/content/en/docs/Advanced/multi-cluster-allocation.md

pooneh-m · 2019-10-29T00:09:36Z

Thanks @roberthbailey for your detailed review. Your feedback is very helpful.

agones-bot · 2019-10-29T00:21:38Z

Build Succeeded 👏

Build Id: c3666f02-6e80-42b8-8bc8-249a626eef66

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-e309c83
image: gcr.io/agones-images/agones-sdk:1.1.0-e309c83
image: gcr.io/agones-images/agones-ping:1.1.0-e309c83
Linux C++ SDK (build): agonessdk-1.1.0-e309c83-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-e309c83.zip

A preview of the website (the last 30 builds are retained):

https://e309c83-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1155/head:pr_1155 && git checkout pr_1155
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-e309c83

roberthbailey

Are there flags to turn it on / off?

We've missed the release train for 1.1, but I think that we should make it possible to disable this in the helm configuration (since it's an alpha feature). Unless we plan to promote it to beta before 1.2, I think doing that before 1.2 would be really nice.

site/content/en/docs/Advanced/allocator-service.md

site/content/en/docs/Advanced/multi-cluster-allocation.md

site/content/en/docs/Advanced/allocator-service.md

agones-bot · 2019-10-29T16:47:28Z

Build Succeeded 👏

Build Id: 8c3753f4-ba60-4c30-bc08-6c80fdb2b5b2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-4e728fd
image: gcr.io/agones-images/agones-sdk:1.1.0-4e728fd
image: gcr.io/agones-images/agones-ping:1.1.0-4e728fd
Linux C++ SDK (build): agonessdk-1.1.0-4e728fd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-4e728fd.zip

A preview of the website (the last 30 builds are retained):

https://4e728fd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1155/head:pr_1155 && git checkout pr_1155
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-4e728fd

agones-bot · 2019-10-29T16:52:35Z

Build Failed 😱

Build Id: 1664ed0f-e7d0-403b-97b9-50d04caa9568

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-10-29T17:07:09Z

Build Succeeded 👏

Build Id: a8c1db00-476e-4f68-9db5-cbb305fe386e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.1.0-900b1bf
image: gcr.io/agones-images/agones-sdk:1.1.0-900b1bf
image: gcr.io/agones-images/agones-ping:1.1.0-900b1bf
Linux C++ SDK (build): agonessdk-1.1.0-900b1bf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.1.0-900b1bf.zip

A preview of the website (the last 30 builds are retained):

https://900b1bf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1155/head:pr_1155 && git checkout pr_1155
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-900b1bf

google-oss-robot · 2019-10-29T17:44:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pooneh-m requested review from markmandel and roberthbailey October 28, 2019 07:32

google-oss-robot requested review from ilkercelikyilmaz and joeholley October 28, 2019 07:32

google-oss-robot added approved size/L labels Oct 28, 2019

roberthbailey removed request for joeholley and ilkercelikyilmaz October 28, 2019 07:40

pooneh-m force-pushed the doc branch from 33435d4 to 05c0d89 Compare October 28, 2019 17:08

pooneh-m force-pushed the doc branch from 05c0d89 to 12da9f2 Compare October 28, 2019 18:27

roberthbailey reviewed Oct 28, 2019

View reviewed changes

pooneh-m force-pushed the doc branch from 12da9f2 to e309c83 Compare October 29, 2019 00:08

roberthbailey reviewed Oct 29, 2019

View reviewed changes

pooneh-m force-pushed the doc branch from e309c83 to 4e728fd Compare October 29, 2019 16:33

Document agones-allocator and multi-cluster allocation

900b1bf

pooneh-m force-pushed the doc branch from 4e728fd to 900b1bf Compare October 29, 2019 16:40

roberthbailey approved these changes Oct 29, 2019

View reviewed changes

google-oss-robot assigned roberthbailey Oct 29, 2019

google-oss-robot added the lgtm label Oct 29, 2019

roberthbailey merged commit 25e4705 into googleforgames:master Oct 29, 2019

markmandel added this to the 1.1.0 milestone Oct 29, 2019

markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Oct 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document agones-allocator and multi-cluster allocation #1155

Document agones-allocator and multi-cluster allocation #1155

pooneh-m commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

pooneh-m commented Oct 28, 2019 •

edited

Loading

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

pooneh-m commented Oct 28, 2019

roberthbailey Oct 28, 2019

pooneh-m Oct 28, 2019 •

edited

Loading

pooneh-m commented Oct 29, 2019

agones-bot commented Oct 29, 2019

roberthbailey left a comment

agones-bot commented Oct 29, 2019

agones-bot commented Oct 29, 2019

agones-bot commented Oct 29, 2019

google-oss-robot commented Oct 29, 2019

Document agones-allocator and multi-cluster allocation #1155

Document agones-allocator and multi-cluster allocation #1155

Conversation

pooneh-m commented Oct 28, 2019

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

pooneh-m commented Oct 28, 2019 • edited Loading

agones-bot commented Oct 28, 2019

agones-bot commented Oct 28, 2019

roberthbailey commented Oct 28, 2019

pooneh-m commented Oct 28, 2019

roberthbailey Oct 28, 2019

Choose a reason for hiding this comment

pooneh-m Oct 28, 2019 • edited Loading

Choose a reason for hiding this comment

pooneh-m commented Oct 29, 2019

agones-bot commented Oct 29, 2019

roberthbailey left a comment

Choose a reason for hiding this comment

agones-bot commented Oct 29, 2019

agones-bot commented Oct 29, 2019

agones-bot commented Oct 29, 2019

google-oss-robot commented Oct 29, 2019

pooneh-m commented Oct 28, 2019 •

edited

Loading

pooneh-m Oct 28, 2019 •

edited

Loading