Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra debugging for TestGameServerRestartBeforeReadyCrash #1172

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Extra debugging for TestGameServerRestartBeforeReadyCrash #1172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/e2e/gameserver_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,8 @@ func TestGameServerRestartBeforeReadyCrash(t *testing.T) {
assert.NoError(t, err)
defer conn.Close() // nolint: errcheck
// doing this last, so that there is a short delay between the msg being sent, and the check.
logger.WithField("gs", gs.ObjectMeta.Name).WithField("msg", msg).Info("sending message")
logger.WithField("gs", gs.ObjectMeta.Name).WithField("msg", msg).
WithField("state", gs.Status.State).Info("sending message")
if _, err = conn.Write([]byte(msg)); err != nil {
logger.WithError(err).WithField("gs", gs.ObjectMeta.Name).
WithField("state", gs.Status.State).Info("error sending packet")
Expand Down Expand Up @@ -300,7 +301,7 @@ func TestGameServerRestartBeforeReadyCrash(t *testing.T) {
return false
})
if err != nil {
assert.Failf(t, "Could not make GameServer Ready: %v", err.Error())
assert.FailNowf(t, "Could not make GameServer Ready: %v", err.Error())
}
// now crash, should be unhealthy, since it's after being Ready
logger.Info("crashing again, should be unhealthy")
Expand Down