Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for allocator helm args #1221

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix documentation for allocator helm args #1221

merged 1 commit into from
Dec 9, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Dec 9, 2019

closes: #1216

@pooneh-m pooneh-m requested review from markmandel and removed request for EricFortin December 9, 2019 19:13
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 549d8cf0-370c-4c31-a9f2-b34163bb2b69

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1221/head:pr_1221 && git checkout pr_1221
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-1ca18e0

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones kind/bug These are bugs. and removed kind/cleanup Refactoring code, fixing up documentation, etc labels Dec 9, 2019
markmandel
markmandel approved these changes Dec 9, 2019
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel merged commit f3551be into googleforgames:master Dec 9, 2019
@markmandel markmandel added this to the 1.2.0 milestone Dec 9, 2019
aLekSer
aLekSer reviewed Dec 10, 2019
View reviewed changes
install/helm/agones/values.yaml
@@ -117,7 +117,6 @@ agones:
operator: Exists
replicas: 3
http:
expose: true
response: ok
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have removed http.response from docs, but left in values.

@aLekSer
Copy link
Collaborator

aLekSer commented Dec 10, 2019 •
edited
Loading

Oops, It seems that I commented, but forgot to start the review yesterday.
Followed the guide, found additional points, so will open additional PR.

@aLekSer aLekSer mentioned this pull request Dec 10, 2019
Merged
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@pooneh-m @ilkercelikyilmaz
fix documentation for allocator helm args (googleforgames#1221)
db5f5cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer left review comments

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

Labels
approved kind/bug These are bugs. kind/documentation Documentation for Agones lgtm size/XS
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

agones.allocator.http.expose and agones.allocator.http.response are documented but not consumed by Helm
5 participants
@pooneh-m @agones-bot @google-oss-robot @aLekSer @markmandel