Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for allocator helm args #1221

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix documentation for allocator helm args #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion install/helm/agones/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ agones:
operator: Exists
replicas: 3
http:
expose: true
response: ok
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have removed http.response from docs, but left in values.

port: 443
serviceType: LoadBalancer
Expand Down
3 changes: 1 addition & 2 deletions site/content/en/docs/Installation/helm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ The following tables lists the configurable parameters of the Agones chart and t
| `agones.ping.affinity` | Ping [affinity][affinity] settings for pod assignment | `{}` |
| `agones.allocator.install` | Whether to install the [allocator service][allocator] | `true` |
| `agones.allocator.replicas` | The number of replicas to run in the deployment | `3` |
| `agones.allocator.http.expose` | Expose the http allocator service via a Service | `true` |
| `agones.allocator.http.response` | The string response returned from the http service | `ok` |
| `agones.allocator.http.port` | The port to expose on the service | `443` |
| `agones.allocator.http.serviceType` | The [Service Type][service] of the HTTP Service | `LoadBalancer` |
| `agones.allocator.generateTLS` | Set to true to generate TLS certificates or false to provide certificates in `certs/allocator/*`| `true` |
Expand All @@ -187,6 +185,7 @@ The following tables lists the configurable parameters of the Agones chart and t
[constraints]: https://kubernetes.io/docs/tasks/administer-cluster/manage-resources/cpu-constraint-namespace/
[ping]: {{< ref "/docs/Guides/ping-service.md" >}}
[service]: https://kubernetes.io/docs/concepts/services-networking/service/
[allocator]: {{< ref "/docs/advanced/allocator-service.md" >}}

Specify each parameter using the `--set key=value[,key=value]` argument to `helm install`. For example,

Expand Down