Extra Debugging for TestGameServerReserve #1334

markmandel · 2020-02-11T02:32:38Z

Adds new WaitForGameServerStateWithLogger() function that makes it easier to track debug output for state checking for specific tests.

Also dumped out event data for the pod and gameserver on this test to see what else we can see.

agones-bot · 2020-02-11T02:50:07Z

Build Failed 😱

Build Id: 14057ea8-eaae-42a7-879b-80d41d8c673a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-11T03:07:57Z

Build Succeeded 👏

Build Id: b9d86cb6-3903-430f-a49f-1786f1a86801

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-3400ebf
image: gcr.io/agones-images/agones-sdk:1.4.0-3400ebf
image: gcr.io/agones-images/agones-ping:1.4.0-3400ebf
Linux C++ SDK (build): agonessdk-1.4.0-3400ebf-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-3400ebf.zip

A preview of the website (the last 30 builds are retained):

https://3400ebf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-3400ebf

agones-bot · 2020-02-11T23:45:45Z

Build Succeeded 👏

Build Id: a005efc0-a999-48e1-a7e4-c0c6bb6ee56a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-05d433d
image: gcr.io/agones-images/agones-sdk:1.4.0-05d433d
image: gcr.io/agones-images/agones-ping:1.4.0-05d433d
Linux C++ SDK (build): agonessdk-1.4.0-05d433d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-05d433d.zip

A preview of the website (the last 30 builds are retained):

https://05d433d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-05d433d

agones-bot · 2020-02-12T02:17:20Z

Build Failed 😱

Build Id: 2f53a152-b9fb-4f00-b85e-9218d2da049b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-13T18:46:03Z

Build Succeeded 👏

Build Id: 67dcfe8f-ee39-400e-86d7-c66198a1703d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-e15ce6a
image: gcr.io/agones-images/agones-sdk:1.4.0-e15ce6a
image: gcr.io/agones-images/agones-ping:1.4.0-e15ce6a
Linux C++ SDK (build): agonessdk-1.4.0-e15ce6a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-e15ce6a.zip

A preview of the website (the last 30 builds are retained):

https://e15ce6a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e15ce6a

agones-bot · 2020-03-03T00:54:47Z

Build Succeeded 👏

Build Id: 1ea95318-d7ec-45e6-9820-c49fc08315be

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-5555eac
image: gcr.io/agones-images/agones-sdk:1.4.0-5555eac
image: gcr.io/agones-images/agones-ping:1.4.0-5555eac
Linux C++ SDK (build): agonessdk-1.4.0-5555eac-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-5555eac.zip

A preview of the website (the last 30 builds are retained):

https://5555eac-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-5555eac

agones-bot · 2020-03-03T01:55:32Z

Build Succeeded 👏

Build Id: 74d4295f-55d7-49ac-94d0-fd690a18d797

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-a93680b
image: gcr.io/agones-images/agones-sdk:1.4.0-a93680b
image: gcr.io/agones-images/agones-ping:1.4.0-a93680b
Linux C++ SDK (build): agonessdk-1.4.0-a93680b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-a93680b.zip

A preview of the website (the last 30 builds are retained):

https://a93680b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-a93680b

agones-bot · 2020-03-03T03:34:27Z

Build Succeeded 👏

Build Id: 4e39623a-92e2-4a0d-b8f2-aac8abae6df3

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-a65bb72
image: gcr.io/agones-images/agones-sdk:1.4.0-a65bb72
image: gcr.io/agones-images/agones-ping:1.4.0-a65bb72
Linux C++ SDK (build): agonessdk-1.4.0-a65bb72-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-a65bb72.zip

A preview of the website (the last 30 builds are retained):

https://a65bb72-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-a65bb72

agones-bot · 2020-03-03T03:57:34Z

Build Succeeded 👏

Build Id: 40c20f0c-68b1-497b-8687-067733c7ecd6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-a65bb72
image: gcr.io/agones-images/agones-sdk:1.4.0-a65bb72
image: gcr.io/agones-images/agones-ping:1.4.0-a65bb72
Linux C++ SDK (build): agonessdk-1.4.0-a65bb72-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-a65bb72.zip

A preview of the website (the last 30 builds are retained):

https://a65bb72-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-a65bb72

agones-bot · 2020-03-03T04:12:21Z

Build Failed 😱

Build Id: b1bd92dc-8863-4d11-997a-c81655314047

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-03T19:45:57Z

Build Succeeded 👏

Build Id: a87a7e76-5360-4b7f-97bb-5023e3b1dfab

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-58a83a6
image: gcr.io/agones-images/agones-sdk:1.4.0-58a83a6
image: gcr.io/agones-images/agones-ping:1.4.0-58a83a6
Linux C++ SDK (build): agonessdk-1.4.0-58a83a6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-58a83a6.zip

A preview of the website (the last 30 builds are retained):

https://58a83a6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-58a83a6

agones-bot · 2020-03-03T20:26:43Z

Build Succeeded 👏

Build Id: 6653a3e8-f92e-4209-b91a-8f48e9a9fbe5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-58a83a6
image: gcr.io/agones-images/agones-sdk:1.4.0-58a83a6
image: gcr.io/agones-images/agones-ping:1.4.0-58a83a6
Linux C++ SDK (build): agonessdk-1.4.0-58a83a6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-58a83a6.zip

A preview of the website (the last 30 builds are retained):

https://58a83a6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-58a83a6

agones-bot · 2020-03-03T20:58:54Z

Build Succeeded 👏

Build Id: a45005c0-1658-4c7e-af69-447bc5b1ab4b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-58a83a6
image: gcr.io/agones-images/agones-sdk:1.4.0-58a83a6
image: gcr.io/agones-images/agones-ping:1.4.0-58a83a6
Linux C++ SDK (build): agonessdk-1.4.0-58a83a6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-58a83a6.zip

A preview of the website (the last 30 builds are retained):

https://58a83a6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-58a83a6

agones-bot · 2020-03-04T22:26:01Z

Build Succeeded 👏

Build Id: f73cc997-4c64-444a-b147-a5ec78bd38c6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-28b3bb9
image: gcr.io/agones-images/agones-sdk:1.4.0-28b3bb9
image: gcr.io/agones-images/agones-ping:1.4.0-28b3bb9
Linux C++ SDK (build): agonessdk-1.4.0-28b3bb9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-28b3bb9.zip

A preview of the website (the last 30 builds are retained):

https://28b3bb9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-28b3bb9

Adds new WaitForGameServerStateWithLogger() function that makes it easier to track debug output for state checking for specific tests. Also dumped out event data for the pod and gameserver on this test to see what else we can see.

markmandel · 2020-03-05T18:58:37Z

Marking this as Ready for review (a) to try and get more data on why this is failing once it's been merged and (b) there are some useful tools in here that might be valuable to others.

aLekSer

Not sure why go.sum with klog is there. But overall we need to know why E2E tests crash.
go.sum was probably the main difference with k8s.io/apimachinery root.

google-oss-robot · 2020-03-05T19:11:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-03-05T19:14:21Z

Build Succeeded 👏

Build Id: 44aedfd1-62c7-4106-beff-22cdb7059dc2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-cc29939
image: gcr.io/agones-images/agones-sdk:1.5.0-cc29939
image: gcr.io/agones-images/agones-ping:1.5.0-cc29939
Linux C++ SDK (build): agonessdk-1.5.0-cc29939-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-cc29939.zip

A preview of the website (the last 30 builds are retained):

https://cc29939-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1334/head:pr_1334 && git checkout pr_1334
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-cc29939

Adds new WaitForGameServerStateWithLogger() function that makes it easier to track debug output for state checking for specific tests. Also dumped out event data for the pod and gameserver on this test to see what else we can see.

markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Feb 11, 2020

google-oss-robot added the do-not-merge/work-in-progress label Feb 11, 2020

google-oss-robot requested review from cyriltovena and dzlier-gcp February 11, 2020 02:32

google-oss-robot added approved size/XS labels Feb 11, 2020

markmandel force-pushed the flaky/TestGameServerReserve branch from 875e57c to e15ce6a Compare February 13, 2020 18:28

google-oss-robot added size/S and removed size/XS labels Feb 13, 2020

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Feb 26, 2020

markmandel force-pushed the flaky/TestGameServerReserve branch from e15ce6a to 5555eac Compare March 3, 2020 00:38

markmandel force-pushed the flaky/TestGameServerReserve branch from a93680b to a65bb72 Compare March 3, 2020 03:15

google-oss-robot added size/M and removed size/S labels Mar 3, 2020

markmandel force-pushed the flaky/TestGameServerReserve branch from 0946990 to 58a83a6 Compare March 3, 2020 19:28

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Mar 4, 2020

Extra Debugging for TestGameServerReserve

cc29939

Adds new WaitForGameServerStateWithLogger() function that makes it easier to track debug output for state checking for specific tests. Also dumped out event data for the pod and gameserver on this test to see what else we can see.

markmandel force-pushed the flaky/TestGameServerReserve branch from 28b3bb9 to cc29939 Compare March 5, 2020 18:57

markmandel changed the title ~~Fix for Flaky TestGameServerReserve~~ Extra Debugging for TestGameServerReserve Mar 5, 2020

markmandel marked this pull request as ready for review March 5, 2020 18:58

google-oss-robot removed the do-not-merge/work-in-progress label Mar 5, 2020

aLekSer self-requested a review March 5, 2020 19:10

aLekSer approved these changes Mar 5, 2020

View reviewed changes

google-oss-robot assigned aLekSer Mar 5, 2020

google-oss-robot added the lgtm label Mar 5, 2020

markmandel added this to the 1.5.0 milestone Mar 5, 2020

markmandel merged commit 53fafa9 into googleforgames:master Mar 5, 2020

markmandel deleted the flaky/TestGameServerReserve branch March 5, 2020 19:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extra Debugging for TestGameServerReserve #1334

Extra Debugging for TestGameServerReserve #1334

markmandel commented Feb 11, 2020 •

edited

Loading

agones-bot commented Feb 11, 2020

agones-bot commented Feb 11, 2020

agones-bot commented Feb 11, 2020

agones-bot commented Feb 12, 2020

agones-bot commented Feb 13, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 4, 2020

markmandel commented Mar 5, 2020 •

edited

Loading

aLekSer left a comment •

edited

Loading

google-oss-robot commented Mar 5, 2020

agones-bot commented Mar 5, 2020

Extra Debugging for TestGameServerReserve #1334

Extra Debugging for TestGameServerReserve #1334

Conversation

markmandel commented Feb 11, 2020 • edited Loading

agones-bot commented Feb 11, 2020

agones-bot commented Feb 11, 2020

agones-bot commented Feb 11, 2020

agones-bot commented Feb 12, 2020

agones-bot commented Feb 13, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 4, 2020

markmandel commented Mar 5, 2020 • edited Loading

aLekSer left a comment • edited Loading

Choose a reason for hiding this comment

google-oss-robot commented Mar 5, 2020

agones-bot commented Mar 5, 2020

markmandel commented Feb 11, 2020 •

edited

Loading

markmandel commented Mar 5, 2020 •

edited

Loading

aLekSer left a comment •

edited

Loading