Update images with latest everything #1261 #1344

akremsa · 2020-02-18T10:38:43Z

Original issue #1261

Following components were updated (tested using minikube only):

simple-udp
allocator-service
rust-simple
autoscaler-webhook
xonotic
cpp-simple
crd-client

On hold:

unity-simple
nodejs-simple

To do: test updated components on google cloud.

googlebot · 2020-02-18T10:39:01Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

agones-bot · 2020-02-18T10:48:43Z

Build Failed 😱

Build Id: 19f5195a-8f3a-41ac-8063-bbed7fcbe981

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-18T12:09:59Z

Build Failed 😱

Build Id: 71cba953-136a-4e79-abf2-e3b5232956d1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Thanks for putting this together!!! 👍

For the future, this probably would have been easier to review with seperate PRs for each example update, rather than one large one.

I can get the new simple-udp image built and live to let you test as well.

Also, why the change to past blog posts, I feel like they should stay as snapshots of the releases at the time.

Does that make sense?

googlebot · 2020-02-19T10:46:29Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

agones-bot · 2020-02-19T10:56:11Z

Build Failed 😱

Build Id: c332a345-7043-45dd-ba5c-9a9e65c3c57d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-19T11:14:10Z

Build Failed 😱

Build Id: 86465e6b-77ba-4198-8c21-941c2b7349ed

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

akremsa · 2020-02-19T11:17:55Z

@markmandel thanks for the reply!
I've updated this PR taking into account your suggestions.

agones-bot · 2020-02-19T11:19:26Z

Build Failed 😱

Build Id: d81b4c2c-009a-414e-8930-7b5560d335b0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

examples/simple-tcp/gameserver.yaml

agones-bot · 2020-02-19T11:24:02Z

Build Failed 😱

Build Id: dc812f2c-70c2-4a12-bee0-3b36521c6e7d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-19T11:32:04Z

Build Failed 😱

Build Id: d251124c-313d-4f70-b56b-4d6fb2566857

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-19T12:24:15Z

Build Failed 😱

Build Id: a0bd3bc7-37b5-45d0-bb7a-5c68f59a4402

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-02-19T12:29:51Z

@markmandel, please push the simple-udp image into gcr.io/agones-images for E2E tests to complete.

markmandel · 2020-02-20T20:55:25Z

gcr.io/agones-images/udp-server:0.18 is now pushed up!

aLekSer · 2020-02-21T20:27:43Z

There could be an issue with E2E tests here, next run from gcloud-test-cluster, not CI:

time="2020-02-21 16:50:32.929" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=simple-fleet-cbcw5                                                     
--- FAIL: TestTlsWebhook (310.36s)                                                                                                                                                                         
    fleetautoscaler_test.go:627: error waiting for fleet condition on fleet simple-fleet-cbcw5                                                                                                             
=== CONT  TestFleetRecreateGameServers/gameserver_shutdown
time="2020-02-21 16:50:34.310" level=info msg="waiting for fleet condition" fleet=simple-fleet-7q9mv                                                                                                       
time="2020-02-21 16:50:34.533" level=info msg="fleet simple-fleet-7q9mv has 0/10 ready replicas"                                                                                                           
time="2020-02-21 16:50:34.537" level=info msg="error waiting for fleet condition" error="timed out waiting for the condition" fleet=simple-fleet-psjwc                                                     
--- FAIL: TestAutoscalerWebhook (311.70s)                                                                                                                                                                  
    fleetautoscaler_test.go:411: error waiting for fleet condition on fleet simple-fleet-psjwc

markmandel · 2020-02-22T17:52:21Z

Just a heads up, I'll take care of nodejs-simple - just because I need to rejig the node publish system

markmandel

Can we also go through the site, and update that documentation as well:
https://github.com/googleforgames/agones/blob/master/site/config.toml#L94 (not release blog posts, but site documentation) - it shows up in a few places as well.

Outside of that, and the other comment, this looks good to go 👍

build/includes/minikube.mk

akremsa · 2020-02-24T09:34:55Z

Does the test TestTlsWebhook need to update the autoscaler-webhook tag?

I just pushed up the 0.3 version, in case you need it.

Image tag has already been updated in that test.

agones-bot · 2020-02-24T09:48:21Z

Build Succeeded 👏

Build Id: ff54bd3e-c644-4548-b6c9-76c5e1ce329f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-e9a21f7
image: gcr.io/agones-images/agones-sdk:1.4.0-e9a21f7
image: gcr.io/agones-images/agones-ping:1.4.0-e9a21f7
Linux C++ SDK (build): agonessdk-1.4.0-e9a21f7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-e9a21f7.zip

A preview of the website (the last 30 builds are retained):

https://e9a21f7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1344/head:pr_1344 && git checkout pr_1344
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e9a21f7

agones-bot · 2020-02-24T10:39:31Z

Build Failed 😱

Build Id: 0be2e603-1afb-4b85-9eac-0c52c5c97ac5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-02-24T11:43:21Z

Build Succeeded 👏

Build Id: 17d2dd44-eae7-4131-9182-d503b3982b5b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-ea19e32
image: gcr.io/agones-images/agones-sdk:1.4.0-ea19e32
image: gcr.io/agones-images/agones-ping:1.4.0-ea19e32
Linux C++ SDK (build): agonessdk-1.4.0-ea19e32-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-ea19e32.zip

A preview of the website (the last 30 builds are retained):

https://ea19e32-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1344/head:pr_1344 && git checkout pr_1344
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-ea19e32

updated simple-tcp simple-tcp updated allocator-service

Reverted imagePullPolicy back reverted md files back minor fix minor fixes removed redundant name field from metadata

agones-bot · 2020-02-25T17:09:05Z

Build Succeeded 👏

Build Id: 1c954712-547f-48fc-b5d3-2453787003a2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-019ee92
image: gcr.io/agones-images/agones-sdk:1.4.0-019ee92
image: gcr.io/agones-images/agones-ping:1.4.0-019ee92
Linux C++ SDK (build): agonessdk-1.4.0-019ee92-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-019ee92.zip

A preview of the website (the last 30 builds are retained):

https://019ee92-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1344/head:pr_1344 && git checkout pr_1344
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-019ee92

markmandel

Looks perfect 👍

markmandel · 2020-02-25T17:24:55Z

Image tag has already been updated in that test.

Ah, that explains why when I pushed up that image, it wasn't broken anymore 😄

google-oss-robot · 2020-02-25T17:32:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-02-25T17:32:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…mes#1344) * Updated simple udp updated simple-tcp simple-tcp updated allocator-service * updated rust-simple * updated autoscaler-webhook * Updated xonotic * Updated cpp-simple * Updated crd-client and alpine Reverted imagePullPolicy back reverted md files back minor fix minor fixes removed redundant name field from metadata * applied review notes

google-oss-robot added the do-not-merge/work-in-progress label Feb 18, 2020

google-oss-robot requested review from devjgm, EricFortin and pooneh-m February 18, 2020 10:38

google-oss-robot added the size/L label Feb 18, 2020

akremsa force-pushed the UpdateImagesWithLatest branch from 3df2f33 to 54c6bf0 Compare February 18, 2020 11:58

markmandel reviewed Feb 18, 2020

View reviewed changes

akremsa force-pushed the UpdateImagesWithLatest branch from 54c6bf0 to 25b0fb7 Compare February 19, 2020 10:46

akremsa force-pushed the UpdateImagesWithLatest branch 3 times, most recently from a7a640c to 72de269 Compare February 19, 2020 11:13

aLekSer reviewed Feb 19, 2020

View reviewed changes

examples/simple-tcp/gameserver.yaml Outdated Show resolved Hide resolved

akremsa force-pushed the UpdateImagesWithLatest branch from 72de269 to f3bdf0e Compare February 19, 2020 11:22

akremsa force-pushed the UpdateImagesWithLatest branch from f3bdf0e to 4661a6e Compare February 19, 2020 12:03

pooneh-m removed their request for review February 19, 2020 20:59

google-oss-robot removed the size/L label Feb 22, 2020

akremsa marked this pull request as ready for review February 22, 2020 09:31

google-oss-robot removed the do-not-merge/work-in-progress label Feb 22, 2020

markmandel reviewed Feb 22, 2020

View reviewed changes

build/includes/minikube.mk Outdated Show resolved Hide resolved

akremsa force-pushed the UpdateImagesWithLatest branch from e9a21f7 to 33ad64b Compare February 24, 2020 10:25

akremsa force-pushed the UpdateImagesWithLatest branch from 33ad64b to ea19e32 Compare February 24, 2020 11:26

alexey-kremsa-globant added 7 commits February 25, 2020 19:49

Updated simple udp

635f80e

updated simple-tcp simple-tcp updated allocator-service

updated rust-simple

ddfe1ba

updated autoscaler-webhook

9f5f355

Updated xonotic

0d25349

Updated cpp-simple

7b4962f

Updated crd-client and alpine

5d65b31

Reverted imagePullPolicy back reverted md files back minor fix minor fixes removed redundant name field from metadata

applied review notes

019ee92

akremsa force-pushed the UpdateImagesWithLatest branch from ea19e32 to 019ee92 Compare February 25, 2020 16:52

markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc labels Feb 25, 2020

markmandel approved these changes Feb 25, 2020

View reviewed changes

markmandel merged commit 1776e09 into googleforgames:master Feb 25, 2020

markmandel added this to the 1.4.0 milestone Feb 25, 2020

google-oss-robot added the lgtm label Feb 25, 2020

google-oss-robot added the approved label Feb 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update images with latest everything #1261 #1344

Update images with latest everything #1261 #1344

akremsa commented Feb 18, 2020 •

edited by aLekSer

Loading

googlebot commented Feb 18, 2020

agones-bot commented Feb 18, 2020

agones-bot commented Feb 18, 2020

markmandel left a comment

googlebot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

akremsa commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

aLekSer commented Feb 19, 2020

markmandel commented Feb 20, 2020

aLekSer commented Feb 21, 2020

markmandel commented Feb 22, 2020

markmandel left a comment

akremsa commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 25, 2020

markmandel left a comment

markmandel commented Feb 25, 2020

google-oss-robot commented Feb 25, 2020

google-oss-robot commented Feb 25, 2020

Update images with latest everything #1261 #1344

Update images with latest everything #1261 #1344

Conversation

akremsa commented Feb 18, 2020 • edited by aLekSer Loading

googlebot commented Feb 18, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

agones-bot commented Feb 18, 2020

agones-bot commented Feb 18, 2020

markmandel left a comment

Choose a reason for hiding this comment

googlebot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

akremsa commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

agones-bot commented Feb 19, 2020

aLekSer commented Feb 19, 2020

markmandel commented Feb 20, 2020

aLekSer commented Feb 21, 2020

markmandel commented Feb 22, 2020

markmandel left a comment

Choose a reason for hiding this comment

akremsa commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 24, 2020

agones-bot commented Feb 25, 2020

markmandel left a comment

Choose a reason for hiding this comment

markmandel commented Feb 25, 2020

google-oss-robot commented Feb 25, 2020

google-oss-robot commented Feb 25, 2020

akremsa commented Feb 18, 2020 •

edited by aLekSer

Loading