Fix for flaky e2e: TestUnhealthyGameServersWithoutFreePorts #1480
Conversation
|
Build Succeeded 👏 Build Id: 1eb36415-6be4-419c-a29f-d972a63b644a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
roberthbailey
requested review from
markmandel
and removed request for
roberthbailey and
dzlier-gcp
markmandel
added
area/tests
| assert.Nil(t, err) | ||
| for _, n := range nodes.Items { | ||
| // using only gameserver node pool with no taints | ||
| if len(n.Spec.Taints) == 0 { |
There was a problem hiding this comment.
ooooooooh! That makes sense. 🤦
| assert.True(t, len(nodes.Items) > 0) | ||
|
|
||
| gs := framework.DefaultGameServer(defaultNs) | ||
| gs.Spec.Ports[0].HostPort = 7515 | ||
| // choose port out of the minport/maxport range | ||
| gs.Spec.Ports[0].HostPort = 5555 |
There was a problem hiding this comment.
Added description of the root cause in original ticket. #1376 (comment)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akremsa, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 9839e108-3600-460c-97b1-ee6fa0575847 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Co-authored-by: Mark Mandel <markmandel@google.com>
Closes #1376