Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tolerations for delete hook script #1521

Merged
merged 2 commits into from
May 7, 2020
Merged

Add tolerations for delete hook script #1521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a29023
Add tolerations for delete hook script
aLekSer May 7, 2020
29ea344
Merge branch 'master' into helm/fix-delete-resources
markmandel May 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions install/helm/agones/templates/hooks/pre_delete_hook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ spec:
volumeMounts:
- name: script
mountPath: /scripts/
{{- if .Values.agones.controller.tolerations }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach. It's the easiest implementation. If people need to have their own custom toleration, we could provide an extra configuration for delete_job toleration, and then default to the controller toleration 👍

tolerations:
{{ toYaml .Values.agones.controller.tolerations | indent 8 }}
{{- end }}
volumes:
- name: script
configMap:
Expand Down