Improved Fleets - controller tests #1547

akremsa · 2020-05-14T11:48:54Z

What type of PR is this?

/kind cleanup

What this PR does / Why we need it:
Added more tests to fleets - controller_test.go

Special notes for your reviewer:
BEFORE:

AFTER:

agones-bot · 2020-05-14T11:52:49Z

Build Failed 😱

Build Id: e7ad7ca8-bc06-4257-9313-998a8e50ea45

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-05-14T12:58:28Z

pkg/fleets/controller_test.go

+
+		gsSet := f.GameServerSet()
+		// make gsSet.Spec.Template and f.Spec.Template different in order to make 'rest' list not empty
+		gsSet.Spec.Template.ClusterName = "qqqqqqqqqqqqqqqqqqq"


Suggested change

gsSet.Spec.Template.ClusterName = "qqqqqqqqqqqqqqqqqqq"

gsSet.Spec.Template.ClusterName = strings.Repeat("q", 19)

I see it is not resolved

Can we use a const for this and above?

Yes, it's not resolved because I prefer to keep it as is. Honestly, I don't see any difference between a pure string and strings.Repeat(). In my implementation, it's easier to notice that this is an invalid value.
According to constants - I prefer to avoid them in tests and this is just a random "invalid" sequence of characters. This is not that type of stuff which is worth much attention, in my opinion.

Yes, it might be not crucial here. Just it looks nicer.

agones-bot · 2020-05-15T12:51:58Z

Build Succeeded 👏

Build Id: b9050cbd-26ea-414c-b592-889f54778958

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-eabeb25
image: gcr.io/agones-images/agones-sdk:1.6.0-eabeb25
image: gcr.io/agones-images/agones-ping:1.6.0-eabeb25
Linux C++ SDK (build): agonessdk-1.6.0-eabeb25-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-eabeb25.zip

A preview of the website (the last 30 builds are retained):

https://eabeb25-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1547/head:pr_1547 && git checkout pr_1547
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-eabeb25

agones-bot · 2020-05-18T10:09:27Z

Build Failed 😱

Build Id: 306ea29a-8241-4e24-9ea9-5c743b47f36d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-05-19T12:41:24Z

Build Succeeded 👏

Build Id: 9bf1055f-6eb1-47f0-924f-2d9160fcc95e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-23d72ef
image: gcr.io/agones-images/agones-sdk:1.6.0-23d72ef
image: gcr.io/agones-images/agones-ping:1.6.0-23d72ef
Linux C++ SDK (build): agonessdk-1.6.0-23d72ef-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-23d72ef.zip

A preview of the website (the last 30 builds are retained):

https://23d72ef-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1547/head:pr_1547 && git checkout pr_1547
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-23d72ef

agones-bot · 2020-05-22T12:54:58Z

Build Succeeded 👏

Build Id: bf964757-57b7-4be0-a3e5-05c5dc1ce0c8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-3a52b1d
image: gcr.io/agones-images/agones-sdk:1.6.0-3a52b1d
image: gcr.io/agones-images/agones-ping:1.6.0-3a52b1d
Linux C++ SDK (build): agonessdk-1.6.0-3a52b1d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-3a52b1d.zip

A preview of the website (the last 30 builds are retained):

https://3a52b1d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1547/head:pr_1547 && git checkout pr_1547
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-3a52b1d

agones-bot · 2020-06-01T11:48:08Z

Build Failed 😱

Build Id: 637711b3-52fe-4c26-a2dc-9cb9cdb90b80

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-06-01T21:02:36Z

pkg/fleets/controller.go

@@ -408,10 +408,10 @@ func (c *Controller) recreateDeployment(fleet *agonesv1.Fleet, rest []*agonesv1.
 func (c *Controller) rollingUpdateDeployment(fleet *agonesv1.Fleet, active *agonesv1.GameServerSet, rest []*agonesv1.GameServerSet) (int32, error) {
 	replicas, err := c.rollingUpdateActive(fleet, active, rest)
 	if err != nil {
-		return replicas, err
+		return 0, err


Curious, what's the impetus for this change?

left a comment here
#1531 (comment)

pkg/fleets/controller_test.go

agones-bot · 2020-06-02T21:23:08Z

Build Succeeded 👏

Build Id: fd0864a8-ed18-4b8a-b503-3a57cbe9b143

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-0932d24
image: gcr.io/agones-images/agones-sdk:1.7.0-0932d24
image: gcr.io/agones-images/agones-ping:1.7.0-0932d24
Linux C++ SDK (build): agonessdk-1.7.0-0932d24-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-0932d24.zip

A preview of the website (the last 30 builds are retained):

https://0932d24-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1547/head:pr_1547 && git checkout pr_1547
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-0932d24

pkg/fleets/controller_test.go

aLekSer

Left some comments. Overall looks good.

TestControllerCreationMutationHandler, TestControllerCreationValidationHandler, TestControllerUpsertGameServerSet more tests more tests review notes

agones-bot · 2020-06-08T11:24:39Z

Build Failed 😱

Build Id: 4bfd14dc-5e58-4dcc-bb43-d4b7fd76b0b5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-06-08T13:04:01Z

Build Succeeded 👏

Build Id: 53686a4f-4717-4abf-8724-d986b53f7ac4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-60b12dc
image: gcr.io/agones-images/agones-sdk:1.7.0-60b12dc
image: gcr.io/agones-images/agones-ping:1.7.0-60b12dc
Linux C++ SDK (build): agonessdk-1.7.0-60b12dc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-60b12dc.zip

A preview of the website (the last 30 builds are retained):

https://60b12dc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1547/head:pr_1547 && git checkout pr_1547
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-60b12dc

akremsa · 2020-06-08T13:06:14Z

@aLekSer @markmandel
I've updated PR, please check again.

aLekSer

Thanks for updates

google-oss-robot · 2020-06-08T21:06:32Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akremsa, aLekSer
To complete the pull request process, please assign pooneh-m
You can assign the PR to them by writing /assign @pooneh-m in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-06-08T21:06:41Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-06-08T21:27:45Z

Build Succeeded 👏

Build Id: e65426df-fa6e-4391-8dae-34789df566fa

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-b19e4d4
image: gcr.io/agones-images/agones-sdk:1.7.0-b19e4d4
image: gcr.io/agones-images/agones-ping:1.7.0-b19e4d4
Linux C++ SDK (build): agonessdk-1.7.0-b19e4d4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-b19e4d4.zip

A preview of the website (the last 30 builds are retained):

https://b19e4d4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1547/head:pr_1547 && git checkout pr_1547
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-b19e4d4

aLekSer · 2020-06-08T21:28:00Z

@markmandel I think this PR is ready, can you please look one more time?

agones-bot · 2020-06-08T21:53:44Z

Build Succeeded 👏

Build Id: 638ab1bf-ab55-4293-82db-1b5fd67003bb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-769c8ae
image: gcr.io/agones-images/agones-sdk:1.7.0-769c8ae
image: gcr.io/agones-images/agones-ping:1.7.0-769c8ae
Linux C++ SDK (build): agonessdk-1.7.0-769c8ae-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-769c8ae.zip

A preview of the website (the last 30 builds are retained):

https://769c8ae-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1547/head:pr_1547 && git checkout pr_1547
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-769c8ae

* added syncFleet tests Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>

google-oss-robot requested review from cyriltovena and pooneh-m May 14, 2020 11:48

google-oss-robot added the size/XL label May 14, 2020

aLekSer reviewed May 14, 2020

View reviewed changes

akremsa force-pushed the fleet-controller-tests branch from bf1e487 to eabeb25 Compare May 15, 2020 12:33

akremsa force-pushed the fleet-controller-tests branch from eabeb25 to 7ee5c1f Compare May 18, 2020 09:52

akremsa force-pushed the fleet-controller-tests branch from 7ee5c1f to 23d72ef Compare May 19, 2020 12:17

akremsa force-pushed the fleet-controller-tests branch from 23d72ef to 3a52b1d Compare May 22, 2020 12:28

akremsa force-pushed the fleet-controller-tests branch 2 times, most recently from 5156ef4 to a100d3f Compare June 1, 2020 11:37

markmandel reviewed Jun 1, 2020

View reviewed changes

akremsa force-pushed the fleet-controller-tests branch from a100d3f to 0932d24 Compare June 2, 2020 21:01

akremsa force-pushed the fleet-controller-tests branch from 0932d24 to 5fe60db Compare June 4, 2020 23:26