Flaky: TestFleetAggregatedPlayerStatus #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmandel
added
kind/bug
Added retry logic to UDP packet send and receive. Had to adjust the test condition a little, but I think that's not a concern here, as we mainly want to fail if the SDK isn't working, whereas we now many get extra times that it is. Closes googleforgames#1592
markmandel
force-pushed
the
flaky/TestFleetAggregatedPlayerStatus
branch
from
0163c7d
to
41ed232
Compare
|
Build Failed 😱 Build Id: ec35baf6-7a04-4e6a-9c41-1dfc776cb028 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: a20ca21d-e0a5-41d4-b5da-5cb3338a94ad The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
Added retry logic to UDP packet send and receive. Had to adjust the test condition a little, but I think that's not a concern here, as we mainly want to fail if the SDK isn't working, whereas we now many get extra times that it is. Closes googleforgames#1592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Added retry logic to UDP packet send and receive.
Which issue(s) this PR fixes:
Closes #1592
Special notes for your reviewer:
Had to adjust the test condition a little, but I think that's not a
concern here, as we mainly want to fail if the SDK isn't working,
whereas we now many get extra times that it is.