Release 1.7.0-rc

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind release

What this PR does / Why we need it:

Release of 1.7.0 Release candidate

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:
None.

[agones-bot]

Build Failed 😱

Build Id: 366c0948-c881-4f18-841f-c40e635db565

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

10min timeout on Unit tests.

Dug through and found the following tests in the stacktrace. Just looking for patterns long term, or maybe we need a long timeout on unit tests?

A successful pass is: 00:03:16, so a longer timeout isn't required.

agones.dev/agones/pkg/gameservers.TestControllerSyncGameServer(0xc00014c480)
	/go/src/agones.dev/agones/pkg/gameservers/controller_test.go:58 +0x6c

agones.dev/agones/pkg/gameservers.TestControllerSyncGameServer.func1.2(0x2020380, 0xc000a0d000, 0x4, 0x6, 0x1d4643d, 0xc000d14160, 0x0)
	/go/src/agones.dev/agones/pkg/gameservers/controller_test.go:89 +0x2af

agones.dev/agones/pkg/gameservers.TestControllerSyncGameServer.func1(0xc0008527e0)
	/go/src/agones.dev/agones/pkg/gameservers/controller_test.go:127 +0x12fd

[agones-bot]

Build Failed 😱

Build Id: c13e9ecb-52d2-4f6a-a4cb-440068600033

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

Instead of changing this to 1.8.0 after the 1.7 release, would it be better to use 1.8.0-dev (or something)? Then the RC CL would change dev -> rc and the release would drop the extension. WDYT?

[markmandel]

I'd be happy with that. Just need to tweak the release checklist to include the process.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agones-bot]

Build Failed 😱

Build Id: 20ab8922-8244-4aaa-bf24-9a5060b071a5

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Same unit test freeze. Different spot???

(looking at what tests are running at timeout, based on stack trace)

agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerCapacity
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerWatchGameServer

[agones-bot]

Build Failed 😱

Build Id: 870dea81-e286-40c2-b18b-ec8975572245

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Different flake

--- FAIL: TestSDKServerWatchGameServerFeatureSDKWatchSendOnExecute (9.12s)
    sdkserver_test.go:722: No gameserver in the stream, moving on.
    sdkserver_test.go:728: 
        	Error Trace:	sdkserver_test.go:728
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 1

But also looks like a legitimate bug in the site link check.

Nope, that was a rate limit that retry fixed. Nevermind.

[agones-bot]

Build Succeeded 👏

Build Id: 5df714e6-55cf-4980-b085-b2b0c06f4daa

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.7.0-6951992
• image: gcr.io/agones-images/agones-sdk:1.7.0-6951992
• image: gcr.io/agones-images/agones-ping:1.7.0-6951992
• Linux C++ SDK (build): agonessdk-1.7.0-6951992-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.7.0-6951992.zip

A preview of the website (the last 30 builds are retained):

• https://6951992-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1662/head:pr_1662 && git checkout pr_1662
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-6951992