$(ALPHA_FEATURE_GATES) on gcloud-terraform-install #1663

markmandel · 2020-06-30T19:59:48Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Minor cleanup to use the feature gate variable in the Terraform make commands.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:
None

Minor cleanup to use the feature gate variable in the Terraform make commands.

agones-bot · 2020-06-30T20:16:35Z

Build Failed 😱

Build Id: f5c1419c-aea3-42fa-ab08-487aa294ec5d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-06-30T20:23:48Z

Flaky conformance test failure:

{"message":"Could not find a request which was expected","request":"ready","sdkName":"go","severity":"error","source":"*sdkserver.LocalSDKServer","time":"2020-06-30T20:11:05.994958286Z"}
{"expected":["ready","allocate","setlabel","setannotation","gameserver","health","shutdown","watch","reserve"],"message":"Testing Failed","received":[],"sdkName":"go","severity":"info","source":"*sdkserver.LocalSDKServer","time":"2020-06-30T20:11:05.995053002Z"}

aLekSer

Useful change.

markmandel · 2020-06-30T20:38:18Z

Ooh, that's a new one!

time="2020-06-30 20:23:51.038" level=info msg="Starting e2e test(s)" featureGates="ContainerPortAllocation=false&Example=true&PlayerTracking=true&SDKWatchSendOnExecute=true" gameServerImage="gcr.io/agones-images/udp-server:0.21" namespace= perfOutputDir= pullSecret= stressTestLevel=0 version=
time="2020-06-30 20:23:51.146" level=error msg="failed to cleanup e2e namespaces" error="deleting namespace 1593548327 failed: Operation cannot be fulfilled on namespaces \"1593548327\": The system is ensuring all content is removed from this namespace.  Upon completion, this namespace will automatically be purged by the system."
FAIL	agones.dev/agones/test/e2e	0.176s
FAIL
Makefile:254: recipe for target 'test-e2e-integration' failed

roberthbailey · 2020-06-30T20:55:23Z

Do we do a one-shot call to delete the namespace? Or do we call delete and then wait (up to some timeout) for it to disappear?

markmandel · 2020-06-30T21:04:16Z

Do we do a one-shot call to delete the namespace? Or do we call delete and then wait (up to some timeout) for it to disappear?

I reuse this function: https://github.com/googleforgames/agones/blob/master/test/e2e/framework/framework.go#L566

It will default to background delete though. I expect there is an error type if you try and delete a namespace that is in the process of being deleted, and we can ignore that.

google-oss-robot · 2020-06-30T23:51:34Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-07-01T00:17:26Z

Build Failed 😱

Build Id: ba8d9358-e7fd-4191-89ab-bf040b8e3b01

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-07-01T01:04:54Z

Ah!

time="2020-07-01 00:17:11.915" level=error msg="failed to cleanup e2e namespaces" error="deleting namespace 1593562346 failed: Operation cannot be fulfilled on namespaces \"1593562346\": The system is ensuring all content is removed from this namespace. Upon completion, this namespace will automatically be purged by the system." FAIL agones.dev/agones/test/e2e 0.603s FAIL

Fix for that soon!

agones-bot · 2020-07-01T01:29:20Z

Build Failed 😱

Build Id: dd655dbb-58c7-48d5-8ece-0bfc8c86f2ef

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-07-01T02:39:55Z

Same thing - exits after 10 minutes, some kind of deadlock:

grep Test

agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerCapacity
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerCapacity.func1(0xc0008480d0, 0xc00069a0c8, 0xc000540a20)
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2.1(0xc00044f6c0, 0xc000532020, 0xc000287680)
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2.1(0xc00054a8f0, 0xc0005321e0, 0xc0000d4360)
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2.1(0xc000348820, 0xc000532188, 0xc000489560)
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2.1(0xc000a1cf70, 0xc000010118, 0xc000a1e360)
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2.1(0xc000abf860, 0xc000532328, 0xc000ac2360)
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerPlayerConnectAndDisconnect.func2.1(0xc000ac6680, 0xc000532338, 0xc000ac2ea0)
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerWatchGameServer
agones.dev/agones/pkg/sdkserver.TestLocalSDKServerWatchGameServer.func1(0xc000480b60, 0xc0001188a0, 0xc000644000, 0xc000540900)
agones.dev/agones/pkg/sdkserver.TestSDKServerWatchGameServer(0xc000276120)

grep _test

	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:264 +0x2c6
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:265 +0x5d
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:308 +0x334
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:309 +0x92
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:418 +0x241
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:418 +0x241
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:418 +0x241
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:418 +0x241
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:418 +0x241
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:418 +0x241
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:419 +0x92
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:419 +0x92
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:419 +0x92
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:419 +0x92
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:419 +0x92
	/go/src/agones.dev/agones/pkg/sdkserver/localsdk_test.go:419 +0x92
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:658 +0x278
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1251 +0x86
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1252 +0x78
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1259 +0x6b
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1259 +0x6b
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1259 +0x6b
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1260 +0x93
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1260 +0x93
	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1260 +0x93

#1662 (comment) has a similar stack

agones-bot · 2020-07-01T02:55:08Z

Build Failed 😱

Build Id: b511ae1c-04cd-4275-8cfa-50e6ad94a5b2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-07-01T11:40:40Z

@akremsa , this was recently added, PTAL:

--- FAIL: TestSDKServerWatchGameServerFeatureSDKWatchSendOnExecute (9.33s)
    sdkserver_test.go:722: No gameserver in the stream, moving on.
    sdkserver_test.go:728: 
        	Error Trace:	sdkserver_test.go:728
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 1
        	Test:       	TestSDKServerWatchGameServerFeatureSDKWatchSendOnExecute

This could be fixed by PR #1667

agones-bot · 2020-07-01T17:10:35Z

Build Failed 😱

Build Id: 006900eb-2510-4c15-8dd8-0b573cf58618

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-robot · 2020-07-02T00:55:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-07-02T01:18:18Z

Build Succeeded 👏

Build Id: 42044953-08a9-42fc-a0eb-000f28d2f4be

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.7.0-f110006
image: gcr.io/agones-images/agones-sdk:1.7.0-f110006
image: gcr.io/agones-images/agones-ping:1.7.0-f110006
Linux C++ SDK (build): agonessdk-1.7.0-f110006-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.7.0-f110006.zip

A preview of the website (the last 30 builds are retained):

https://f110006-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1663/head:pr_1663 && git checkout pr_1663
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-f110006

Minor cleanup to use the feature gate variable in the Terraform make commands.

$(ALPHA_FEATURE_GATES) on gcloud-terraform-install

600e411

Minor cleanup to use the feature gate variable in the Terraform make commands.

markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 30, 2020

markmandel requested a review from aLekSer June 30, 2020 19:59

google-oss-robot requested review from cyriltovena and roberthbailey June 30, 2020 19:59

googlebot added the cla: yes label Jun 30, 2020

google-oss-robot added approved size/XS labels Jun 30, 2020

aLekSer approved these changes Jun 30, 2020

View reviewed changes

google-oss-robot assigned aLekSer Jun 30, 2020

google-oss-robot added the lgtm label Jun 30, 2020

roberthbailey approved these changes Jun 30, 2020

View reviewed changes

google-oss-robot assigned roberthbailey Jun 30, 2020

Merge branch 'master' into cleanup/terraform-target

0ef5e49

google-oss-robot removed the lgtm label Jun 30, 2020

markmandel mentioned this pull request Jul 1, 2020

Go unit test timeout after 10m #1672

Closed

Merge branch 'master' into cleanup/terraform-target

f110006

markmandel merged commit f627311 into googleforgames:master Jul 2, 2020

markmandel added this to the 1.7.0 milestone Jul 2, 2020

markmandel deleted the cleanup/terraform-target branch July 6, 2020 18:13

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

$(ALPHA_FEATURE_GATES) on gcloud-terraform-install (googleforgames#1663)

57e80e7

Minor cleanup to use the feature gate variable in the Terraform make commands.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

$(ALPHA_FEATURE_GATES) on gcloud-terraform-install #1663

$(ALPHA_FEATURE_GATES) on gcloud-terraform-install #1663

markmandel commented Jun 30, 2020

agones-bot commented Jun 30, 2020

markmandel commented Jun 30, 2020

aLekSer left a comment

markmandel commented Jun 30, 2020

roberthbailey commented Jun 30, 2020

markmandel commented Jun 30, 2020

google-oss-robot commented Jun 30, 2020

agones-bot commented Jul 1, 2020

markmandel commented Jul 1, 2020

agones-bot commented Jul 1, 2020

markmandel commented Jul 1, 2020

agones-bot commented Jul 1, 2020

aLekSer commented Jul 1, 2020 •

edited

Loading

agones-bot commented Jul 1, 2020

google-oss-robot commented Jul 2, 2020

agones-bot commented Jul 2, 2020

$(ALPHA_FEATURE_GATES) on gcloud-terraform-install #1663

$(ALPHA_FEATURE_GATES) on gcloud-terraform-install #1663

Conversation

markmandel commented Jun 30, 2020

agones-bot commented Jun 30, 2020

markmandel commented Jun 30, 2020

aLekSer left a comment

Choose a reason for hiding this comment

markmandel commented Jun 30, 2020

roberthbailey commented Jun 30, 2020

markmandel commented Jun 30, 2020

google-oss-robot commented Jun 30, 2020

agones-bot commented Jul 1, 2020

markmandel commented Jul 1, 2020

agones-bot commented Jul 1, 2020

markmandel commented Jul 1, 2020

agones-bot commented Jul 1, 2020

aLekSer commented Jul 1, 2020 • edited Loading

agones-bot commented Jul 1, 2020

google-oss-robot commented Jul 2, 2020

agones-bot commented Jul 2, 2020

aLekSer commented Jul 1, 2020 •

edited

Loading