Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Twitter linkcheck failure. #1947

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Twitter seems to be doing UserAgent sniffing, and rejecting non-browser user agents, breaking CI.

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

This change makes htmltest use a Chrome Linux user agent to work around this issue. To support editing the HTTP headers required an update to htmltest.

Twitter seems to be doing UserAgent sniffing, and rejecting non-browser
user agents, breaking CI.

This change makes htmltest use a Chrome Linux user agent to work around
this issue. To support editing the HTTP headers required an update to
htmltest.
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jan 12, 2021
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c8920c38-76b3-48d2-b99b-e96cb0d476e6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1947/head:pr_1947 && git checkout pr_1947
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.12.0-23494dc

@markmandel markmandel merged commit 370852a into googleforgames:master Jan 12, 2021
@markmandel markmandel deleted the ci/htmltest-twitter branch January 12, 2021 23:28
@markmandel markmandel added this to the 1.12.0 milestone Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/bug These are bugs. lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants