Build Agones Windows images by default. #2037

jeremyje · 2021-03-31T06:53:27Z

What type of PR is this?
/kind feature

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Builds Windows container images by default so that they are easier to use out of the box.
This is done by turning on the WITH_WINDOWS=1 flag in the Makefile.

Which issue(s) this PR fixes:
Issue #54 is mostly complete.

Special notes for your reviewer:
This will add some latency to the Agones build.

agones-bot · 2021-03-31T07:17:20Z

Build Failed 😱

Build Id: a8702a6e-8b30-40c2-a23a-eb9897ff48fe

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2021-03-31T07:28:08Z

Build Succeeded 👏

Build Id: 87d51b8f-b951-4d7a-9a2d-5e03cd2ddb30

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-55c39b3
image: gcr.io/agones-images/agones-sdk:1.14.0-55c39b3
image: gcr.io/agones-images/agones-sdk:1.14.0-55c39b3-linux_amd64
image: gcr.io/agones-images/agones-ping:1.14.0-55c39b3
Linux C++ SDK (build): agonessdk-1.14.0-55c39b3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-55c39b3.zip

A preview of the website (the last 30 builds are retained):

https://55c39b3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2037/head:pr_2037 && git checkout pr_2037
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-55c39b3

agones-bot · 2021-03-31T08:28:46Z

Build Succeeded 👏

Build Id: 5360a3c3-d4ed-4d32-9ea0-9ad1cc67d525

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-8398688
image: gcr.io/agones-images/agones-ping:1.14.0-8398688
Linux C++ SDK (build): agonessdk-1.14.0-8398688-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-8398688.zip

A preview of the website (the last 30 builds are retained):

https://8398688-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2037/head:pr_2037 && git checkout pr_2037
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-8398688

markmandel · 2021-03-31T16:04:28Z

Interesting - I thought this was going to add a lot of time to the build process, but it completed in 00:23:06 - which is about average for our usual build time - so that's pretty great!

markmandel · 2021-03-31T16:06:29Z

build/Makefile

@@ -49,7 +49,7 @@ MINIKUBE_PROFILE ?= agones
 GO_BUILD_TAGS ?= none
 BUILDX_WINDOWS_BUILDER = windows-builder
 WINDOWS_DOCKER_PUSH_ARGS =
-WINDOWS_VERSIONS = ltsc2019 # 1909 (For GKE WINDOWS_SAC support)
+WINDOWS_VERSIONS = ltsc2019 # 20H2 (For GKE WINDOWS_SAC support)


Wondering if we can add a comment/link here, about what these terms mean?

I'm not sure what the change to 20H2 means?

1909 is going end of life soon. GKE now supports 20H2.

I don't know what those words mean 🙂 can we add a comment to point to the relevant docs somewhere?

Is the comment of 20H2 mean that we need to change something eventually? I'd just like this comment to be explicitly clear.

Is this the right link for details on what these terms mean?
https://cloud.google.com/kubernetes-engine/docs/concepts/node-images#windows-server

If so, can we add a comment above for reference this line for reference?

Added some docs about versioning. Once Agones CI moves to Docker 20.10 this will be somewhat irrelevant as it'll be much easier to multi-arch against all versions of Windows.

Perfect! Thanks so much!

build/Makefile

cloudbuild.yaml

agones-bot · 2021-03-31T19:43:49Z

Build Succeeded 👏

Build Id: f55cfa0c-2bfe-4db5-b521-aca41830cac5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-f296878
image: gcr.io/agones-images/agones-sdk:1.14.0-f296878
image: gcr.io/agones-images/agones-sdk:1.14.0-f296878-linux_amd64
image: gcr.io/agones-images/agones-ping:1.14.0-f296878
Linux C++ SDK (build): agonessdk-1.14.0-f296878-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-f296878.zip

A preview of the website (the last 30 builds are retained):

https://f296878-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2037/head:pr_2037 && git checkout pr_2037
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-f296878

agones-bot · 2021-03-31T19:49:53Z

Build Succeeded 👏

Build Id: a4223eb5-d2f5-4935-b411-0372ae404951

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-a1d838f
image: gcr.io/agones-images/agones-sdk:1.14.0-a1d838f
image: gcr.io/agones-images/agones-sdk:1.14.0-a1d838f-linux_amd64
image: gcr.io/agones-images/agones-ping:1.14.0-a1d838f
Linux C++ SDK (build): agonessdk-1.14.0-a1d838f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-a1d838f.zip

A preview of the website (the last 30 builds are retained):

https://a1d838f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2037/head:pr_2037 && git checkout pr_2037
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-a1d838f

agones-bot · 2021-03-31T20:49:50Z

Build Succeeded 👏

Build Id: da19788e-9fd9-4091-8bac-e837d42ef16c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-ae82551
image: gcr.io/agones-images/agones-ping:1.14.0-ae82551
Linux C++ SDK (build): agonessdk-1.14.0-ae82551-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-ae82551.zip

A preview of the website (the last 30 builds are retained):

https://ae82551-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2037/head:pr_2037 && git checkout pr_2037
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-ae82551

markmandel · 2021-03-31T21:18:26Z

Outside that adding one comment around what the terms mean for Windows container versions, this LGTM.

@roberthbailey WDYT?

agones-bot · 2021-03-31T22:11:49Z

Build Succeeded 👏

Build Id: ab660f78-a823-4ce9-aac8-16eeedcbcec9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-67b8f80
image: gcr.io/agones-images/agones-ping:1.14.0-67b8f80
Linux C++ SDK (build): agonessdk-1.14.0-67b8f80-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-67b8f80.zip

A preview of the website (the last 30 builds are retained):

https://67b8f80-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2037/head:pr_2037 && git checkout pr_2037
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-67b8f80

roberthbailey

I can't seem to add to the conversation above, but when you say

1909 is going end of life soon. GKE now supports 20H2.

and I look at https://cloud.google.com/kubernetes-engine/docs/how-to/creating-a-cluster-windows#version_mapping it appears that for k8s 1.18 (which is the version we currently support) you should still be using 1909 Core. And when we upgrade to k8s 1.19 is when we would switch to 20H2 Core.

I'm not sure how ltsc2019 maps to either of those, and the note was just in the comment before, but I can't tell which version we are building for in our CI and will build for our upcoming release (when we will build these images for the first time). We should make sure we are building targeting 1909 (even though it's almost EOL) so that it matches our supported k8s version on GKE.

examples/simple-game-server/Makefile

agones-bot · 2021-04-02T08:41:17Z

Build Succeeded 👏

Build Id: 3508ae04-97cc-49de-8ee1-9cfeca4a5089

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.14.0-feae0d1
image: gcr.io/agones-images/agones-ping:1.14.0-feae0d1
Linux C++ SDK (build): agonessdk-1.14.0-feae0d1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.14.0-feae0d1.zip

A preview of the website (the last 30 builds are retained):

https://feae0d1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2037/head:pr_2037 && git checkout pr_2037
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.14.0-feae0d1

google-oss-robot · 2021-04-02T17:39:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-cla bot added the cla: yes label Mar 31, 2021

google-oss-robot requested review from dzlier-gcp and markmandel March 31, 2021 06:53

google-oss-robot added the size/XS label Mar 31, 2021

google-oss-robot added size/S and removed size/XS labels Mar 31, 2021

markmandel reviewed Mar 31, 2021

View reviewed changes

google-oss-robot added size/M size/S and removed size/S size/M labels Mar 31, 2021

google-oss-robot added size/M and removed size/S labels Mar 31, 2021

markmandel requested a review from roberthbailey March 31, 2021 21:14

roberthbailey reviewed Apr 1, 2021

View reviewed changes

examples/simple-game-server/Makefile Show resolved Hide resolved

Build Agones Windows images by default.

feae0d1

roberthbailey approved these changes Apr 2, 2021

View reviewed changes

google-oss-robot assigned roberthbailey Apr 2, 2021

google-oss-robot added the lgtm label Apr 2, 2021

google-oss-robot added the approved label Apr 2, 2021

roberthbailey merged commit ad01efb into googleforgames:main Apr 2, 2021

jeremyje deleted the buildwin branch April 2, 2021 19:55

roberthbailey mentioned this pull request Apr 2, 2021

Update simple-game-server to 0.3 #2045

Closed

markmandel added this to the 1.14.0 milestone Apr 15, 2021

roberthbailey added the kind/feature New features for Agones label Apr 20, 2021

aLekSer mentioned this pull request Jun 30, 2021

Fix sidecar tag in different make targets #2163

Merged

roberthbailey mentioned this pull request Sep 30, 2021

CI builds should publish a multi-arch manifest for the agones-sdk image #2280

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build Agones Windows images by default. #2037

Build Agones Windows images by default. #2037

jeremyje commented Mar 31, 2021

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

markmandel commented Mar 31, 2021

markmandel Mar 31, 2021

jeremyje Mar 31, 2021

markmandel Mar 31, 2021

markmandel Mar 31, 2021

jeremyje Mar 31, 2021 •

edited

Loading

markmandel Mar 31, 2021

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

markmandel commented Mar 31, 2021

agones-bot commented Mar 31, 2021

roberthbailey left a comment

agones-bot commented Apr 2, 2021

google-oss-robot commented Apr 2, 2021

Build Agones Windows images by default. #2037

Build Agones Windows images by default. #2037

Conversation

jeremyje commented Mar 31, 2021

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

markmandel commented Mar 31, 2021

markmandel Mar 31, 2021

Choose a reason for hiding this comment

jeremyje Mar 31, 2021

Choose a reason for hiding this comment

markmandel Mar 31, 2021

Choose a reason for hiding this comment

markmandel Mar 31, 2021

Choose a reason for hiding this comment

jeremyje Mar 31, 2021 • edited Loading

Choose a reason for hiding this comment

markmandel Mar 31, 2021

Choose a reason for hiding this comment

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

agones-bot commented Mar 31, 2021

markmandel commented Mar 31, 2021

agones-bot commented Mar 31, 2021

roberthbailey left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 2, 2021

google-oss-robot commented Apr 2, 2021

jeremyje Mar 31, 2021 •

edited

Loading