Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of getRandomlySelectedGS #2144

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

When refactoring the allocator code for #2143 I noticed that this function was never actually utilised for anything, so figured it made
sense to remove it.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

When refactoring the allocator code for googleforgames#2143 I noticed that this
function was never actually utilised for anything, so figured it made
sense to remove it.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jun 21, 2021
@google-cla google-cla bot added the cla: yes label Jun 21, 2021
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ef50f885-3b85-45d5-8c11-7844fff74ecf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2144/head:pr_2144 && git checkout pr_2144
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-bfed18c

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 8546661 into googleforgames:main Jun 21, 2021
@markmandel markmandel deleted the cleanup/getRandomlySelectedGS branch June 21, 2021 19:08
@roberthbailey roberthbailey added this to the 1.16.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants