-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to tonic 0.5 and prost 0.8 #2176
Update to tonic 0.5 and prost 0.8 #2176
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Regarding the CLA. This is submitted on behalf of Embark Studios, same as #2112. I have asked internally about our process for getting it signed. Should be sorted soon 🤞 |
Build Succeeded 👏 Build Id: 1fcf5cd8-29d1-45b5-ad10-42c990588739 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
/assign @markmandel This looks fine to me, but since you've been reviewing the rust code I think you should take a look. |
@davidpdrsn - our next release candidate is on Tuesday, so if you were hoping to get this in for the next release then we need to get the CLA sorted out before then. |
The rust crate isn't published to crates.io so thats not an issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy approval!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidpdrsn, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@davidpdrsn looks like you used your github account and/or your gmail account to do this - you'll need to do the commit with your Embark email to come under that CLA. You can rebase this PR with that author instead, and the CLA bot should let you through. |
Just a gentle bump to get this CLA sorted. 😄 |
I'm on vacation currently. Will look into it first week of august when I'm back. |
Duplicate of #2190, so closing. |
/kind cleanup
What this PR does / Why we need it:
Updates tonic and prost to most recent versions.