Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to tonic 0.5 and prost 0.8 #2176

Closed

Conversation

davidpdrsn
Copy link

/kind cleanup

What this PR does / Why we need it:
Updates tonic and prost to most recent versions.

@google-cla
Copy link

google-cla bot commented Jul 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@davidpdrsn
Copy link
Author

Regarding the CLA. This is submitted on behalf of Embark Studios, same as #2112. I have asked internally about our process for getting it signed. Should be sorted soon 🤞

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1fcf5cd8-29d1-45b5-ad10-42c990588739

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2176/head:pr_2176 && git checkout pr_2176
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-24bd646

@roberthbailey
Copy link
Member

/assign @markmandel

This looks fine to me, but since you've been reviewing the rust code I think you should take a look.

@roberthbailey
Copy link
Member

@davidpdrsn - our next release candidate is on Tuesday, so if you were hoping to get this in for the next release then we need to get the CLA sorted out before then.

@davidpdrsn
Copy link
Author

davidpdrsn commented Jul 9, 2021

our next release candidate is on Tuesday, so if you were hoping to get this in for the next release then we need to get the CLA sorted out before then.

The rust crate isn't published to crates.io so thats not an issue.

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy approval!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidpdrsn, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Member

@davidpdrsn looks like you used your github account and/or your gmail account to do this - you'll need to do the commit with your Embark email to come under that CLA.

You can rebase this PR with that author instead, and the CLA bot should let you through.

@roberthbailey roberthbailey added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jul 13, 2021
@roberthbailey roberthbailey removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jul 20, 2021
@markmandel
Copy link
Member

Just a gentle bump to get this CLA sorted. 😄

@davidpdrsn
Copy link
Author

I'm on vacation currently. Will look into it first week of august when I'm back.

@markmandel markmandel added the duplicate Duplicate ticket label Jul 22, 2021
@markmandel
Copy link
Member

Duplicate of #2190, so closing.

@markmandel markmandel closed this Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants