-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minikube: more options for connectivity #2312
Merged
roberthbailey
merged 3 commits into
googleforgames:main
from
markmandel:docs/minikube-connect
Oct 21, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I gathered when testing the workarounds locally,
minikube tunnel
is actually a self-sufficient workaround itself and can be used without creating a separate service.minikube tunnel
tunnels the traffic itself, thus makinggameserver
pods accessible from the host. On the setups where the address returned byminikube ip
isn't accessible from the host, the service workaround will be useless, as the service is still behind theminikube ip
address.So if the purpose of the "Create a service" workaround is to tunnel the traffic to the host, I'm afraid it doesn't work at all (it'll be accessible if using
minikube tunnel
, but that defeats the purpose of the service then). Please correct me if I misinterpreted what the service workaround is supposed to do or if it did work in some cases. So my suggestion is to remove "Create a service" section completely and just mentionminikube tunnel -p agones
command as the workaround.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy pasting from https://minikube.sigs.k8s.io/docs/handbook/accessing/
From: https://minikube.sigs.k8s.io/docs/commands/tunnel/
So as far as I read it,
minikube tunnel
can only be used with aService
. As far as I can tell it doesn't do anything else, so I don't think we should remove theService
workaround section, since it's part of the possible workaround solution.I don't see anything in the documentation that states that
minikube tunnel
connects the node to the host machine for generalised traffic (maybe it does do that though on some platforms??? 🤔 )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I think you're right. I believe I tested it on a service that happened to be also a load balancer (and didn't notice that), so this is why I got such an impression.
I've got no other comments or suggestions then. Thanks a lot for updating the documentation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through so much of this with me!