Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e flow for High Density GameServers #2516

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This PR includes two things, such that I believe we can close the below
issue:

  1. An e2e test to confirm that the described flow in https://agones.dev/site/docs/integration-patterns/high-density-gameservers/
    works as expected (it does 😄).
  2. Add a section in the integration documentation to highlight the consistency models (i.e. things are not atomic operations, but
    eventually consistent), and that people need to keep this in mind.

Which issue(s) this PR fixes:

Closes #2408

Special notes for your reviewer:

N/A

This PR includes two things, such that I believe we can close the below
issue:

1. An e2e test to confirm that the described flow in
https://agones.dev/site/docs/integration-patterns/high-density-gameservers/
works as expected (it does 😄).
2. Add a section in the integration documentation to highlight the
consistency models (i.e. things are not atomic operations, but
eventually consistent), and that people need to keep this in mind.

Closes googleforgames#2408
@markmandel markmandel added kind/documentation Documentation for Agones area/tests Unit tests, e2e tests, anything to make sure things don't break labels Mar 16, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4dc28176-24a9-4bd4-94bc-ea2859dba383

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2516/head:pr_2516 && git checkout pr_2516
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-9eea218

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: aff054d9-fd2b-426d-88c4-9080a72545ec

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2516/head:pr_2516 && git checkout pr_2516
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-cadfba4

@google-oss-prow google-oss-prow bot added the lgtm label Mar 17, 2022
@roberthbailey roberthbailey merged commit ed17358 into googleforgames:main Mar 17, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel deleted the e2e/high-density-flow branch March 17, 2022 22:51
@SaitejaTamma SaitejaTamma added this to the 1.22.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/documentation Documentation for Agones lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GameServerAllocation is not working for "High Density GameServers"
4 participants