Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ: Why not use Deployment or StatefulSet? #2824

Merged

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

The question of "Can't we use a Deployment or a StatefulSet for game server workloads?" comes up a bunch in face to face conversations - so here's a FAQ entry we can point people at.

Which issue(s) this PR fixes:

Closes #2770

Special notes for your reviewer:

N/A

@markmandel markmandel added the kind/documentation Documentation for Agones label Nov 25, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c8719806-dd73-48ba-b557-09ec812b7ac4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2824/head:pr_2824 && git checkout pr_2824
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-bd24043-amd64

site/content/en/docs/FAQ/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/FAQ/_index.md Show resolved Hide resolved
site/content/en/docs/FAQ/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/FAQ/_index.md Outdated Show resolved Hide resolved
site/content/en/docs/FAQ/_index.md Outdated Show resolved Hide resolved
@roberthbailey roberthbailey changed the title FAQ: Why no use Deployment or StatefulSet? FAQ: Why not use Deployment or StatefulSet? Nov 29, 2022
Copy link
Collaborator

@zmerlynn zmerlynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once other comments are resolved.

@google-oss-prow google-oss-prow bot added the lgtm label Nov 29, 2022
@zmerlynn zmerlynn removed their assignment Nov 29, 2022
@mangalpalli mangalpalli added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Nov 29, 2022
The question of "Can't we use a Deployment or a StatefulSet for game
server workloads?" comes up a bunch in face to face conversations - so
here's a FAQ entry we can point people at.

Closes googleforgames#2770
@markmandel markmandel force-pushed the faq/deployment-or-statefulsets branch from bd24043 to 5321968 Compare December 1, 2022 18:28
@google-oss-prow google-oss-prow bot removed the lgtm label Dec 1, 2022
@roberthbailey roberthbailey removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Dec 1, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7a1ed000-ac12-4bd3-bfe0-2199b5257b1c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2824/head:pr_2824 && git checkout pr_2824
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-5321968-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: db758e98-7359-4e41-a9d2-ad582c959107

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2824/head:pr_2824 && git checkout pr_2824
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.28.0-af5d28e-amd64

@markmandel
Copy link
Member Author

This should be good to go now!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 290ef04 into googleforgames:main Dec 1, 2022
@markmandel markmandel deleted the faq/deployment-or-statefulsets branch December 1, 2022 22:03
@mangalpalli mangalpalli added this to the 1.28.0 milestone Dec 6, 2022
chiayi pushed a commit to chiayi/agones that referenced this pull request Dec 13, 2022
FAQ: Why no use Deployment or StatefulSet?

The question of "Can't we use a Deployment or a StatefulSet for game
server workloads?" comes up a bunch in face to face conversations - so
here's a FAQ entry we can point people at.

Closes googleforgames#2770

Co-authored-by: Robert Bailey <robertbailey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a FAQ entry describing when you would use Agones vs. StatefulSets
6 participants