Revert #3070, wait on networking a different way #3107
Conversation
|
Build Failed 😱 Build Id: 3d2515c9-5ba7-4e10-939b-bb884989f7de To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
force-pushed
the
wait-on-networking
branch
2 times, most recently
from
e111eb9
to
c40fe48
Compare
|
Build Failed 😱 Build Id: b590d5ee-5671-49f9-bc59-fe6a1c1d04b6 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
force-pushed
the
wait-on-networking
branch
from
c40fe48
to
e90ce40
Compare
zmerlynn
requested review from
gongmax
and removed request for
EricFortin and
aLekSer
|
Build Succeeded 👏 Build Id: 6b954725-5eb8-470a-9dba-3e2ed011367e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -263,6 +267,38 @@ func (s *SDKServer) Run(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // waitForConnection attempts a GameServer GET every 3s until the client responds. | |||
There was a problem hiding this comment.
Amusingly this matches the exact pattern we use on SDK clients that don't support gRPC.
zmerlynn
force-pushed
the
wait-on-networking
branch
2 times, most recently
from
46efa67
to
bcb9aab
Compare
|
Build Failed 😱 Build Id: 653aecf4-f80e-4ce4-aa57-a414683dfe0f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: ea6d2094-0933-46a2-9f70-7a9d793851ac To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
force-pushed
the
wait-on-networking
branch
from
bcb9aab
to
eef0152
Compare
|
@markmandel I just realized, I thought since you left a non-blocking comment that you can approved it. If you get a sec, PTAL. Or @gongmax or @roberthbailey if you get a chance - thanks! |
|
Build Failed 😱 Build Id: a2768079-7e87-43cd-9932-7c62e57cefff To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: 9ac8d75a-1e85-4ef9-bd0c-454069ee989f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
zmerlynn
force-pushed
the
wait-on-networking
branch
from
eef0152
to
c4c46e8
Compare
The problem addressed by googleforgames#3070 is that on an indeterminate basis, we are seeing containers start without networking fully available. Once networking seems to work, it works fine. However, the fix in googleforgames#3070 introduced a downside: heavy watch traffic, because I didn't quite understand that it would also block the hanging GET of the watch. See googleforgames#3106. Instead of timing out the whole client, let's use an initial-probe approach and instead block on a successful GET (with a reasonable timeout) before we try to start informers. Fixes googleforgames#3106
zmerlynn
force-pushed
the
wait-on-networking
branch
from
c4c46e8
to
d35a366
Compare
|
Build Succeeded 👏 Build Id: 81ea0032-0eff-4b29-a6eb-8026272da9d3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The problem addressed by #3070 is that on an indeterminate basis, we are seeing containers start without networking fully available. Once networking seems to work, it works fine.
However, the fix in #3070 introduced a downside: heavy watch traffic, because I didn't quite understand that it would also block the hanging GET of the watch. See #3106.
Instead of timing out the whole client, let's use an initial-probe approach and instead block on a successful GET (with a reasonable timeout) before we try to start informers.
Fixes #3106