Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #3070, wait on networking a different way #3107

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Revert #3070, wait on networking a different way #3107

merged 2 commits into from
Apr 18, 2023

Commits on Apr 18, 2023

  1. Revert googleforgames#3070, wait on networking a different way 

    The problem addressed by googleforgames#3070 is that on an indeterminate basis, we
are seeing containers start without networking fully available. Once
networking seems to work, it works fine.

However, the fix in googleforgames#3070 introduced a downside: heavy watch traffic,
because I didn't quite understand that it would also block the hanging
GET of the watch. See googleforgames#3106.

Instead of timing out the whole client, let's use an initial-probe
approach and instead block on a successful GET (with a reasonable
timeout) before we try to start informers.

Fixes googleforgames#3106
    @zmerlynn
    zmerlynn committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    94ce6c5 View commit details
    Browse the repository at this point in the history

  2. Along the way: fix nil pointer deref when TestPingHTTP fails

    @zmerlynn
    zmerlynn committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d35a366 View commit details
    Browse the repository at this point in the history