Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Switch Helm Cleanup job to use bitnami/kubectl image #3263

Merged
merged 3 commits into from
Jul 14, 2023
Merged

refactor: Switch Helm Cleanup job to use bitnami/kubectl image #3263

merged 3 commits into from
Jul 14, 2023

Conversation

aimuz
Copy link
Collaborator

@aimuz aimuz commented Jul 13, 2023 •
edited
Loading

Signed-off-by: aimuz mr.imuz@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind cleanup

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3251

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 86eb0f58-0b71-4838-8db8-8d313c94f94b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3263/head:pr_3263 && git checkout pr_3263
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-2a49f2f-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 1eafc401-b980-47a1-9732-5656fb8b3df4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member

Hah - this flake is fixed in #3264

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2c2f38c7-8dfe-487d-aecc-dea1318a6adc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3263/head:pr_3263 && git checkout pr_3263
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-a613ed8-amd64

@aimuz
refactor: Switch Helm Cleanup job to use bitnami/kubectl image
f11317e 
Signed-off-by: aimuz <mr.imuz@gmail.com>
@aimuz aimuz marked this pull request as ready for review July 14, 2023 02:10
@github-actions github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 14, 2023
@aimuz
Copy link
Collaborator Author

aimuz commented Jul 14, 2023

I tested it in my environment and it's OK.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 018573dc-979d-40dc-8f40-f0ecadd90075

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3263/head:pr_3263 && git checkout pr_3263
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-f11317e-amd64

@google-oss-prow google-oss-prow bot added the lgtm label Jul 14, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aimuz, gongmax
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8582c6ba-0a7f-4d95-ad0e-3519d9285b5f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 14, 2023
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6dbc0349-54b5-4525-ac66-d77b23018e58

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3263/head:pr_3263 && git checkout pr_3263
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-69c02b8-amd64

@markmandel markmandel merged commit 5f96673 into googleforgames:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongmax gongmax gongmax approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@EricFortin EricFortin Awaiting requested review from EricFortin

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@gongmax gongmax

Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch Helm Cleanup job to use bitnami/kubectl image
5 participants
@aimuz @agones-bot @markmandel @gongmax @Kalaiselvi84