Flake: TestControllerAllocator

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Fix fo flakiness in TestControllerAllocator unit test.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Also caught a linting issue in gke_test.go that for some reason wasn't picked up elsewhere. Weird.

[agones-bot]

Build Succeeded 👏

Build Id: baf7d934-a240-4dfd-8286-b698b9387af4

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-87c8231-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.34.0-dev-87c8231-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-87c8231-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-87c8231-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-87c8231-amd64
• Linux C++ SDK (build): agonessdk-1.34.0-dev-87c8231-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.34.0-dev-87c8231-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://87c8231-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3264/head:pr_3264 && git checkout pr_3264
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-87c8231-amd64

[aimuz]

/lgtm

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gongmax, igooch, markmandel, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Failed 😱

Build Id: 4d6856e4-52b6-48de-9a53-f595e2413d4a

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Still failed on

--- FAIL: TestControllerAllocator (3.66s)
    --- FAIL: TestControllerAllocator/successful_allocation (3.66s)
        controller_test.go:118: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:118
            	            				/go/src/agones.dev/agones/pkg/gameserverallocations/controller_test.go:125
            	Error:      	Should be true
            	Test:       	TestControllerAllocator/successful_allocation
            	Messages:   	Failed: UnAllocated vs Allocated

So clearly I didn't fix the flake!

[markmandel]

Let's try this again. I think I might know what is happening.

[agones-bot]

Build Succeeded 👏

Build Id: 98705a72-75e9-49b8-b160-dbeac1716acd

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-7d8d032-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.34.0-dev-7d8d032-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-7d8d032-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-7d8d032-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-7d8d032-amd64
• Linux C++ SDK (build): agonessdk-1.34.0-dev-7d8d032-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.34.0-dev-7d8d032-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://7d8d032-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3264/head:pr_3264 && git checkout pr_3264
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-7d8d032-amd64

[agones-bot]

Build Succeeded 👏

Build Id: 12cd8480-b545-4b1a-93e7-2da34189875d

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.34.0-dev-b19977c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.34.0-dev-b19977c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.34.0-dev-b19977c-linux-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.34.0-dev-b19977c-amd64
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.34.0-dev-b19977c-amd64
• Linux C++ SDK (build): agonessdk-1.34.0-dev-b19977c-amd64-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.34.0-dev-b19977c-amd64.zip

A preview of the website (the last 30 builds are retained):

• https://b19977c-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/3264/head:pr_3264 && git checkout pr_3264
• helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-b19977c-amd64