Cloud Build Script For Xonotic #3286

Kalaiselvi84 · 2023-07-25T23:05:21Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #3281

Special notes for your reviewer:

google-oss-prow · 2023-07-25T23:05:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kalaiselvi84
Once this PR has been reviewed and has the lgtm label, please assign alekser for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2023-07-25T23:17:17Z

Build Failed 😱

Build Id: 8314bb93-d789-4189-83f9-d27e0229b2fb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-07-25T23:57:56Z

Flake:

{"error":null,"message":"Allocate (public): failed allocation","severity":"info","test":"TestAllocatorAllocateOnGameServerUpdateError","time":"2023-07-25T23:15:56.853535967Z"}
--- FAIL: TestAllocatorAllocateOnGameServerUpdateError (22.99s)
    allocator_test.go:503: 
        	Error Trace:	/go/src/agones.dev/agones/pkg/gameserverallocations/allocator_test.go:503
        	Error:      	An error is expected but got nil.
        	Test:       	TestAllocatorAllocateOnGameServerUpdateError

Is this PR up to date with main? If not, this flake is not gone 😡

markmandel · 2023-07-26T00:00:48Z

examples/xonotic/Makefile


 mkfile_path := $(abspath $(lastword $(MAKEFILE_LIST)))
 project_path := $(dir $(mkfile_path))
 root_path := $(realpath $(project_path)/../..)
-image_tag = $(REPOSITORY)/xonotic-example:1.1
+image_tag = xonotic-example:1.1


Pretty sure this will work:

Suggested change

image_tag = xonotic-example:1.1

image_tag = xonotic-example:1.1

ifneq ($(REPOSITORY),)

image_tag := $(REPOSITORY)/${image_tag)

endif

Then you don't have to add it all the way through, and also, a tag can't start with "/".

Added an if condition for image_tag

markmandel · 2023-07-26T00:03:10Z

examples/xonotic/Makefile


 # check if hosted on Google Artifact Registry
 gar-check:
-	gcloud container images describe $(image_tag)
+	gcloud container images describe $(REPOSITORY)/$(image_tag)


I think we'll need something like a PRODUCTION_REPOSITORY variable (or something like that) so that gar-check and echo-image-tag still works as it did previously (since they are used for the release process).

Included PROD_REPO variable with agones-images but I'm unsure about the behavior of gar-check and echo-image-tag targets🤔

markmandel · 2023-07-26T00:03:48Z

examples/xonotic/cloudbuild.yaml

+    dir: "."
+    env:
+      - REPOSITORY=${_REPOSITORY}
+      - IMAGE_TAG=${_IMAGE_TAG}


I don't think we need to pass in the IMAGE_TAG, since we already have that defined in the Makefile.

Make sense. Removed IMAGE_TAG👍🏻

markmandel · 2023-07-26T00:04:35Z

examples/xonotic/cloudbuild.yaml

+    args: ["-j", "1", "push"]
+
+substitutions:
+  _REPOSITORY: 'us-docker.pkg.dev/agones-images/examples'


Suggested change

_REPOSITORY: 'us-docker.pkg.dev/agones-images/examples'

_REPOSITORY: 'us-docker.pkg.dev/${PROJECT_ID}/examples'

Then you can easily test it against whatever project you like, which is super nice.

Initially, I gave it a shot with ${PROJECT_ID}, but unfortunately, the build didn't fetch my project, leading to the following error:

"build": docker build -f /workspace//Dockerfile --tag=us-docker.pkg.dev//examples/xonotic-example:1.1 .
"build": invalid argument "us-docker.pkg.dev//examples/xonotic-example:1.1" for "-t, --tag" flag: invalid reference format

Since I added PROD_REPO ?= us-docker.pkg.dev/agones-images/examples, the issue seems to be resolved.

Kalaiselvi84 · 2023-07-26T04:06:52Z

Is this PR up to date with main?
Yes, this branch is up to date. can I create a new PR if it is required?

agones-bot · 2023-07-26T05:19:01Z

Build Succeeded 👏

Build Id: 8e4a43ef-86a7-43d0-9b8d-e9672869d28b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e25a9b7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3286/head:pr_3286 && git checkout pr_3286
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-e25a9b7-amd64

markmandel · 2023-07-26T19:01:27Z

Yes, this branch is up to date. can I create a new PR if it is required?

No, it just means I have to work out why that flake is still happening. I thought I had fixed it.

markmandel

Almost there!

Also - just checking with the new changes, have you checked the cloud build script against your personal dev Google Cloud project?

markmandel · 2023-07-26T19:01:55Z

examples/xonotic/Makefile

+ifeq ($(REPOSITORY),)
+	image_tag := xonotic-example:1.1
+else
+	image_tag := $(PROD_REPO)/xonotic-example:1.1


So my original thought was to do the following:

Suggested change

image_tag := $(PROD_REPO)/xonotic-example:1.1

image_tag := $(REPOSITORY)/xonotic-example:1.1

That would mean that echo-image-tag would need then to be:

echo-image-tag: @echo $(PROD_REPO)/$(image_tag)

Which I think is fine? WDYT?

updated it as per your suggestion

markmandel · 2023-07-26T19:03:34Z

examples/xonotic/cloudbuild.yaml

+    args:
+    - "bash"
+    - "-c"
+    - "echo 'FROM gcr.io/cloud-builders/docker\nRUN apt-get install make\nENTRYPOINT [\"/usr/bin/make\"]' > Dockerfile.build"


Non blocking, but this could actually now use the new script element in Cloud Build:

https://cloud.google.com/build/docs/configuring-builds/run-bash-scripts

script block added in the steps

Kalaiselvi84 · 2023-07-26T21:45:07Z

Also - just checking with the new changes, have you checked the cloud build script against your personal dev Google Cloud project?

Yes, you can find the successful log here

agones-bot · 2023-07-26T23:20:41Z

Build Succeeded 👏

Build Id: af20177c-d04d-41d8-b0b8-e68d668c16c7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://943b624-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3286/head:pr_3286 && git checkout pr_3286
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.34.0-dev-943b624-amd64

agones-bot · 2023-07-27T02:48:40Z

Build Failed 😱

Build Id: 18ab7c79-d909-4b71-80b5-29675f052112

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Kalaiselvi84 · 2023-07-27T02:51:44Z

examples/autoscaler-webhook/Makefile

+
+# build and push the autoscaler-webhook image with specified tag
+cloud-build:
+	gcloud builds submit --config=../cloudbuild.yaml


While working on the autoscaler-webhook image, I encountered the following error:

Step #2 - "build": Already have image: make-docker
Step #2 - "build": cd / && docker build -f /workspace//Dockerfile --tag=us-docker.pkg.dev/agones-mangalpalli/examples/autoscaler-webhook:0.7 .
Step #2 - "build": error checking context: 'no permission to read from '/dev/mem''.
Step #2 - "build": make: *** [Makefile:47: build] Error 1
It seems to be related to permission issues while trying to access '/dev/mem' during the build process. Could you please advise if there's a specific condition we need to add to the build process to avoid this error?

I think we'll need something similar to what we have in make build, which will be something like:

Suggested change

gcloud builds submit --config=../cloudbuild.yaml

cd $(root_path) && gcloud builds submit --config=./examples/autoscaler-webhook/cloudbuild.yaml

And then will likely need up update some of the paths to work from /workspace/examples/autoscaler-webhook/

markmandel · 2023-07-27T17:14:10Z

examples/cloudbuild.yaml

+    entrypoint: "docker"
+    args: ["build", "-f", "Dockerfile.build", "-t", "make-docker", "."]
+
+  # build xonotic image to GCR


We don't need to build first, we only need to push.

Kalaiselvi84 · 2023-07-27T18:20:14Z

Built succeeded for Xonotic image in my project

agones-bot · 2023-07-27T19:32:15Z

Build Failed 😱

Build Id: 3a295f85-5761-43ab-a8c0-050136ff5838

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2023-08-02T04:10:16Z

Build Failed 😱

Build Id: 76a1e1dc-4447-47bf-a3cd-114f92bf7f28

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-08-03T19:56:26Z

Just testing #3273 first, will probably merge that first, then we can do a double check on this PR to make everything still works as expected.

markmandel · 2023-08-08T17:45:18Z

#3273 is merged - shall we either update this to just include the Xonotic changes, or create a new PR?

Also, we should make sure the changes in #3273 still work with the Cloud Build script.

Kalaiselvi84 · 2023-08-08T18:03:01Z

#3273 is merged - shall we either update this to just include the Xonotic changes, or create a new PR?

Also, we should make sure the changes in #3273 still work with the Cloud Build script.

will create a new PR.

cloud build script for xonotic

9355e2b

Kalaiselvi84 requested a review from markmandel July 25, 2023 23:05

google-oss-prow bot added do-not-merge/work-in-progress size/M labels Jul 25, 2023

github-actions bot added the kind/other label Jul 25, 2023

google-oss-prow bot requested a review from EricFortin July 25, 2023 23:05

markmandel reviewed Jul 26, 2023

View reviewed changes

suggested changes

e25a9b7

markmandel reviewed Jul 26, 2023

View reviewed changes

Kalaiselvi84 added 2 commits July 26, 2023 21:39

Included prod_repo variable and added script block in cloudbuild file

c8a7247

Merge branch 'main' into cloud-build-script

943b624

Cloud Build: Build & Push some of example images with targeted Build

92b3edf

google-oss-prow bot added size/L and removed size/M labels Jul 27, 2023

Kalaiselvi84 commented Jul 27, 2023

View reviewed changes

markmandel reviewed Jul 27, 2023

View reviewed changes

cloudbuild.yaml for xonotic image

e64719b

google-oss-prow bot added size/M and removed size/L labels Jul 27, 2023

Kalaiselvi84 changed the title ~~cloud build script for xonotic~~ Cloud Build Script For Xonotic Jul 27, 2023

Kalaiselvi84 marked this pull request as ready for review July 27, 2023 18:20

google-oss-prow bot removed the do-not-merge/work-in-progress label Jul 27, 2023

google-oss-prow bot requested review from aLekSer and markmandel July 27, 2023 18:20

Kalaiselvi84 added kind/feature New features for Agones and removed kind/other labels Jul 27, 2023

Kalaiselvi84 added 2 commits August 2, 2023 03:06

small changes in script

38e53dd

Merge branch 'main' into cloud-build-script

746e8d2

Kalaiselvi84 closed this Aug 8, 2023

Kalaiselvi84 deleted the cloud-build-script branch March 15, 2024 01:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloud Build Script For Xonotic #3286

Cloud Build Script For Xonotic #3286

Kalaiselvi84 commented Jul 25, 2023 •

edited

Loading

google-oss-prow bot commented Jul 25, 2023

agones-bot commented Jul 25, 2023

markmandel commented Jul 25, 2023

markmandel Jul 26, 2023

Kalaiselvi84 Jul 26, 2023

markmandel Jul 26, 2023

Kalaiselvi84 Jul 26, 2023

markmandel Jul 26, 2023

Kalaiselvi84 Jul 26, 2023

markmandel Jul 26, 2023

Kalaiselvi84 Jul 26, 2023

Kalaiselvi84 commented Jul 26, 2023

agones-bot commented Jul 26, 2023

markmandel commented Jul 26, 2023

markmandel left a comment

markmandel Jul 26, 2023

Kalaiselvi84 Jul 26, 2023

markmandel Jul 26, 2023

Kalaiselvi84 Jul 26, 2023

Kalaiselvi84 commented Jul 26, 2023

agones-bot commented Jul 26, 2023

agones-bot commented Jul 27, 2023

Kalaiselvi84 Jul 27, 2023

markmandel Jul 27, 2023

markmandel Jul 27, 2023

Kalaiselvi84 commented Jul 27, 2023

agones-bot commented Jul 27, 2023

agones-bot commented Aug 2, 2023

markmandel commented Aug 3, 2023

markmandel commented Aug 8, 2023

Kalaiselvi84 commented Aug 8, 2023

	_REPOSITORY: 'us-docker.pkg.dev/agones-images/examples'
	_REPOSITORY: 'us-docker.pkg.dev/${PROJECT_ID}/examples'

	image_tag := $(PROD_REPO)/xonotic-example:1.1
	image_tag := $(REPOSITORY)/xonotic-example:1.1

	gcloud builds submit --config=../cloudbuild.yaml
	cd $(root_path) && gcloud builds submit --config=./examples/autoscaler-webhook/cloudbuild.yaml

Cloud Build Script For Xonotic #3286

Cloud Build Script For Xonotic #3286

Conversation

Kalaiselvi84 commented Jul 25, 2023 • edited Loading

google-oss-prow bot commented Jul 25, 2023

agones-bot commented Jul 25, 2023

markmandel commented Jul 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kalaiselvi84 commented Jul 26, 2023

agones-bot commented Jul 26, 2023

markmandel commented Jul 26, 2023

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kalaiselvi84 commented Jul 26, 2023

agones-bot commented Jul 26, 2023

agones-bot commented Jul 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kalaiselvi84 commented Jul 27, 2023

agones-bot commented Jul 27, 2023

agones-bot commented Aug 2, 2023

markmandel commented Aug 3, 2023

markmandel commented Aug 8, 2023

Kalaiselvi84 commented Aug 8, 2023

Kalaiselvi84 commented Jul 25, 2023 •

edited

Loading