-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Build Script For Xonotic #3286
Changes from 2 commits
9355e2b
e25a9b7
c8a7247
943b624
92b3edf
e64719b
38e53dd
746e8d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
# Copyright 2023 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
steps: | ||
|
||
# | ||
# Creates the initial make + docker build platform | ||
# | ||
- name: "ubuntu" | ||
args: | ||
- "bash" | ||
- "-c" | ||
- "echo 'FROM gcr.io/cloud-builders/docker\nRUN apt-get install make\nENTRYPOINT [\"/usr/bin/make\"]' > Dockerfile.build" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non blocking, but this could actually now use the new https://cloud.google.com/build/docs/configuring-builds/run-bash-scripts There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. script block added in the steps |
||
waitFor: ["-"] | ||
|
||
- name: gcr.io/cloud-builders/docker | ||
id: build-make-docker | ||
args: ["build", "-f", "Dockerfile.build", "-t", "make-docker", "."] | ||
|
||
# build xonotic image to GCR | ||
- name: make-docker | ||
id: build | ||
dir: "." | ||
env: | ||
- REPOSITORY=${_REPOSITORY} | ||
args: ["-j", "1", "build"] | ||
|
||
# push xonotic image to GCR | ||
- name: "make-docker" | ||
id: push | ||
waitFor: | ||
- build | ||
dir: "." | ||
env: | ||
- REPOSITORY=${_REPOSITORY} | ||
args: ["-j", "1", "push"] | ||
|
||
substitutions: | ||
_REPOSITORY: us-docker.pkg.dev/${PROJECT_ID}/examples | ||
timeout: 1800s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my original thought was to do the following:
That would mean that
echo-image-tag
would need then to be:Which I think is fine? WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it as per your suggestion