-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FleetAutoScaler v0 #340
FleetAutoScaler v0 #340
Conversation
Build Failed 😱 Build Id: db7dafe9-5bbf-4bbc-87ea-2a4ccecf8fa5 Build Logs
|
Build Succeeded 👏 Build Id: ad90bca2-c9e6-4879-a287-c92e1544c7a3 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
e232735
to
dcf69cb
Compare
Build Succeeded 👏 Build Id: dc9ee49b-7e3c-4cd4-a79c-ad625fb5548d The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Build Succeeded 👏 Build Id: cb72394f-181c-4649-8b4f-dcb73122fa98 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Build Succeeded 👏 Build Id: 95fe0a11-9afc-4985-a032-ca24fabacce1 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Wasn't sure - is this ready for review, or is more work coming? Figured I would ask. |
It's ready for review, yes.
|
Build Succeeded 👏 Build Id: 44c36c7c-f170-49e2-a11d-4d3be834e021 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass - this looks really good 👍 . I want to download it and take it for a spin, and go deeper. Only saw really one thing I think (status), but will definitely also take a longer look.
f81b1f8
to
4831c29
Compare
Build Failed 😱 Build Id: 42654f8a-2fc4-44bd-9f7e-dfc6ad189d32 Build Logs
|
Build Succeeded 👏 Build Id: fbff5d19-4207-4760-87c5-5466ce9b4b34 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
1aeb1e0
to
19ab875
Compare
Build Failed 😱 Build Id: 8884c7eb-cff0-4484-88e7-5e642aae5a6a Build Logs
|
Build Succeeded 👏 Build Id: 838f1fcd-0204-4e2a-8615-d833f050782f The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Build Failed 😱 Build Id: 9d95ad0d-528d-414e-84c3-a51060e03b12 Build Logs
|
Build Failed 😱 Build Id: 3f20e001-2055-4a49-b7ec-3d0cffbeb3d2 Build Logs
|
Build Failed 😱 Build Id: 0ad4ec88-37b3-4602-990d-e1679ef020f1 Build Logs
|
1878de6
to
d14a457
Compare
Build Failed 😱 Build Id: 185570f0-2d66-4f09-b0ab-0189f8a03369 Build Logs
|
Build Failed 😱 Build Id: b1ee8c47-57dd-407e-8ad8-82449c401803 Build Logs
|
b8457b9
to
6f8561c
Compare
Build Failed 😱 Build Id: ab1b56d9-9e35-4803-96c2-bed4c753e878 Build Logs
|
Build Failed 😱 Build Id: b52bd4ee-2077-46c6-9b97-10f535021f3f Build Logs
|
Build Failed 😱 Build Id: 173c6468-19ff-4cfa-8e2c-8adb27270178 Build Logs
|
Build Succeeded 👏 Build Id: 42c83a9e-1209-47aa-afea-5d07c5c1302e The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
36a7169
to
f3e2558
Compare
Build Succeeded 👏 Build Id: b366b9d6-9cdb-4b6a-9a65-9c9ec21f0d8b The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Build Failed 😱 Build Id: 3339ddb3-8176-4885-bf6b-5344364700f5 Build Logs
|
Build Succeeded 👏 Build Id: d926067d-b35a-4a26-ad73-8de61ec77d09 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
@markmandel @EricFortin it's ready for review now |
Build Succeeded 👏 Build Id: 7d44c556-5f14-4c22-ab09-51bb961da137 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
https://en.wikipedia.org/wiki/Autoscaling -- Autoscaling is one word, so I'd be fine with Autoscaler.
|
Build Failed 😱 Build Id: 37758f6f-2fa7-42af-8468-5194371e7c91 Build Logs
|
@markmandel I'm afraid that your GKE test cluster does not agree with the rename, some manual cleanup might be needed :-| |
Oh that's a really fun one. Maybe a good reason to delete the helm chart after we are done? WDYT @Kuqd Cleaning it out now. |
Build Succeeded 👏 Build Id: 391273c2-166d-4cc6-bee2-0e88e134798c The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one tiny little nit - and I'd like to take this for a spin and manually test it, but otherwise, this looks good to go for me.
// TestAutoscalerStressCreate creates many fleetautoscalers with random values | ||
// to check if the creation validation works as expected and if the fleet scales | ||
// to the expected number of replicas (when the creation is valid) | ||
func TestAutoscalerStressCreate(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad you like it 😃
I am also planning to add a stress test for scaling during rolling updates, but in a separate PR.
9a7f279
to
28f1c55
Compare
Build Succeeded 👏 Build Id: cc822ca2-482d-48c5-8b33-9e9bb5da503a The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Fixed missing doc and rebased |
Build Succeeded 👏 Build Id: 9728bbc8-f758-4014-904b-ce198abb0f67 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃🕺💃🕺💃
Implements #334
⚠️ Ready for review. ⚠️
v1 adds policy-based autoscaling.