Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Redundant Windows SDK Builds #3520

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

Kalaiselvi84
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2802

Special notes for your reviewer:

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kalaiselvi84
Once this PR has been reviewed and has the lgtm label, please assign cyriltovena for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 86f5051c-49e7-495d-a939-8f057883490c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3520/head:pr_3520 && git checkout pr_3520
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-dc2ef93-amd64

@Kalaiselvi84
Copy link
Contributor Author

Kalaiselvi84 commented Nov 30, 2023

@markmandel, I have randomly selected this Issue and created this PR. Is this change not necessary?

@markmandel
Copy link
Member

Looks like a good issue to close out - I'll take it for a spin, make sure everything still works as expected 👍🏻

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took it for a spin, looks good! Just need it to come out of draft please!

@Kalaiselvi84 Kalaiselvi84 marked this pull request as ready for review December 5, 2023 18:46
@markmandel markmandel enabled auto-merge (squash) December 5, 2023 18:47
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 66673e0a-1f9d-4867-8048-7f4bf18c251c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3520/head:pr_3520 && git checkout pr_3520
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-0c5c3c4-amd64

@markmandel markmandel merged commit 66ddcfe into googleforgames:main Dec 5, 2023
3 checks passed
@Kalaiselvi84 Kalaiselvi84 deleted the pr_2802 branch March 15, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flake] Cloud Build push-images fails sometimes (windows binary missing)
3 participants