GH Action: Size label for PRs #3532

markmandel · 2023-12-05T18:53:49Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

With the removal of Prow, this provides the size labeling functionality in its stead.

Enjoy!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

With the removal of Prow, this provides the size labeling functionality in its stead. Enjoy!

agones-bot · 2023-12-05T21:24:34Z

Build Succeeded 👏

Build Id: 7cfb2c59-579e-4ff8-9581-274cfcfbd40b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ee95e59-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3532/head:pr_3532 && git checkout pr_3532
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-ee95e59-amd64

agones-bot · 2023-12-06T00:47:57Z

Build Failed 😱

Build Id: 5b947b89-e116-421e-bd93-b7c93b6d1485

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-12-06T00:52:27Z

Flake - gke-autopilot-1.27

E: I1206 00:43:43.683121     305 request.go:696] Waited for 1.487870124s due to client-side throttling, not priority and fairness, request: POST:https://104.196.96.111/apis/allocation.agones.dev/v1/namespaces/1701823302/gameserverallocations
VERBOSE: time="2023-12-06 00:43:50.201" level=info msg="Finished Allocation."
VERBOSE:     gameserverallocation_test.go:1417: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserverallocation_test.go:1417
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: 100
VERBOSE:         	            	actual  : 97
VERBOSE:         	Test:       	TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (127.11s)

agones-bot · 2023-12-06T01:09:21Z

Build Failed 😱

Build Id: 86bacb29-8ddb-4443-ab75-8513375ba768

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-12-06T17:27:58Z

Flake:

#8 exporting to image
#8 pushing layers 0.6s done
#8 pushing manifest for us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e-windows_amd64-ltsc2022@sha256:5e188a3f50d275f45a13690c865e762575eb0d4064b093f70bfa7cc0a61fee13
#8 pushing manifest for us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e-windows_amd64-ltsc2022@sha256:5e188a3f50d275f45a13690c865e762575eb0d4064b093f70bfa7cc0a61fee13 0.2s done
#8 DONE 12.8s
# Ensure that the sidecar manifest is removed before creating a new one.
DOCKER_CLI_EXPERIMENTAL=enabled docker manifest rm us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e
No such manifest: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e
make: [Makefile:712: push-agones-sdk-image] Error 1 (ignored)
DOCKER_CLI_EXPERIMENTAL=enabled docker manifest create us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e-linux-amd64  us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e-windows_amd64-ltsc2019  us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e-windows_amd64-ltsc2022 us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e-linux-arm64
no such manifest: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.37.0-dev-768c79e-amd64
no such manifest: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.37.0-dev-768c79e-linux-amd64
make: *** [Makefile:683: push-allocator-image] Error 1
make: *** Waiting for unfinished jobs....
make: *** [Makefile:713: push-agones-sdk-image] Error 1

I am wondering if #3520 caused this.

agones-bot · 2023-12-06T17:42:32Z

Build Failed 😱

Build Id: 490c58a7-4f48-471b-9499-4299468776cf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-12-06T17:49:19Z

Another flake in unit tests

{"message":"k8s.io/client-go/informers/factory.go:150: Failed to watch *v1.Node: unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"nodes\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}}","severity":"error","time":"2023-12-06T17:39:54.744543976Z"}
{"message":"agones.dev/agones/pkg/client/informers/externalversions/factory.go:134: Failed to watch *v1.GameServer: unhandled watch: testing.WatchActionImpl{ActionImpl:testing.ActionImpl{Namespace:\"\", Verb:\"watch\", Resource:schema.GroupVersionResource{Group:\"agones.dev\", Version:\"v1\", Resource:\"gameservers\"}, Subresource:\"\"}, WatchRestrictions:testing.WatchRestrictions{Labels:labels.internalSelector(nil), Fields:fields.andTerm{}, ResourceVersion:\"\"}}","severity":"error","time":"2023-12-06T17:39:54.745323573Z"}
{"message":"adding gsSet","severity":"info","time":"2023-12-06T17:39:54.798695383Z"}
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x25776e2]

goroutine 695 [running]:
agones.dev/agones/pkg/gameserversets.(*AllocationOverflowController).Run(0x0, {0x2dff5c8, 0xc00043ccf0})
	/go/src/agones.dev/agones/pkg/gameserversets/allocation_overflow.go:98 +0x42
agones.dev/agones/pkg/gameserversets.(*Controller).Run.func1()
	/go/src/agones.dev/agones/pkg/gameserversets/controller.go:194 +0x85
created by agones.dev/agones/pkg/gameserversets.(*Controller).Run
	/go/src/agones.dev/agones/pkg/gameserversets/controller.go:193 +0x33b
FAIL	agones.dev/agones/pkg/gameserversets	0.432s
ok  	agones.dev/agones/pkg/metrics	12.036s

Going to take a look at this, as panics are bad.

agones-bot · 2023-12-06T18:51:15Z

Build Failed 😱

Build Id: 8945a48e-c221-4bb7-a068-135f6c477591

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2023-12-06T19:00:22Z

This again, something is up in this test:

generic-1.26

VERBOSE: time="2023-12-06 18:48:36.731" level=info msg="Scaling fleet" fleet=preferred-kjjlw patch="[{ \"op\": \"replace\", \"path\": \"/spec/replicas\", \"value\": 130 }]" scale=130
VERBOSE: time="2023-12-06 18:48:36.928" level=info msg="Starting Allocation."
VERBOSE: I1206 18:48:39.131242    9257 request.go:696] Waited for 1.06591953s due to client-side throttling, not priority and fairness, request: POST:https://34.81.206.236/apis/allocation.agones.dev/v1/namespaces/1701888449/gameserverallocations
VERBOSE: time="2023-12-06 18:48:39.929" level=info msg="Scaling fleet" fleet=preferred-kjjlw patch="[{ \"op\": \"replace\", \"path\": \"/spec/replicas\", \"value\": 120 }]" scale=120
VERBOSE:     gameserverallocation_test.go:1397: could not completed gsa1 allocation : an error on the server ("error updating allocated gameserver: Operation cannot be fulfilled on gameservers.agones.dev \"preferred-kjjlw-2gdxz-dlv2z\": the object has been modified; please apply your changes to the latest version and try again") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)
VERBOSE: I1206 18:48:49.132164    9257 request.go:696] Waited for 1.512599021s due to client-side throttling, not priority and fairness, request: POST:https://34.81.206.236/apis/allocation.agones.dev/v1/namespaces/1701888449/gameserverallocations
VERBOSE: time="2023-12-06 18:48:55.128" level=info msg="Finished Allocation."
VERBOSE:     gameserverallocation_test.go:1417: 
VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserverallocation_test.go:1417
VERBOSE:         	Error:      	Not equal: 
VERBOSE:         	            	expected: 100
VERBOSE:         	            	actual  : 99
VERBOSE:         	Test:       	TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (85.33s)

agones-bot · 2023-12-06T20:02:11Z

Build Succeeded 👏

Build Id: ee9754f6-3caf-420d-904b-cfbfa7956516

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://768c79e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3532/head:pr_3532 && git checkout pr_3532
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-768c79e-amd64

GH Action: Size label for PRs

ee95e59

With the removal of Prow, this provides the size labeling functionality in its stead. Enjoy!

markmandel added the area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. label Dec 5, 2023

markmandel requested review from zmerlynn and roberthbailey December 5, 2023 18:53

github-actions bot added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 5, 2023

zmerlynn approved these changes Dec 5, 2023

View reviewed changes

zmerlynn enabled auto-merge (squash) December 5, 2023 19:01

zmerlynn mentioned this pull request Dec 5, 2023

chore: k8s.io/kubernetes/.generated_files #3345

Closed

Merge branch 'main' into gh/size-label

768c79e

roberthbailey approved these changes Dec 5, 2023

View reviewed changes

zmerlynn merged commit 0ae3f96 into googleforgames:main Dec 6, 2023
3 checks passed

markmandel mentioned this pull request Dec 6, 2023

Flake: TestControllerWatchGameServers #3534

Merged

markmandel deleted the gh/size-label branch December 7, 2023 18:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH Action: Size label for PRs #3532

GH Action: Size label for PRs #3532

markmandel commented Dec 5, 2023

agones-bot commented Dec 5, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023

GH Action: Size label for PRs #3532

GH Action: Size label for PRs #3532

Conversation

markmandel commented Dec 5, 2023

agones-bot commented Dec 5, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023

markmandel commented Dec 6, 2023

agones-bot commented Dec 6, 2023