Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake: TestControllerWatchGameServers #3534

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Pretty sure there was a panic because a feature flag flipped in the middle of the test, resulting a not fully initialised Allocation Overflow controller.

I believe this will resolve the issue. Either way it doesn't hurt.

Which issue(s) this PR fixes:

Saw the flake in #3532

Special notes for your reviewer:

N/A

Pretty sure there was a panic because a feature flag flipped in the
middle of the test, resulting a not fully initialised Allocation
Overflow controller.

I believe this will resolve the issue. Either way it doesn't hurt.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Dec 6, 2023
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d49e89b7-2517-4b95-bae2-11712941ab8d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3534/head:pr_3534 && git checkout pr_3534
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.37.0-dev-b2283e3-amd64

@zmerlynn zmerlynn merged commit eec32b2 into googleforgames:main Dec 6, 2023
4 checks passed
@markmandel markmandel deleted the flake/TestControllerWatchGameServers branch December 7, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants