Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Site Go Version #3595

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

markmandel
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

go116 was heading towards EOL, so updating it!

Which issue(s) this PR fixes:

N/A - just got an email notification.

Special notes for your reviewer:

N/A

go116 was heading towards EOL, so updating it!
@github-actions github-actions bot added kind/cleanup Refactoring code, fixing up documentation, etc size/XS labels Jan 17, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: bf0c1a54-34fe-4794-b5ff-b7b8a37b57cd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

Looks like a unit test flake: @igooch

--- FAIL: TestSDKServerAddListValue (31.93s)
    --- FAIL: TestSDKServerAddListValue/Add_multiple_values_past_capacity (1.11s)
        sdkserver_test.go:1473: 
            	Error Trace:	/go/src/agones.dev/agones/pkg/sdkserver/sdkserver_test.go:1473
            	Error:      	Not equal: 
            	            	expected: v1.ListStatus{Capacity:10, Values:[]string{"one", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten"}}
            	            	actual  : v1.ListStatus{Capacity:10, Values:[]string{"one", "two", "three", "four", "five", "six", "seven", "eight", "nine"}}
            	            	
            	            	Diff:
            	            	--- Expected
            	            	+++ Actual
            	            	@@ -2,3 +2,3 @@
            	            	  Capacity: (int64) 10,
            	            	- Values: ([]string) (len=10) {
            	            	+ Values: ([]string) (len=9) {
            	            	   (string) (len=3) "one",
            	            	@@ -11,4 +11,3 @@
            	            	   (string) (len=5) "eight",
            	            	-  (string) (len=4) "nine",
            	            	-  (string) (len=3) "ten"
            	            	+  (string) (len=4) "nine"
            	            	  }
            	Test:       	TestSDKServerAddListValue/Add_multiple_values_past_capacity

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d812d4a4-accc-4e7d-a77c-6193d5ea9d28

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Member Author

That's a new flake

=== RUN   TestGameServerCreationAfterDeletingOneExtensionsPod
    high_availability_test.go:36: 
        	Error Trace:	/go/src/agones.dev/agones/test/e2e/extensions/high_availability_test.go:36
        	Error:      	Received unexpected error:
        	            	context deadline exceeded
        	Test:       	TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.977" level=info msg="Length of pod list is 3" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Name of extensions pod 0: agones-extensions-6ffd48f4bb-bdd59" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Host IP 10.138.0.138" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Pod IPs [{10.25.129.157}]" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Name of extensions pod 1: agones-extensions-6ffd48f4bb-bxn7k" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Host IP 10.138.0.151" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Pod IPs [{10.25.132.29}]" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Name of extensions pod 2: agones-extensions-6ffd48f4bb-rgztx" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.978" level=info msg="Host IP 10.138.0.106" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.979" level=info msg="Pod IPs [{10.25.134.251}]" test=TestGameServerCreationAfterDeletingOneExtensionsPod
time="2024-01-17 19:58:39.979" level=info msg="Removing one of the Extensions Pods: agones-extensions-6ffd48f4bb-bxn7k" test=TestGameServerCreationAfterDeletingOneExtensionsPod
FAIL test/e2e/extensions.TestGameServerCreationAfterDeletingOneExtensionsPod (-1.00s)

=== Failed
=== FAIL: test/e2e/extensions  (0.00s)
time="2024-01-17 19:53:39.623" level=info msg="Starting e2e test(s)" cloudProduct=gke-autopilot featureGates="CountsAndLists=true&DisableResyncOnSDKServer=true&Example=true&FleetAllocationOverflow=false&GKEAutopilotExtendedDurationPods=false&PlayerAllocationFilter=true&PlayerTracking=true" gameServerImage="us-docker.pkg.dev/agones-images/examples/simple-game-server:0.24" namespace= perfOutputDir= pullSecret= stressTestLevel=0 version=
time="2024-01-17 19:53:39.623" level=info msg="Cleaning up now."
time="2024-01-17 19:53:39.916" level=info msg="Finished cleanup."
panic: test timed out after 10m0s
running tests:
	TestGameServerCreationAfterDeletingOneExtensionsPod (10m0s)

@markmandel markmandel enabled auto-merge (squash) January 17, 2024 20:19
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 81e88d84-698c-41a4-a0fe-4520d5492cc4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3595/head:pr_3595 && git checkout pr_3595
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.38.0-dev-6868103-amd64

@markmandel markmandel merged commit 5fb9f1b into googleforgames:main Jan 17, 2024
4 checks passed
@markmandel markmandel deleted the site/update-appengine branch January 17, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants