Custom Controller Example Page on Agones Website #3725

Kalaiselvi84 · 2024-03-22T03:35:10Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2024-03-22T04:41:07Z

Build Succeeded 👏

Build Id: 7af85ed4-db56-4b5d-aa88-9f4408c25b52

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://1e0a881-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3725/head:pr_3725 && git checkout pr_3725
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-1e0a881-amd64

igooch

Good work! A couple follow up comments.

examples/custom-controller/README.md

site/content/en/docs/Examples/custom-controller.md

agones-bot · 2024-03-26T06:51:36Z

Build Succeeded 👏

Build Id: 9b9a46f5-313f-4642-b715-e32d15b7d0dc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://9c59d9a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3725/head:pr_3725 && git checkout pr_3725
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-9c59d9a-amd64

agones-bot · 2024-03-26T22:06:09Z

Build Failed 😱

Build Id: 58afaf77-c331-456c-b9bb-7496c76b06fd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Kalaiselvi84 · 2024-03-26T22:15:46Z

Flake
VERBOSE: gameserverallocation_test.go:1442:
VERBOSE: Error Trace: /go/src/agones.dev/agones/test/e2e/gameserverallocation_test.go:1442
VERBOSE: Error: Not equal:
VERBOSE: expected: 100
VERBOSE: actual : 98
VERBOSE: Test: TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (49.42s)

agones-bot · 2024-03-26T22:34:11Z

Build Failed 😱

Build Id: 5abc0b8b-7c49-469c-a2cf-8de6e7e23ef0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Quick run through review!

site/content/en/docs/Examples/custom-controller.md

agones-bot · 2024-03-29T18:29:25Z

Build Succeeded 👏

Build Id: ac088ba2-1c84-4c96-a3f6-46674857c95e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://8d07715-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3725/head:pr_3725 && git checkout pr_3725
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-8d07715-amd64

agones-bot · 2024-04-02T20:14:16Z

Build Failed 😱

Build Id: 014eda1a-df53-490d-82b2-414604ac9026

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

examples/custom-controller/README.md

site/content/en/docs/Examples/custom-controller.md

markmandel · 2024-04-03T00:08:21Z

site/content/en/docs/Examples/custom-controller.md

+
+## Deploy the Agones Fleet
+
+To apply the fleet configuration to your cluster, use the following command:


Can lift the create a fleet markdown from https://agones.dev/site/docs/getting-started/create-fleet/#1-create-a-fleet

Then they don't need to worry about cloning the whole repository.

Currently, I've copied the information from the create a fleet section. Would it be sufficient to include the link https://agones.dev/site/docs/getting-started/create-fleet/#1-create-a-fleet is enough?

something like:

## Create a Fleet Please refer to the documentation on creating a fleet available at [this link](https://agones.dev/site/docs/getting-started/create-fleet/#1-create-a-fleet) for detailed information

site/content/en/docs/Examples/custom-controller.md

markmandel · 2024-04-03T00:11:15Z

Assuming all these patterns also work - we can replicate these to the other examples as well 😄

site/content/en/docs/Examples/custom-controller.md

agones-bot · 2024-04-03T19:55:42Z

Build Failed 😱

Build Id: ea5196fb-6275-43c7-9bc6-8ebb3a2dad82

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-03T23:47:15Z

Build Failed 😱

Build Id: c917dcb0-b017-43f0-ba84-20a7deab43d6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel

Minor bits, but once that's done, this is good to merge 👍🏻

markmandel · 2024-04-05T20:11:12Z

examples/custom-controller/README.md

+
+This is an example of how to write a customer controller integrated with Agones resources.
+
+This example shows how to create, deploy and run a Custom Kubernetes Controller for Agones that logs changes to GameServers and modifies their labels.


As per the other ones, this should link to the documentation page we're writing now.

I've made all the suggested changes.

site/content/en/docs/Examples/custom-controller.md

markmandel

Approved!

Will take a peek at the preview before merging.

agones-bot · 2024-04-05T22:56:47Z

Build Succeeded 👏

Build Id: 2b829207-dbe0-46d4-82c8-f6b61804fe86

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://9c49ce4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3725/head:pr_3725 && git checkout pr_3725
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-9c49ce4-amd64

agones-bot · 2024-04-06T01:29:09Z

Build Failed 😱

Build Id: 55e69076-82e2-4c35-a32b-227a36083846

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-06T05:33:29Z

Build Succeeded 👏

Build Id: 381b9dfe-0044-47ac-9d3d-ba45c273aab7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://7a88ceb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3725/head:pr_3725 && git checkout pr_3725
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-7a88ceb-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3738 **Implemented enhancements:** - Leader Election in Custom Controller by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3696 - Migrating from generate-groups.sh to kube_codegen.sh by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3722 - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3729 - Move DisableResyncOnSDKServer to Beta by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3732 - Counters & Lists landing page and doc improvements by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3649 - Graduate FleetAllocationOverflow to Stable by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3733 - Adds Counters and Lists to CSharp SDK by [@igooch](https://github.com/igooch) in [googleforgames/agones#3581 - Feat/counter and list defaulting order to ascending by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3734 - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@charlesvien](https://github.com/charlesvien) in [googleforgames/agones#3739 - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3764 - Be prescriptive about rotating regions when updating Kubernetes versions by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3716 - Fix ensure-e2e-infra-state-bucket by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3719 - Create Performance Cluster 1.28 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3720 - Optimise GameServer Sub-Controller Queues by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3781 **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3690 - Fix(Counter & Lists): Add validation for `priorities` by [@lacroixthomas](https://github.com/lacroixthomas) in [googleforgames/agones#3714 - fix: [#3607](https://github.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@alvin-7](https://github.com/alvin-7) in [googleforgames/agones#3692 - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3750 **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@dependabot](https://github.com/dependabot) in [googleforgames/agones#3755 - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3793 **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3699 - Prep for release v1.40.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3700 - Bumps cpp-simple Image and Refactoring Example Makefiles by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3695 - Upgrade Protobuf to 1.33.0 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3711 - Modify Script for Makefile Version Updates in Examples Directory by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3712 - Adds simple genai server example documentation to the Agones site by [@igooch](https://github.com/igooch) in [googleforgames/agones#3713 - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3654 - fix: typo in docs by [@qhyun2](https://github.com/qhyun2) in [googleforgames/agones#3723 - Tweak: Setting up the Game Server by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3717 - Docs: gke.md - spelling by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3740 - Aesthetic rearrangement of cloudbuild.yaml by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3741 - Docs: Make hitting <enter> on connection explicit by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3743 - CI: Don't check Unreal Link by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3745 - New recommendation for multi-cluster allocation by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3744 - Custom Controller Example Page on Agones Website by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3725 - Add Nitrado logo by [@towolf](https://github.com/towolf) in [googleforgames/agones#3753 - Remove unnecessary args from e2e-test-cloudbuild by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3754 - Update Allocation from Fleet Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3761 - Transform Lint Warnings into Errors by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3756 - Update Canary Testing Documentation by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3760 - Supertuxkart Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3728 - Xonotic Example on Agones Site by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3742 - nit documentation fix in kind cluster section when building Agones by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3770 - Merged steps inside documentation about webhook certificate creation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3768 - Example Images: Increment Tags by [@Kalaiselvi84](https://github.com/Kalaiselvi84) in [googleforgames/agones#3796 - Update simple game server example documentation by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3776 **New Contributors:** - [@lacroixthomas](https://github.com/lacroixthomas) made their first contribution in [googleforgames/agones#3714 - [@daniellee](https://github.com/daniellee) made their first contribution in [googleforgames/agones#3740 - [@charlesvien](https://github.com/charlesvien) made their first contribution in [googleforgames/agones#3739 - [@vicentefb](https://github.com/vicentefb) made their first contribution in [googleforgames/agones#3770 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Kalaiselvi84 added 2 commits March 22, 2024 03:30

Custom Controller Example Page on Agones Website

5aa9712

remove \n

1e0a881

Kalaiselvi84 requested a review from igooch March 22, 2024 03:35

github-actions bot added kind/other size/S labels Mar 22, 2024

igooch reviewed Mar 26, 2024

View reviewed changes

Review changes

9c59d9a

Kalaiselvi84 added 2 commits March 26, 2024 20:55

modify docs

26e96eb

modify docs

aba9d67

Merge branch 'main' into cc-docs

5b95402

Kalaiselvi84 requested a review from markmandel March 27, 2024 16:56

markmandel reviewed Mar 29, 2024

View reviewed changes

site/content/en/docs/Examples/custom-controller.md Show resolved Hide resolved

site/content/en/docs/Examples/custom-controller.md Outdated Show resolved Hide resolved

Review changes

0a875de

github-actions bot added the size/M label Mar 29, 2024

Merge branch 'main' into cc-docs

8d07715

Kalaiselvi84 requested a review from zmerlynn March 30, 2024 00:05

Kalaiselvi84 added 2 commits April 2, 2024 19:07

Include example code link

6639538

Merge branch 'main' into cc-docs

f67ccee

markmandel reviewed Apr 3, 2024

View reviewed changes

site/content/en/docs/Examples/custom-controller.md Outdated Show resolved Hide resolved

Kalaiselvi84 added 2 commits April 3, 2024 18:43

changes based on the review suggestion

9e56a12

update create custom controller section

0ddf43c

Kalaiselvi84 added 2 commits April 3, 2024 19:03

branch update

73df972

Merge branch 'main' into cc-docs

90227c6

tweak

cffcb76

markmandel reviewed Apr 5, 2024

View reviewed changes

Kalaiselvi84 added 2 commits April 5, 2024 21:05

apply suggested changes

d2b0da8

Merge branch 'main' into cc-docs

9c49ce4

markmandel approved these changes Apr 5, 2024

View reviewed changes

markmandel enabled auto-merge (squash) April 5, 2024 23:15

Merge branch 'main' into cc-docs

f7c0672

Merge branch 'main' into cc-docs

7a88ceb

markmandel merged commit c1320ee into googleforgames:main Apr 6, 2024
4 checks passed

Kalaiselvi84 added kind/documentation Documentation for Agones and removed kind/other labels Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom Controller Example Page on Agones Website #3725

Custom Controller Example Page on Agones Website #3725

Kalaiselvi84 commented Mar 22, 2024

agones-bot commented Mar 22, 2024

igooch left a comment

agones-bot commented Mar 26, 2024

agones-bot commented Mar 26, 2024

Kalaiselvi84 commented Mar 26, 2024

agones-bot commented Mar 26, 2024

markmandel left a comment

agones-bot commented Mar 29, 2024

agones-bot commented Apr 2, 2024

markmandel Apr 3, 2024

Kalaiselvi84 Apr 3, 2024

markmandel commented Apr 3, 2024

agones-bot commented Apr 3, 2024

agones-bot commented Apr 3, 2024

markmandel left a comment

markmandel Apr 5, 2024

Kalaiselvi84 Apr 5, 2024

markmandel left a comment

agones-bot commented Apr 5, 2024

agones-bot commented Apr 6, 2024

agones-bot commented Apr 6, 2024


		## Deploy the Agones Fleet

		To apply the fleet configuration to your cluster, use the following command:


		This is an example of how to write a customer controller integrated with Agones resources.

		This example shows how to create, deploy and run a Custom Kubernetes Controller for Agones that logs changes to GameServers and modifies their labels.

Custom Controller Example Page on Agones Website #3725

Custom Controller Example Page on Agones Website #3725

Conversation

Kalaiselvi84 commented Mar 22, 2024

agones-bot commented Mar 22, 2024

igooch left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 26, 2024

agones-bot commented Mar 26, 2024

Kalaiselvi84 commented Mar 26, 2024

agones-bot commented Mar 26, 2024

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Mar 29, 2024

agones-bot commented Apr 2, 2024

markmandel Apr 3, 2024

Choose a reason for hiding this comment

Kalaiselvi84 Apr 3, 2024

Choose a reason for hiding this comment

markmandel commented Apr 3, 2024

agones-bot commented Apr 3, 2024

agones-bot commented Apr 3, 2024

markmandel left a comment

Choose a reason for hiding this comment

markmandel Apr 5, 2024

Choose a reason for hiding this comment

Kalaiselvi84 Apr 5, 2024

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 5, 2024

agones-bot commented Apr 6, 2024

agones-bot commented Apr 6, 2024