Agones Unity SDK development setup instructions + Agones Unity SDK Ready test #3887

aallbrig · 2024-06-29T19:32:56Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:
Following instructions proposed in #3886 I set up a local environment to contribute to agones unity client sdk.

I noticed there wasn't a test. This adds a first test. I don't think it's a good test so please offer up what might make for a better first test.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2024-06-29T20:56:51Z

Build Succeeded 👏

Build Id: 5078706a-0651-4905-aa15-cae53be14e47

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://5c54ed5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-5c54ed5-amd64

sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs

agones-bot · 2024-07-14T21:17:44Z

Build Succeeded 👏

Build Id: 9ff063dc-f993-481a-a6dd-a505f55b3f6a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://19512c6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-19512c6-amd64

igooch · 2024-07-15T06:52:37Z

Noob question -- what are the steps to run the tests? Are we able to run the tests similar to vanilla csharp (csharp SDK tests have the non-obvious steps of 1. navigating to agones/build 2. running make sdk-shell-csharp 3. once in the C# shell navigating to the test folder /go/src/agones.dev/agones/sdks/csharp/test 4. using standard dotnet commands such as dotnet test.), or does this require a Unity editor?

ZeroParticle · 2024-07-15T21:29:18Z

Noob question -- what are the steps to run the tests? Are we able to run the tests similar to vanilla csharp (csharp SDK tests have the non-obvious steps of 1. navigating to agones/build 2. running make sdk-shell-csharp 3. once in the C# shell navigating to the test folder /go/src/agones.dev/agones/sdks/csharp/test 4. using standard dotnet commands such as dotnet test.), or does this require a Unity editor?

For the tests setup I added in #3883, I added a README that might help answer this for you. It's at the very bottom of the PR. My understanding is that it's basically impossible to run these tests without the unity editor. Even the common CI setups for Unity are just running a dockerized editor.

igooch · 2024-07-15T21:47:58Z

My understanding is that it's basically impossible to run these tests without the unity editor. Even the common CI setups for Unity are just running a dockerized editor.

Would it makes sense to open up a new issue for creating some sort of pipeline for running the Unity tests? Possibly CloudBuild could take in a Unity license as a Secret and run the tests in the dockerized editor mode?

aallbrig · 2024-07-16T02:49:14Z

@igooch You're definitely right that developing unity packages is not intuitive. I wrote documentation in this PR (#3886) for how to set up a testing environment that's common. I've used this setup when contributing to other unity open source projects like Mirror. You can follow the instructions in that PR to set up to then develop a unity package.

Should I merge that PR into this one, so documentation exists along with this test?

aallbrig · 2024-07-16T02:57:20Z

@igooch I can help with using game CI's docker container to run tests. I've used that container image before to cross platform test & build in parallel since I didn't like serially builds in unity editor.

There's a little setup to do but I've scripted its use out before. Would need to review this project's CI more to understand how to introduce a new testing step (guidance is welcome and appreciated!)

Unity docker usage seems outside the scope of this PR, maybe, since it's a test suite agnostic enhancement? WDYT?

agones-bot · 2024-07-16T16:10:43Z

Build Succeeded 👏

Build Id: b324d10c-f98c-4b56-ac8d-e0ab706f6e3c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://48eaee5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-48eaee5-amd64

sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs

agones-bot · 2024-07-18T19:27:15Z

Build Succeeded 👏

Build Id: a2c8734d-c23a-468c-9cd5-b2d57fa26499

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://af604a3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-af604a3-amd64

… contributing to agones unity sdk

Co-authored-by: igooch <igooch@google.com>

aallbrig · 2024-07-23T01:06:15Z

@zmerlynn @igooch @markmandel tagging for some review. Thank you in advance!

markmandel

Thanks for doing this! Mostly nit comments.

sdks/unity/IRequestSender.cs

sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs

test/sdk/unity/.gitignore

sdks/unity/Tests/TestingEnvironment/SpyRequestSender.cs

markmandel · 2024-07-23T01:27:50Z

sdks/unity/IRequestSender.cs

+
+namespace Agones
+{
+    public interface IRequestSender


oooh, what's this do? 😄 👀

This is a way of being able to stub out the HTTP request that ultimately gets sent by the Agones Unity component. There are implications on code (a protected method is now public, a new public property exists on AgonesSdk component) but it was as minimally invasive to the production code as I could come up with. You can see in sdks/unity/AgonesSdk.cs that the component implements IRequestSender and also assigns itself to the component property IRequestSender requestSender on component start.

Check out sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs and sdks/unity/Tests/TestingEnvironment/SpyRequestSender.cs to see how a London style test is then used to ensure when an Agones method is called an HTTP request should get sent. This test overrides the new public property.

Other things I had tried:

A previous version of code (4e8caa0) spins up a generic HTTP server that allows the test code to specify an HTTP response. Felt too clever.

Use reflection to override some UnityWebRequest functionality. I got somewhere with this but UnityWebRequest is hard to override functionality (no virtual methods, no interfaces, etc).

Install a dev package dependency to sdks/unity/package.json; I learned that although a Unity Custom Package manifest does allow one to specify dependencies property it won't allow one to spell out scopedRegistries to be able to use openupm or npm to gain access to non-Unity registry libraries (see "Optional Properties" in Unity Custom Package: Package Manifest Unity docs). _Even if I could install anything on openupm I can't use a library like NSubstitute on UnityWebRequest for aforementioned reasons.

I'm open to suggestions/thoughts!

sdks/unity/README.md

Co-authored-by: Mark Mandel <markmandel@google.com>

github-actions · 2024-07-23T11:19:57Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-07-23T12:20:20Z

Build Succeeded 👏

Build Id: a8a38947-9a0f-40c2-835e-164b4f2dd94a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://b48b315-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-b48b315-amd64

github-actions · 2024-07-23T13:19:44Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

aallbrig · 2024-07-23T13:52:30Z

@markmandel I added an apache header to all added C# code in this PR. I also added it to sdks/unity/model/StatusAddresses.cs which is a class that pre-exists this PR but I found it was missing an apache header.

I debated if I should mark the year 2019 or 2024; I opted for 2024.

agones-bot · 2024-07-23T14:17:06Z

Build Succeeded 👏

Build Id: d103deee-ec55-427d-8f3a-09e9f2f2cbd6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e0ec4fa-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-e0ec4fa-amd64

ZeroParticle · 2024-07-23T18:22:38Z

Happy to update my PR #3883 to use this project if that's what we go for. The tests in my project run against a local SDK server rather than a mock. That seems complimentary to what you have here, so I figure we will want to keep it around rather than replace it.

aallbrig · 2024-07-23T18:33:11Z

@ZeroParticle Thanks for weighing in! Yes I think adding tests in the style of this PR is better than in the style of your PR. The style of this PR has the tests contained within the package files which is more expected for a custom unity package.

I'm hoping @markmandel (and/or other(s)) review/merge this PR soon which will enable both of us to evolve this base code.

aallbrig · 2024-07-24T01:25:04Z

@zmerlynn @igooch @markmandel tagging for another round of review. Thank you again in advance!

github-actions · 2024-07-24T18:42:16Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2024-07-24T19:46:20Z

Build Succeeded 👏

Build Id: 236d2f3a-47a4-4f8d-b91e-3f44b53c18f2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3f6648f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-3f6648f-amd64

agones-bot · 2024-07-25T18:26:30Z

Build Succeeded 👏

Build Id: 368d740a-cdb0-4269-bcb7-864b648876e7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3f316b7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-3f316b7-amd64

zmerlynn · 2024-07-25T20:59:40Z

@ZeroParticle @aallbrig - @markmandel and I were chatting. We don't have a great way to test this right now, unfortunately. @ZeroParticle, if I review this, would you be up for ad hoc testing and seeing if it looks reasonable? @aallbrig - same question for other Unity PRs as they come in.

Basically, if y'all are willing, we're happy to review and then gradually let y'all be the Unity maintainers, but we may need help on the testing front.

agones-bot · 2024-07-25T22:18:32Z

Build Succeeded 👏

Build Id: 9617c1de-a0d0-4f9b-aecb-8f12a1a9e185

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://e6eee46-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3887/head:pr_3887 && git checkout pr_3887
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-e6eee46-amd64

aallbrig · 2024-07-26T16:13:53Z

@zmerlynn I would be happy to help with the Agones Unity SDK maintenance and development. I think @ZeroParticle and I can help with testing and other project needs.

I think we both agree this PR will serve as a good base PR to build more tests for the Agones Unity SDK. Once merged, @ZeroParticle's AgonesSDK additions (+tests) can move under the Agones Custom Unity Package and I can help by code review + checking out the branch code on my machine.

I'll try to think up a way to make testing an easier to prove out for a broader audience.

aallbrig · 2024-07-29T16:21:37Z

Was trying to get gameci docker container working but got stuck. They changed how licenses work in Unity, and a license is required to be able to use the Unity editor app. Gameci is based on Ubuntu; a hub generated license is tied to the hardware/OS -- so using my M2 license won't work for an Ubuntu container.

Unity changed the process of obtaining a license. It's generated through Unity Hub app now.

I was reverse engineering what gameci does. There's plenty of JS that obfuscates so I just need to keep reading and experimenting. There is a way of generating docker commands to run tests (I've done it before), just need to work out the license limitations.

The reason I bring up gameci is because it could help make running tests something that can run in a container, which may decrease the burden of contributing to Agones Unity SDK. Imagine recommending a user run a few commands instead of downloading/installing Unity Hub, mucking with a GUI, then opening the project in Unity Editor to then run some tests.

Just posting some updates.

I'm still hoping that this PR is deemed mergeable even without the gameci docker commands. Getting the initial Unity project set up and configured to pull in the local copy of Agones Unity SDK is foundational to further development. Even though it would be better to have shareable docker commands, we still have a way of developing/testing the Agones Unity SDK as documented in this PR.

zmerlynn · 2024-07-29T16:55:15Z

I'm happy to take this as a base PR to build on. Thanks @aallbrig and @ZeroParticle !

aallbrig · 2024-07-29T17:14:24Z

Woohoo!

Cc: @ZeroParticle it's been merged! Let me know if you need/want any help on your Agones Unity SDK additions/tests.

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.42.0` -> `1.43.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.43.0`](https://github.com/googleforgames/agones/releases/tag/v1.43.0) [Compare Source](https://github.com/googleforgames/agones/compare/v1.42.0...v1.43.0) This is the 1.43.0 release of Agones. In this release, we updated the supported Kubernetes version, added a new scheduled autoscaler, as well as Unity support for Counters and Lists.. - **Kubernetes 1.30 Support** With this release, the Kubernetes support matrix for Agones is now 1.28, 1.29 and 1.30. - **Alpha support for ScheduledAutoscaler** This provides the ability to have Fleet autoscaler scheduling with the feature flag `ScheduledAutoscaler`, to allow you to schedule what level of autoscaling you would like on a schedule or between dates, giving you more control over your autoscaling needs. - **Unity SDK: Counters and Lists** We now have support for `GameServer` [Counters and Lists](https://agones.dev/site/docs/guides/counters-and-lists/) with our Unity SDK! - **New Helm Installation Configuration Options** Two new installation options! We made the parameters that control how fast we scale up and down `GameServers` configurable, so you can see how fast your Kubernetes control plane really is when spinning up lots of `GameServer` instances. We also have new Helm configuration options that allow the use of the host network for the Agones controller and extensions for AWS EKS when using Cilium. - **Beta support for Passthrough PortPolicy on GKE Autopilot** We’ve graduated Passthrough Port Policy support from Alpha to Beta on GKE Autopilot, which you can now enable using the feature flag `AutopilotPassthroughPort`.  #### What's Changed ##### Breaking changes - Revert "Update Supported Kubernetes to 1.28, 1.29, 1.30 ([#3933](https://github.com/googleforgames/agones/issues/3933))" by [@gongmax](https://github.com/gongmax) in [googleforgames/agones#3952 ##### Implemented enhancements - Add Option to Use Host Network and Configure Ports by [@Orza](https://github.com/Orza) in [googleforgames/agones#3895 - Graduate Passthrough Port Policy to Beta on Autopilot by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3916 - Agones Unity SDK development setup instructions + Agones Unity SDK Ready test by [@aallbrig](https://github.com/aallbrig) in [googleforgames/agones#3887 - feat: Add API Changes and Validation for FleetAutoscaler Schedule/Chain Policy by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3893 - feat: Adds autoscaling logic for new Chain and Schedule policies by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3929 - Adds basic framework for the in place Agones upgrades test controller by [@igooch](https://github.com/igooch) in [googleforgames/agones#3956 - \[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3927 - Make the parameters that limits the number of GameServers to add configurable by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3950 - feat: Adds e2e tests for chain/schedule policy and bump ScheduledAutoscaler to Alpha by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3946 - Implement CountsAndLists for Unity SDK + Tests by [@ZeroParticle](https://github.com/ZeroParticle) in [googleforgames/agones#3883 ##### Fixed bugs - Resolves `make site-server` issue [#3885](https://github.com/googleforgames/agones/issues/3885) by [@aallbrig](https://github.com/aallbrig) in [googleforgames/agones#3914 ##### Other - Preparation for Release v1.43.0 by [@kamaljeeti](https://github.com/kamaljeeti) in [googleforgames/agones#3910 - Introduce external resource(s) on multiplayer game programming to docs by [@aallbrig](https://github.com/aallbrig) in [googleforgames/agones#3884 - Added line of code to update failure count details inside runscenario by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3915 - updated golang upgrade template by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3902 - Changes for GitHub/Cloud Build app integration by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3918 - Meta: Contributor role by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3922 - Fix allocator metrics endpoint by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3921 - Meta: Contributor => Collaborator by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3928 - Rewrite agones-bot, commit to Agones repo by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3923 - Small cleanup of incorrect comment in features.go file by [@igooch](https://github.com/igooch) in [googleforgames/agones#3944 - Update Supported Kubernetes to 1.28, 1.29, 1.30 by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3933 - remove ctx within the condition func by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3959 - Reapply "Update Supported Kubernetes to 1.28, 1.29, 1.30 ([#3933](https://github.com/googleforgames/agones/issues/3933))" ([#3](https://github.com/googleforgames/agones/issues/3)… by [@gongmax](https://github.com/gongmax) in [googleforgames/agones#3961 - change kubernetes API version to fix broken CI by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3962 - docs(godot): add Agones x Godot third party example by [@andresromerodev](https://github.com/andresromerodev) in [googleforgames/agones#3938 - Link Unity Netcode for Gameobjects example in documentation by [@mbychkowski](https://github.com/mbychkowski) in [googleforgames/agones#3937 - Docs: Use k8s-api-version for links by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3963 #### New Contributors - [@Orza](https://github.com/Orza) made their first contribution in [googleforgames/agones#3895 **Full Changelog**: googleforgames/agones@v1.42.0...v1.43.0 Images available with this release: - [us-docker.pkg.dev/agones-images/release/agones-controller:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-controller:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-sdk:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-sdk:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-ping:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-ping:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-allocator:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-allocator:1.43.0) - [us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.9](https://us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.9) - [us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.14](https://us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.14) - [us-docker.pkg.dev/agones-images/examples/cpp-simple-server:0.18](https://us-docker.pkg.dev/agones-images/examples/cpp-simple-server:0.18) - [us-docker.pkg.dev/agones-images/examples/crd-client:0.17](https://us-docker.pkg.dev/agones-images/examples/crd-client:0.17) - [us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10](https://us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10) - [us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13](https://us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13) - [us-docker.pkg.dev/agones-images/examples/simple-game-server:0.34](https://us-docker.pkg.dev/agones-images/examples/simple-game-server:0.34) - [us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.14](https://us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.14) - [us-docker.pkg.dev/agones-images/examples/unity-simple-server:0.3](https://us-docker.pkg.dev/agones-images/examples/unity-simple-server:0.3) - [us-docker.pkg.dev/agones-images/examples/xonotic-example:2.0](https://us-docker.pkg.dev/agones-images/examples/xonotic-example:2.0) Helm chart available with this release: - <a href="https://agones.dev/chart/stable/agones-1.43.0.tgz" data-proofer-ignore> <code>helm install agones agones/agones --version 1.43.0</code></a> > Make sure to add our stable helm repository using `helm repo add agones https://agones.dev/chart/stable` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

github-actions bot added kind/feature New features for Agones size/S labels Jun 29, 2024

markmandel reviewed Jul 11, 2024

View reviewed changes

sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs Show resolved Hide resolved

sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs Outdated Show resolved Hide resolved

github-actions bot added the size/M label Jul 14, 2024

igooch requested a review from zmerlynn July 15, 2024 21:26

aallbrig force-pushed the agones-unity-client-sdk-initialize-test branch from 231e3c4 to 48eaee5 Compare July 16, 2024 14:11

aallbrig force-pushed the agones-unity-client-sdk-initialize-test branch from 48eaee5 to 59d85ff Compare July 18, 2024 17:28

aallbrig commented Jul 18, 2024

View reviewed changes

sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs Outdated Show resolved Hide resolved

sdks/unity/Tests/Runtime/PlayMode/AgonesSdkComplianceTests.cs Outdated Show resolved Hide resolved

aallbrig and others added 11 commits July 19, 2024 18:55

Add instructions on how to set up a local development environment for…

5f0af0a

… contributing to agones unity sdk

edits

4fc7eb8

igooch nit

1b4479c

Co-authored-by: igooch <igooch@google.com>

igooch nit

4079c80

Co-authored-by: igooch <igooch@google.com>

ensure Agones, Unity, SDK capitalization follows norms

1ce79a5

Move Unity client sdk development instructions into more specific place

8583886

u -> U

efc34d3

First test for the agones unity client sdk

5f042fe

Mock out Agones SDK server for unity component tests

484acfb

Removes wip test

0948b8f

adds apache header

0ddf6f2

aallbrig force-pushed the agones-unity-client-sdk-initialize-test branch from af604a3 to 0ddf6f2 Compare July 19, 2024 22:56

Initialize a new unity project

d0330dc

markmandel reviewed Jul 23, 2024

View reviewed changes

Apache header year correction

b48b315

Co-authored-by: Mark Mandel <markmandel@google.com>

Ensure apache header is on all relevant Agones Unity SDK code

e0ec4fa

Merge branch 'main' into agones-unity-client-sdk-initialize-test

3f6648f

Merge branch 'main' into agones-unity-client-sdk-initialize-test

3f316b7

aallbrig requested a review from markmandel July 25, 2024 18:49

Merge branch 'main' into agones-unity-client-sdk-initialize-test

e6eee46

zmerlynn approved these changes Jul 29, 2024

View reviewed changes

zmerlynn merged commit 46c5ef9 into googleforgames:main Jul 29, 2024
4 checks passed

ZeroParticle mentioned this pull request Jul 29, 2024

Implement CountsAndLists for Unity SDK + Tests #3883

Merged

aallbrig mentioned this pull request Jul 29, 2024

[Agones Unity SDK] Add instructions to run tests using a Container Image(s) #3926

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agones Unity SDK development setup instructions + Agones Unity SDK Ready test #3887

Agones Unity SDK development setup instructions + Agones Unity SDK Ready test #3887

aallbrig commented Jun 29, 2024

agones-bot commented Jun 29, 2024

agones-bot commented Jul 14, 2024

igooch commented Jul 15, 2024

ZeroParticle commented Jul 15, 2024

igooch commented Jul 15, 2024

aallbrig commented Jul 16, 2024

aallbrig commented Jul 16, 2024

agones-bot commented Jul 16, 2024

agones-bot commented Jul 18, 2024

aallbrig commented Jul 23, 2024

markmandel left a comment

markmandel Jul 23, 2024

aallbrig Jul 23, 2024 •

edited

Loading

github-actions bot commented Jul 23, 2024

agones-bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

aallbrig commented Jul 23, 2024

agones-bot commented Jul 23, 2024

ZeroParticle commented Jul 23, 2024

aallbrig commented Jul 23, 2024

aallbrig commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

agones-bot commented Jul 24, 2024

agones-bot commented Jul 25, 2024

zmerlynn commented Jul 25, 2024

agones-bot commented Jul 25, 2024

aallbrig commented Jul 26, 2024

aallbrig commented Jul 29, 2024

zmerlynn commented Jul 29, 2024

aallbrig commented Jul 29, 2024

Agones Unity SDK development setup instructions + Agones Unity SDK Ready test #3887

Agones Unity SDK development setup instructions + Agones Unity SDK Ready test #3887

Conversation

aallbrig commented Jun 29, 2024

agones-bot commented Jun 29, 2024

agones-bot commented Jul 14, 2024

igooch commented Jul 15, 2024

ZeroParticle commented Jul 15, 2024

igooch commented Jul 15, 2024

aallbrig commented Jul 16, 2024

aallbrig commented Jul 16, 2024

agones-bot commented Jul 16, 2024

agones-bot commented Jul 18, 2024

aallbrig commented Jul 23, 2024

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jul 23, 2024

Choose a reason for hiding this comment

aallbrig Jul 23, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jul 23, 2024

agones-bot commented Jul 23, 2024

github-actions bot commented Jul 23, 2024

aallbrig commented Jul 23, 2024

agones-bot commented Jul 23, 2024

ZeroParticle commented Jul 23, 2024

aallbrig commented Jul 23, 2024

aallbrig commented Jul 24, 2024

github-actions bot commented Jul 24, 2024

agones-bot commented Jul 24, 2024

agones-bot commented Jul 25, 2024

zmerlynn commented Jul 25, 2024

agones-bot commented Jul 25, 2024

aallbrig commented Jul 26, 2024

aallbrig commented Jul 29, 2024

zmerlynn commented Jul 29, 2024

aallbrig commented Jul 29, 2024

aallbrig Jul 23, 2024 •

edited

Loading