change kubernetes API version to fix broken CI #3962

peterzhongyi · 2024-08-22T18:14:50Z

change kubernetes API version to fix broken CI

agones-bot · 2024-08-22T18:47:54Z

Build Failed 😭

Build Id: 49a4c639-318c-476a-8b60-6ff6811d35bd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-08-23T00:55:00Z

Build Succeeded 🥳

Build Id: e5b210e4-8525-4a5e-961d-b9a17ebe3bc8

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.43.0-dev-5f7b971
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.43.0-dev-5f7b971
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.43.0-dev-5f7b971-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.43.0-dev-5f7b971
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.43.0-dev-5f7b971
Linux C++ SDK (build): agonessdk-1.43.0-dev-5f7b971-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.43.0-dev-5f7b971.zip

A preview of the website (the last 30 builds are retained):

https://5f7b971-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3962/head:pr_3962 && git checkout pr_3962
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.43.0-dev-5f7b971

markmandel · 2024-08-23T05:42:57Z

site/content/en/docs/Reference/gameserver.md

@@ -208,7 +208,7 @@ for `address`.)
 The policy for `address` will work for many use-cases, but for some advanced cases, such as IPv6 enablement, you may need
 to evaluate all `addresses` and pick the addresses that best suits your needs.

-[addresses]: https://v1-26.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#nodeaddress-v1-core
-[podIPs]: https://v1-26.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#podip-v1-core
+[addresses]: https://v1-28.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#nodeaddress-v1-core


Suggested change

[addresses]: https://v1-28.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#nodeaddress-v1-core

[addresses]: {{< k8s-api-version href="#nodeaddress-v1-core" >}}

Does this not work?

No this will fail: https://pantheon.corp.google.com/cloud-build/builds;region=global/49a4c639-318c-476a-8b60-6ff6811d35bd;step=19?e=13803378&mods=allow_workbench_image_override&project=agones-images

It's complaining something about some colon, but I can't make anything out of it

markmandel

Approving just to unstick CI 👍🏻

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.42.0` -> `1.43.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.43.0`](https://github.com/googleforgames/agones/releases/tag/v1.43.0) [Compare Source](https://github.com/googleforgames/agones/compare/v1.42.0...v1.43.0) This is the 1.43.0 release of Agones. In this release, we updated the supported Kubernetes version, added a new scheduled autoscaler, as well as Unity support for Counters and Lists.. - **Kubernetes 1.30 Support** With this release, the Kubernetes support matrix for Agones is now 1.28, 1.29 and 1.30. - **Alpha support for ScheduledAutoscaler** This provides the ability to have Fleet autoscaler scheduling with the feature flag `ScheduledAutoscaler`, to allow you to schedule what level of autoscaling you would like on a schedule or between dates, giving you more control over your autoscaling needs. - **Unity SDK: Counters and Lists** We now have support for `GameServer` [Counters and Lists](https://agones.dev/site/docs/guides/counters-and-lists/) with our Unity SDK! - **New Helm Installation Configuration Options** Two new installation options! We made the parameters that control how fast we scale up and down `GameServers` configurable, so you can see how fast your Kubernetes control plane really is when spinning up lots of `GameServer` instances. We also have new Helm configuration options that allow the use of the host network for the Agones controller and extensions for AWS EKS when using Cilium. - **Beta support for Passthrough PortPolicy on GKE Autopilot** We’ve graduated Passthrough Port Policy support from Alpha to Beta on GKE Autopilot, which you can now enable using the feature flag `AutopilotPassthroughPort`.  #### What's Changed ##### Breaking changes - Revert "Update Supported Kubernetes to 1.28, 1.29, 1.30 ([#3933](https://github.com/googleforgames/agones/issues/3933))" by [@gongmax](https://github.com/gongmax) in [https://github.com/googleforgames/agones/pull/3952](https://github.com/googleforgames/agones/pull/3952) ##### Implemented enhancements - Add Option to Use Host Network and Configure Ports by [@Orza](https://github.com/Orza) in [https://github.com/googleforgames/agones/pull/3895](https://github.com/googleforgames/agones/pull/3895) - Graduate Passthrough Port Policy to Beta on Autopilot by [@vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3916](https://github.com/googleforgames/agones/pull/3916) - Agones Unity SDK development setup instructions + Agones Unity SDK Ready test by [@aallbrig](https://github.com/aallbrig) in [https://github.com/googleforgames/agones/pull/3887](https://github.com/googleforgames/agones/pull/3887) - feat: Add API Changes and Validation for FleetAutoscaler Schedule/Chain Policy by [@indexjoseph](https://github.com/indexjoseph) in [https://github.com/googleforgames/agones/pull/3893](https://github.com/googleforgames/agones/pull/3893) - feat: Adds autoscaling logic for new Chain and Schedule policies by [@indexjoseph](https://github.com/indexjoseph) in [https://github.com/googleforgames/agones/pull/3929](https://github.com/googleforgames/agones/pull/3929) - Adds basic framework for the in place Agones upgrades test controller by [@igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3956](https://github.com/googleforgames/agones/pull/3956) - \[Performance] - Added a new metric inside the allocator to track the success retry rate inside the retry loop by [@vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3927](https://github.com/googleforgames/agones/pull/3927) - Make the parameters that limits the number of GameServers to add configurable by [@vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3950](https://github.com/googleforgames/agones/pull/3950) - feat: Adds e2e tests for chain/schedule policy and bump ScheduledAutoscaler to Alpha by [@indexjoseph](https://github.com/indexjoseph) in [https://github.com/googleforgames/agones/pull/3946](https://github.com/googleforgames/agones/pull/3946) - Implement CountsAndLists for Unity SDK + Tests by [@ZeroParticle](https://github.com/ZeroParticle) in [https://github.com/googleforgames/agones/pull/3883](https://github.com/googleforgames/agones/pull/3883) ##### Fixed bugs - Resolves `make site-server` issue [#3885](https://github.com/googleforgames/agones/issues/3885) by [@aallbrig](https://github.com/aallbrig) in [https://github.com/googleforgames/agones/pull/3914](https://github.com/googleforgames/agones/pull/3914) ##### Other - Preparation for Release v1.43.0 by [@kamaljeeti](https://github.com/kamaljeeti) in [https://github.com/googleforgames/agones/pull/3910](https://github.com/googleforgames/agones/pull/3910) - Introduce external resource(s) on multiplayer game programming to docs by [@aallbrig](https://github.com/aallbrig) in [https://github.com/googleforgames/agones/pull/3884](https://github.com/googleforgames/agones/pull/3884) - Added line of code to update failure count details inside runscenario by [@vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3915](https://github.com/googleforgames/agones/pull/3915) - updated golang upgrade template by [@ashutosji](https://github.com/ashutosji) in [https://github.com/googleforgames/agones/pull/3902](https://github.com/googleforgames/agones/pull/3902) - Changes for GitHub/Cloud Build app integration by [@zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3918](https://github.com/googleforgames/agones/pull/3918) - Meta: Contributor role by [@markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3922](https://github.com/googleforgames/agones/pull/3922) - Fix allocator metrics endpoint by [@vicentefb](https://github.com/vicentefb) in [https://github.com/googleforgames/agones/pull/3921](https://github.com/googleforgames/agones/pull/3921) - Meta: Contributor => Collaborator by [@markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3928](https://github.com/googleforgames/agones/pull/3928) - Rewrite agones-bot, commit to Agones repo by [@zmerlynn](https://github.com/zmerlynn) in [https://github.com/googleforgames/agones/pull/3923](https://github.com/googleforgames/agones/pull/3923) - Small cleanup of incorrect comment in features.go file by [@igooch](https://github.com/igooch) in [https://github.com/googleforgames/agones/pull/3944](https://github.com/googleforgames/agones/pull/3944) - Update Supported Kubernetes to 1.28, 1.29, 1.30 by [@ashutosji](https://github.com/ashutosji) in [https://github.com/googleforgames/agones/pull/3933](https://github.com/googleforgames/agones/pull/3933) - remove ctx within the condition func by [@peterzhongyi](https://github.com/peterzhongyi) in [https://github.com/googleforgames/agones/pull/3959](https://github.com/googleforgames/agones/pull/3959) - Reapply "Update Supported Kubernetes to 1.28, 1.29, 1.30 ([#3933](https://github.com/googleforgames/agones/issues/3933))" ([#3](https://github.com/googleforgames/agones/issues/3)… by [@gongmax](https://github.com/gongmax) in [https://github.com/googleforgames/agones/pull/3961](https://github.com/googleforgames/agones/pull/3961) - change kubernetes API version to fix broken CI by [@peterzhongyi](https://github.com/peterzhongyi) in [https://github.com/googleforgames/agones/pull/3962](https://github.com/googleforgames/agones/pull/3962) - docs(godot): add Agones x Godot third party example by [@andresromerodev](https://github.com/andresromerodev) in [https://github.com/googleforgames/agones/pull/3938](https://github.com/googleforgames/agones/pull/3938) - Link Unity Netcode for Gameobjects example in documentation by [@mbychkowski](https://github.com/mbychkowski) in [https://github.com/googleforgames/agones/pull/3937](https://github.com/googleforgames/agones/pull/3937) - Docs: Use k8s-api-version for links by [@markmandel](https://github.com/markmandel) in [https://github.com/googleforgames/agones/pull/3963](https://github.com/googleforgames/agones/pull/3963) #### New Contributors - [@Orza](https://github.com/Orza) made their first contribution in [https://github.com/googleforgames/agones/pull/3895](https://github.com/googleforgames/agones/pull/3895) **Full Changelog**: googleforgames/agones@v1.42.0...v1.43.0 Images available with this release: - [us-docker.pkg.dev/agones-images/release/agones-controller:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-controller:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-sdk:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-sdk:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-ping:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-ping:1.43.0) - [us-docker.pkg.dev/agones-images/release/agones-allocator:1.43.0](https://us-docker.pkg.dev/agones-images/release/agones-allocator:1.43.0) - [us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.9](https://us-docker.pkg.dev/agones-images/examples/allocation-endpoint-proxy:0.9) - [us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.14](https://us-docker.pkg.dev/agones-images/examples/autoscaler-webhook:0.14) - [us-docker.pkg.dev/agones-images/examples/cpp-simple-server:0.18](https://us-docker.pkg.dev/agones-images/examples/cpp-simple-server:0.18) - [us-docker.pkg.dev/agones-images/examples/crd-client:0.17](https://us-docker.pkg.dev/agones-images/examples/crd-client:0.17) - [us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10](https://us-docker.pkg.dev/agones-images/examples/nodejs-simple-server:0.10) - [us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13](https://us-docker.pkg.dev/agones-images/examples/rust-simple-server:0.13) - [us-docker.pkg.dev/agones-images/examples/simple-game-server:0.34](https://us-docker.pkg.dev/agones-images/examples/simple-game-server:0.34) - [us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.14](https://us-docker.pkg.dev/agones-images/examples/supertuxkart-example:0.14) - [us-docker.pkg.dev/agones-images/examples/unity-simple-server:0.3](https://us-docker.pkg.dev/agones-images/examples/unity-simple-server:0.3) - [us-docker.pkg.dev/agones-images/examples/xonotic-example:2.0](https://us-docker.pkg.dev/agones-images/examples/xonotic-example:2.0) Helm chart available with this release: - <a href="https://agones.dev/chart/stable/agones-1.43.0.tgz" data-proofer-ignore> <code>helm install agones agones/agones --version 1.43.0</code></a> > Make sure to add our stable helm repository using `helm repo add agones https://agones.dev/chart/stable` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

github-actions bot added size/XS kind/other labels Aug 22, 2024

change kubernetes API links to use k8s-api-version

5f7b971

peterzhongyi force-pushed the doc branch from d4814cc to 5f7b971 Compare August 22, 2024 23:52

markmandel reviewed Aug 23, 2024

View reviewed changes

peterzhongyi changed the title ~~change kubernetes API links to use k8s-api-version~~ change kubernetes API version to fix broken CI Aug 23, 2024

markmandel reviewed Aug 23, 2024

View reviewed changes

markmandel approved these changes Aug 23, 2024

View reviewed changes

markmandel merged commit 32515f4 into googleforgames:main Aug 23, 2024
4 checks passed

peterzhongyi deleted the doc branch August 23, 2024 16:33

peterzhongyi mentioned this pull request Aug 23, 2024

Use Markdown when use k8s-api-version variable #3964

Merged

peterzhongyi mentioned this pull request Oct 1, 2024

Request to become approver of Agone repo #4007

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change kubernetes API version to fix broken CI #3962

change kubernetes API version to fix broken CI #3962

peterzhongyi commented Aug 22, 2024 •

edited

Loading

agones-bot commented Aug 22, 2024

agones-bot commented Aug 23, 2024

markmandel Aug 23, 2024

peterzhongyi Aug 23, 2024 •

edited

Loading

markmandel left a comment

	[addresses]: https://v1-28.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#nodeaddress-v1-core
	[addresses]: {{< k8s-api-version href="#nodeaddress-v1-core" >}}

change kubernetes API version to fix broken CI #3962

change kubernetes API version to fix broken CI #3962

Conversation

peterzhongyi commented Aug 22, 2024 • edited Loading

agones-bot commented Aug 22, 2024

agones-bot commented Aug 23, 2024

markmandel Aug 23, 2024

Choose a reason for hiding this comment

peterzhongyi Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

peterzhongyi commented Aug 22, 2024 •

edited

Loading

peterzhongyi Aug 23, 2024 •

edited

Loading