Cleanup Patch Sidecar Logging #3973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 🥳 Build Id: 74589f1c-5abe-4017-b56d-b22785ad1dba The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
igooch
reviewed
Aug 28, 2024
| @@ -457,7 +458,12 @@ func (s *SDKServer) patchGameServer(ctx context.Context, gs, gsCopy *agonesv1.Ga | |||
| return nil, err | |||
There was a problem hiding this comment.
Do we also need to account for this error return as well?
There was a problem hiding this comment.
Just double checked - this is already wrapped, so we don't have to re-wrap it.
Also, if there is an issue with creating a patch, that's really shouldn't happen and should definitely be logged.
|
Build Succeeded 🥳 Build Id: 88e25500-7625-4f75-832f-6e7a4175112b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Missed this little of nuance in code review when moving to Patch with the SDK Sidecar - in that a Patch operation doesn't return a Conflict error type/status value if it fails, so every time it does, the Agones sidecar will log it as an error on production installs. So this cleaned up a few things: * renamed "debugError" type to "traceError" type, since we only log it under Trace, not Debug. * if `patchGameServer` fails under the error `IsInvalid`, wrap it in a TraceError so it doesn't show up in prod. * Wrapped the error with `errors` context, such that if the patch does fail, it's far easier now to work out where it failed. Closes googleforgames#3967
markmandel
force-pushed
the
logging/sidecar-patch
branch
from
071f92c
to
12ec087
Compare
|
Build Succeeded 🥳 Build Id: bd4e58ac-ec69-4e9c-88cc-4cb3861f3a30 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
gongmax
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Missed this little of nuance in code review when moving to Patch with the SDK Sidecar - in that a Patch operation doesn't return a Conflict error type/status value if it fails, so every time it does, the Agones sidecar will log it as an error on production installs.
So this cleaned up a few things:
patchGameServerfails under the errorIsInvalid, wrap it in a TraceError so it doesn't show up in prod.errorscontext, such that if the patch does fail, it's far easier now to work out where it failed.Which issue(s) this PR fixes:
Closes #3967
Special notes for your reviewer: