Commits on Sep 12, 2024

1. Cleanup Patch Sidecar Logging …

   Missed this little of nuance in code review when moving to Patch with
   the SDK Sidecar - in that a Patch operation doesn't return a Conflict
   error type/status value if it fails, so every time it does, the Agones
   sidecar will log it as an error on production installs.
   
   So this cleaned up a few things:
   
   * renamed "debugError" type to "traceError" type, since we only log it
   under Trace, not Debug.
   * if `patchGameServer` fails under the error `IsInvalid`, wrap it in a
   TraceError so it doesn't show up in prod.
   * Wrapped the error with `errors` context, such that if the patch does
   fail, it's far easier now to work out where it failed.
   
   Closes googleforgames#3967

   

   markmandel committed Sep 12, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 12ec087
   • Browse repository at this point

   Copy the full SHA

   12ec087 View commit details

   Browse the repository at this point in the history