Remove crd-install hook, as it break CRD updates

[markmandel]

This is a problem that Helm is going to solve going forward, but for now, if you use the crd-install hook, then you can only install CRDs, and not update them at any point during a chart lifecycle.

Also, prior to Helm 2.12, if you installed chart with a crd-install hook that did not have one previously, it deleted the CRDs.

Therefore, removing the crd-install hook, so that CRDs are again managed by the Helm charts.

Added a agones.crd.install parameter, in case someone wants to subchart this chart, then can set this to false, and copy the Agones CRDs into their own charts to be included in the right place for their chart lifecycle.

Also, since we have a agones.crd config section, moved agones.enableHelmCleanupHooks into agones.crds.cleanupOnDelete

Unfortunately, with this back and forth on the crd-install hook, if you are using the Helm chart, you will need to do a full Agones helm delete --purge and cleanup any remaining CRDs to upgrade.

More context on helm + crds:

• crd-install hook is not working on upgrade #4259 helm/helm#4697
• Performance Regression: mixer cpu use significantly higher in 1.0.3  istio/istio#9604
• Helm delete does not clean the custom resource definitions istio/istio#7688
• Proposal for Helm CRD support helm/community#64
• Lifecycle of a CRD (CustomResourceDefinition) as handled by Helm2 helm/helm#4863
• Fix for existing CRDs are deleted when crd-install hook is introduced helm/helm#4709

[markmandel]

/cc @EricFortin please let me know if you have any issues with me moving your config to agones.crds.cleanupOnDelete - felt like a good spot for it, but not got a strong opinion.

/cc @smoya FYI, since you first proposed this. Unfortunately crd-install hooks are really broken 😭 , but I wanted to give you a heads up on the workaround I put in the docs - feedback appreciated.

[agones-bot]

Build Failed 😱

Build Id: 36d3e4c7-7322-410f-9f5e-7475e983246c

Build Logs

starting build "36d3e4c7-7322-410f-9f5e-7475e983246c"

FETCHSOURCE
Initialized empty Git repository in /workspace/.git/
fatal: remote error: want eb2d07fa231427c5ca4d80ad038ce714de4daf4a not valid
fatal: the remote end hung up unexpectedly
Reinitialized existing Git repository in /workspace/.git/
fatal: remote origin already exists.
fatal: remote error: want eb2d07fa231427c5ca4d80ad038ce714de4daf4a not valid
fatal: the remote end hung up unexpectedly
Reinitialized existing Git repository in /workspace/.git/
fatal: remote origin already exists.
fatal: remote error: want eb2d07fa231427c5ca4d80ad038ce714de4daf4a not valid
fatal: the remote end hung up unexpectedly
ERROR
ERROR: fetching git source: Failure fetching git repo: exit status 128

[agones-bot]

Build Succeeded 👏

Build Id: 3058f107-108f-43eb-b0cc-0bf4ec3c5f6e

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.7.0-422768e
• image: gcr.io/agones-images/agones-sdk:0.7.0-422768e
• image: gcr.io/agones-images/agones-ping:0.7.0-422768e
• Linux C++ SDK (build: dev): agonessdk-0.7.0-422768e-dev-linux-arch_64.tar.gz
• Linux C++ SDK (build: runtime): agonessdk-0.7.0-422768e-runtime-linux-arch_64.tar.gz
• Linux C++ SDK (source): agonessdk-0.7.0-422768e-src.zip
• SDK Server: agonessdk-server-0.7.0-422768e.zip

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/441/head:pr_441 && git checkout pr_441
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-422768e

[smoya]

Thanks for taking care @markmandel ! And thanks for mentioning me as well. Good solution btw.

[sdake]

@markmandel note Istio came up with a slightly different solution:

See: istio/istio#10562

And specifically tiller-hack here:
istio/tools#31

This tool works around the problem of CRDs being deleted. Note, this tool is specific to Istio, but the solution could be generalized.

Just thought I'd share.

Cheers
-steve

[markmandel]

@sdake I'm struggling to work out what they are doing here. Can you give a quick summary?