Commits on Dec 8, 2018

1. Remove crd-install hook, as it break CRD updates …

   This is a problem that Helm is going to solve going forward, but for now
   if you use the crd-install hook, then you can only install CRDs, and not
   update them at any point during a chart lifecycle.
   
   Also, prior to Helm 2.12, if you installed chart with a crd-install hook
   that did not have one previously, it deleted the CRDs.
   
   Therefore, removing the crd-install hook, so that CRDs are again managed
   by the Helm charts.
   
   Added a `agones.crd.install` parameter, in case someone wants to subchart
   this chart, then can set this to false, and copy the Agones CRDs into
   their own charts to be included in the right place for their chart lifecycle.
   
   Also, since we have a `agones.crd` config section, moved
   `agones.enableHelmCleanupHooks` into `agones.crds.cleanupOnDelete`
   
   Unfortunately, with this back and forth on the crd-install hook, if you are
   using the Helm chart, you will need to do a full Agones
   `helm delete --purge` and cleanup any remaining CRDs to upgrade.
   
   More context on helm + crds:
   - helm/helm#4697
   - istio/istio#9604
   - istio/istio#7688
   - helm/community#64
   - helm/helm#4863
   - helm/helm#4709

   

   markmandel committed Dec 8, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 422768e
   • Browse repository at this point

   Copy the full SHA

   422768e View commit details

   Browse the repository at this point in the history