Split pkg/gameservers into two

[jkowalski]

This cleanly extracts pkg/sdkserver from pkg/gameserver. No code was actually shared between SDK and controller, so this was a very clean split (only one test function had to be moved)

Addresses #445

[agones-bot]

Build Failed 😱

Build Id: b9a1a999-a71f-45a2-9405-826d050a0101

Build Logs

starting build "b9a1a999-a71f-45a2-9405-826d050a0101"

FETCHSOURCE
Initialized empty Git repository in /workspace/.git/
From https://source.developers.google.com/p/agones-images/r/agones
 * branch            d43f4a71bb2f8aa07209c10cc0e6150cf2657a63 -> FETCH_HEAD
HEAD is now at d43f4a7 extracted parts of pkg/gameservers that deal with SDK server into pkg/sdkserver
BUILD
Starting Step #0
Step #0: Pulling image: ubuntu
Step #0: Using default tag: latest
Step #0: latest: Pulling from library/ubuntu
Step #0: Digest: sha256:acd85db6e4b18aafa7fcde5480872909bd8e6d5fbd4e5e790ecc09acc06a8b78
Step #0: Status: Downloaded newer image for ubuntu:latest
Finished Step #0
Starting Step #1
Step #1: Already have image (with digest): gcr.io/cloud-builders/docker
Step #1: Sending build context to Docker daemon  121.1MB

Step #1: Step 1/3 : FROM gcr.io/cloud-builders/docker
Step #1:  ---> 66f0eddf9d9a
Step #1: Step 2/3 : RUN apt-get install make
Step #1:  ---> Running in aa593ed692eb
Step #1: Reading package lists...
Step #1: Building dependency tree...
Step #1: Reading state information...
Step #1: make is already the newest version (4.1-6).
Step #1: 0 upgraded, 0 newly installed, 0 to remove and 9 not upgraded.
Step #1: Removing intermediate container aa593ed692eb
Step #1:  ---> 265100a8de23
Step #1: Step 3/3 : ENTRYPOINT ["/usr/bin/make"]
Step #1:  ---> Running in fb83280e5216
Step #1: Removing intermediate container fb83280e5216
Step #1:  ---> 2f9111853b41
Step #1: Successfully built 2f9111853b41
Step #1: Successfully tagged make-docker:latest
Finished Step #1
Starting Step #2
Step #2: Already have image: make-docker
Step #2: docker pull gcr.io/agones-images/agones-build:ecb91b2ec8 && docker tag gcr.io/agones-images/agones-build:ecb91b2ec8 agones-build:ecb91b2ec8
Step #2: ecb91b2ec8: Pulling from agones-images/agones-build
Step #2: 54f7e8ac135a: Already exists
Step #2: d6b856b25aeb: Pulling fs layer
Step #2: b4d69f3225dc: Pulling fs layer
Step #2: 037d177bc558: Pulling fs layer
Step #2: a920f8d81a07: Pulling fs layer
Step #2: cb4439cccf6a: Pulling fs layer
Step #2: ca60fe9971ac: Pulling fs layer
Step #2: 900a5d8ecad0: Pulling fs layer
Step #2: 126a6a5e55c2: Pulling fs layer
Step #2: eab845d45588: Pulling fs layer
Step #2: 9ab11613e389: Pulling fs layer
Step #2: 654bf86a9373: Pulling fs layer
Step #2: 3ab16d44460d: Pulling fs layer
Step #2: 1f1c41258e4c: Pulling fs layer
Step #2: 7a847f58dbc4: Pulling fs layer
Step #2: 0af37e69ef9b: Pulling fs layer
Step #2: 11048ac216f7: Pulling fs layer
Step #2: 9878e98813e5: Pulling fs layer
Step #2: c16fbfd1c0a6: Pulling fs layer
Step #2: e8be9ef6d09a: Pulling fs layer
Step #2: 83bc17d22bbf: Pulling fs layer
Step #2: 19d5d2da3421: Pulling fs layer
Step #2: 1f1c41258e4c: Waiting
Step #2: c16fbfd1c0a6: Waiting
Step #2: 7a847f58dbc4: Waiting
Step #2: 0af37e69ef9b: Waiting
Step #2: 11048ac216f7: Waiting
Step #2: cb4439cccf6a: Waiting
Step #2: 900a5d8ecad0: Waiting
Step #2: 9878e98813e5: Waiting
Step #2: ca60fe9971ac: Waiting
Step #2: 126a6a5e55c2: Waiting
Step #2: a920f8d81a07: Waiting
Step #2: e8be9ef6d09a: Waiting
Step #2: 83bc17d22bbf: Waiting
Step #2: 19d5d2da3421: Waiting
Step #2: 654bf86a9373: Waiting
Step #2: 037d177bc558: Verifying Checksum
Step #2: 037d177bc558: Download complete
Step #2: d6b856b25aeb: Verifying Checksum
Step #2: d6b856b25aeb: Download complete
Step #2: a920f8d81a07: Verifying Checksum
Step #2: a920f8d81a07: Download complete
Step #2: ca60fe9971ac: Verifying Checksum
Step #2: ca60fe9971ac: Download complete
Step #2: 900a5d8ecad0: Verifying Checksum
Step #2: 900a5d8ecad0: Download complete
Step #2: cb4439cccf6a: Verifying Checksum
Step #2: cb4439cccf6a: Download complete
Step #2: 126a6a5e55c2: Verifying Checksum
Step #2: 126a6a5e55c2: Download complete
Step #2: eab845d45588: Verifying Checksum
Step #2: eab845d45588: Download complete
Step #2: 9ab11613e389: Verifying Checksum
Step #2: 9ab11613e389: Download complete
Step #2: 654bf86a9373: Verifying Checksum
Step #2: 654bf86a9373: Download complete
Step #2: 3ab16d44460d: Verifying Checksum
Step #2: 3ab16d44460d: Download complete
Step #2: 7a847f58dbc4: Verifying Checksum
Step #2: 7a847f58dbc4: Download complete
Step #2: 1f1c41258e4c: Verifying Checksum
Step #2: 1f1c41258e4c: Download complete
Step #2: 11048ac216f7: Verifying Checksum
Step #2: 11048ac216f7: Download complete
Step #2: 0af37e69ef9b: Verifying Checksum
Step #2: 0af37e69ef9b: Download complete
Step #2: c16fbfd1c0a6: Verifying Checksum
Step #2: c16fbfd1c0a6: Download complete
Step #2: 9878e98813e5: Verifying Checksum
Step #2: 9878e98813e5: Download complete
Step #2: e8be9ef6d09a: Verifying Checksum
Step #2: e8be9ef6d09a: Download complete
Step #2: 83bc17d22bbf: Verifying Checksum
Step #2: 83bc17d22bbf: Download complete
Step #2: 19d5d2da3421: Verifying Checksum
Step #2: 19d5d2da3421: Download complete
Step #2: d6b856b25aeb: Pull complete
Step #2: b4d69f3225dc: Verifying Checksum
Step #2: b4d69f3225dc: Download complete
Step #2: b4d69f3225dc: Pull complete
Step #2: 037d177bc558: Pull complete
Step #2: a920f8d81a07: Pull complete
Step #2: cb4439cccf6a: Pull complete
Step #2: ca60fe9971ac: Pull complete
Step #2: 900a5d8ecad0: Pull complete
Step #2: 126a6a5e55c2: Pull complete
Step #2: eab845d45588: Pull complete
Step #2: 9ab11613e389: Pull complete
Step #2: 654bf86a9373: Pull complete
Step #2: 3ab16d44460d: Pull complete
Step #2: 1f1c41258e4c: Pull complete
Step #2: 7a847f58dbc4: Pull complete
Step #2: 0af37e69ef9b: Pull complete
Step #2: 11048ac216f7: Pull complete
Step #2: 9878e98813e5: Pull complete
Step #2: c16fbfd1c0a6: Pull complete
Step #2: e8be9ef6d09a: Pull complete
Step #2: 83bc17d22bbf: Pull complete
Step #2: 19d5d2da3421: Pull complete
Step #2: Digest: sha256:ce010082a9af71629473622e6492c36a9a5717eb39c052184ae7242ecf7cab96
Step #2: Status: Downloaded newer image for gcr.io/agones-images/agones-build:ecb91b2ec8
Finished Step #2
Starting Step #3 - "lint"
Step #3 - "lint": Already have image: make-docker
Step #3 - "lint": mkdir -p ~/.kube/
Step #3 - "lint": mkdir -p /workspace/build//.config/gcloud
Step #3 - "lint": mkdir -p ~/.helm
Step #3 - "lint": docker run -t -e "TERM=xterm-256color" --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.helm:/root/.helm -v /workspace:/go/src/agones.dev/agones -w /go/src/agones.dev/agones  agones-build:ecb91b2ec8 bash -c \
Step #3 - "lint": 	"golangci-lint run ./examples/... && golangci-lint run --deadline 15m ./..."
Step #3 - "lint": �[1mpkg/sdkserver/helper_test.go:35�[0m:6: �[31m`newSingleContainerSpec` is unused�[0m (deadcode)
Step #3 - "lint": func newSingleContainerSpec() v1alpha1.GameServerSpec {
Step #3 - "lint":      �[33m^�[0m
Step #3 - "lint": make: *** [lint] Error 1
Step #3 - "lint": Makefile:204: recipe for target 'lint' failed
Finished Step #3 - "lint"
ERROR
ERROR: build step 3 "make-docker" failed: exit status 2

[agones-bot]

Build Succeeded 👏

Build Id: 11ecb7f3-7705-4454-9148-af2a625ed8ae

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:0.7.0-99f8bfa
• image: gcr.io/agones-images/agones-sdk:0.7.0-99f8bfa
• image: gcr.io/agones-images/agones-ping:0.7.0-99f8bfa
• Linux C++ SDK (build: dev): agonessdk-0.7.0-99f8bfa-dev-linux-arch_64.tar.gz
• Linux C++ SDK (build: runtime): agonessdk-0.7.0-99f8bfa-runtime-linux-arch_64.tar.gz
• Linux C++ SDK (source): agonessdk-0.7.0-99f8bfa-src.zip
• SDK Server: agonessdk-server-0.7.0-99f8bfa.zip

To install this version:

• git fetch https://github.com/GoogleCloudPlatform/agones.git pull/451/head:pr_451 && git checkout pr_451
• helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-99f8bfa

[markmandel]

Now that I can see it - that's super clean 👍 Nice one. 🍰