Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/sdkserver: added doc.go #452

Merged
merged 1 commit into from
Dec 21, 2018
Merged

pkg/sdkserver: added doc.go #452

merged 1 commit into from
Dec 21, 2018

Conversation

jkowalski
Copy link
Contributor

Follow-up to #451

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dd1ca774-acdb-4eca-a2be-ce1f6ac464cc

The following development artifacts have been built, and will exist for the next 30 days:

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/452/head:pr_452 && git checkout pr_452
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.7.0-9837da0

markmandel
markmandel approved these changes Dec 21, 2018
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. I missed that!

@markmandel markmandel merged commit 8170aa0 into googleforgames:master Dec 21, 2018
@jkowalski jkowalski deleted the sdkserver-doc branch December 21, 2018 04:05
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 28, 2018
@markmandel markmandel added this to the 0.7.0 milestone Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jkowalski @agones-bot @markmandel