Add input parameters check on CRD loggers #626

aLekSer · 2019-02-27T15:42:13Z

Check nil pointer parameter to avoid possible panic.
Small test fix also to avoid panic on accessing elements of empty array.

agones-bot · 2019-02-27T15:51:14Z

Build Succeeded 👏

Build Id: 62000f02-ed6b-4810-96c2-ff87f783342e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-e3047ab
image: gcr.io/agones-images/agones-sdk:0.9.0-e3047ab
image: gcr.io/agones-images/agones-ping:0.9.0-e3047ab
Linux C++ SDK (build: dev): agonessdk-0.9.0-e3047ab-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-e3047ab-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-e3047ab-src.zip
SDK Server: agonessdk-server-0.9.0-e3047ab.zip

A preview of the website (the last 30 builds are retained):

https://e3047ab-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/626/head:pr_626 && git checkout pr_626
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-e3047ab

jkowalski · 2019-02-27T21:14:57Z

there are some unrelated files in this PR, intentional?

agones-bot · 2019-02-27T21:18:52Z

Build Failed 😱

Build Id: ae42a752-9d93-4194-834a-11c9e8759ad2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-02-28T06:30:50Z

@jkowalski Yes, I added small doc update and test update, because don't want to open two small PRs.

agones-bot · 2019-02-28T08:27:01Z

Build Succeeded 👏

Build Id: 18bd967a-b09c-4d82-b240-7c0c805cf45b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-17c94c7
image: gcr.io/agones-images/agones-sdk:0.9.0-17c94c7
image: gcr.io/agones-images/agones-ping:0.9.0-17c94c7
Linux C++ SDK (build: dev): agonessdk-0.9.0-17c94c7-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-17c94c7-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-17c94c7-src.zip
SDK Server: agonessdk-server-0.9.0-17c94c7.zip

A preview of the website (the last 30 builds are retained):

https://17c94c7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/626/head:pr_626 && git checkout pr_626
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-17c94c7

aLekSer · 2019-02-28T08:50:34Z

Well, I decided to split this two logically different changes into two PRs.

agones-bot · 2019-02-28T08:56:34Z

Build Succeeded 👏

Build Id: de40055e-a27c-49a5-96e2-a72cab390760

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-81fd4ab
image: gcr.io/agones-images/agones-sdk:0.9.0-81fd4ab
image: gcr.io/agones-images/agones-ping:0.9.0-81fd4ab
Linux C++ SDK (build: dev): agonessdk-0.9.0-81fd4ab-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-81fd4ab-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-81fd4ab-src.zip
SDK Server: agonessdk-server-0.9.0-81fd4ab.zip

A preview of the website (the last 30 builds are retained):

https://81fd4ab-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/626/head:pr_626 && git checkout pr_626
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-81fd4ab

Check nil pointer parameter to avoid possible panic. Updated Create Gameserver doc.

agones-bot · 2019-03-01T09:14:30Z

Build Succeeded 👏

Build Id: c9b1f323-310e-488c-90a3-b91a5ce2137b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-6524116
image: gcr.io/agones-images/agones-sdk:0.9.0-6524116
image: gcr.io/agones-images/agones-ping:0.9.0-6524116
Linux C++ SDK (build: dev): agonessdk-0.9.0-6524116-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-6524116-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-6524116-src.zip
SDK Server: agonessdk-server-0.9.0-6524116.zip

A preview of the website (the last 30 builds are retained):

https://6524116-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/626/head:pr_626 && git checkout pr_626
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-6524116

markmandel · 2019-03-01T17:21:24Z

Works for me. @jkowalski - any objections? If not, I'll approve + merge.

agones-bot · 2019-03-04T17:24:44Z

Build Succeeded 👏

Build Id: d07e2d69-fdcb-465d-99b8-cad6d00b647e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-066c1ba
image: gcr.io/agones-images/agones-sdk:0.9.0-066c1ba
image: gcr.io/agones-images/agones-ping:0.9.0-066c1ba
Linux C++ SDK (build: dev): agonessdk-0.9.0-066c1ba-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-066c1ba-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-066c1ba-src.zip
SDK Server: agonessdk-server-0.9.0-066c1ba.zip

A preview of the website (the last 30 builds are retained):

https://066c1ba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/626/head:pr_626 && git checkout pr_626
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-066c1ba

markmandel

🎣

aLekSer force-pushed the fix/logger-add-check branch from 97ed827 to 17c94c7 Compare February 28, 2019 08:17

aLekSer force-pushed the fix/logger-add-check branch from 17c94c7 to 81fd4ab Compare February 28, 2019 08:47

Add input parameters check on CRD loggers

6524116

Check nil pointer parameter to avoid possible panic. Updated Create Gameserver doc.

aLekSer force-pushed the fix/logger-add-check branch from 81fd4ab to 6524116 Compare March 1, 2019 09:05

markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 4, 2019

markmandel added this to the 0.9.0 milestone Mar 4, 2019

Merge branch 'master' into fix/logger-add-check

066c1ba

markmandel approved these changes Mar 4, 2019

View reviewed changes

markmandel merged commit 9bc422d into googleforgames:master Mar 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add input parameters check on CRD loggers #626

Add input parameters check on CRD loggers #626

aLekSer commented Feb 27, 2019 •

edited

Loading

agones-bot commented Feb 27, 2019

jkowalski commented Feb 27, 2019

agones-bot commented Feb 27, 2019

aLekSer commented Feb 28, 2019

agones-bot commented Feb 28, 2019

aLekSer commented Feb 28, 2019

agones-bot commented Feb 28, 2019

agones-bot commented Mar 1, 2019

markmandel commented Mar 1, 2019

agones-bot commented Mar 4, 2019

markmandel left a comment

Add input parameters check on CRD loggers #626

Add input parameters check on CRD loggers #626

Conversation

aLekSer commented Feb 27, 2019 • edited Loading

agones-bot commented Feb 27, 2019

jkowalski commented Feb 27, 2019

agones-bot commented Feb 27, 2019

aLekSer commented Feb 28, 2019

agones-bot commented Feb 28, 2019

aLekSer commented Feb 28, 2019

agones-bot commented Feb 28, 2019

agones-bot commented Mar 1, 2019

markmandel commented Mar 1, 2019

agones-bot commented Mar 4, 2019

markmandel left a comment

Choose a reason for hiding this comment

aLekSer commented Feb 27, 2019 •

edited

Loading