Switch to using default gke-cluster oauthScopes settings for clusters #632
Conversation
|
Build Succeeded 👏 Build Id: fab87847-ba5f-4186-95d2-f5f9a428302f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
| @@ -30,8 +30,6 @@ resources: | |||
| oauthScopes: | |||
| - https://www.googleapis.com/auth/compute | |||
There was a problem hiding this comment.
Looking at https://cloud.google.com/sdk/gcloud/reference/container/clusters/create, gke-default is:
gke-default
https://www.googleapis.com/auth/devstorage.read_only
https://www.googleapis.com/auth/logging.write
https://www.googleapis.com/auth/monitoring
https://www.googleapis.com/auth/service.management.readonly
https://www.googleapis.com/auth/servicecontrol
https://www.googleapis.com/auth/trace.append
Should we use the same?
There was a problem hiding this comment.
Hello @markmandel ,
Yes, if we want to have consistent scopes in docs and yml.
By the way these two are enabled by default, if monitoring and logging API is enabled:
https://www.googleapis.com/auth/logging.write
https://www.googleapis.com/auth/monitoring
Last 3 scopes were not configured but they could be helpful.
The purpose of these oauthScopes could be found here.
Let me check cluster creating with those 6 and omitting https://www.googleapis.com/auth/compute.
Verified that we can change oauthScope nodePool settings to gke-defaults. Tests test-e2e, metrics and logs works as before.
|
Build Succeeded 👏 Build Id: fdbda880-8dcb-4c7d-b0c2-3ed42b9734b4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
aLekSer
changed the title
|
Build Succeeded 👏 Build Id: bb764b54-e097-4c9f-8ea1-74beae9cbd67 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Reduce oauthScope settings with test-e2e.
Verified that metrics and logs works as before this change.
Node Config details.
Closes #614.