Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minikube documentation and dev tooling to 1.12 #895

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Update minikube documentation and dev tooling to 1.12 #895

merged 2 commits into from
Jul 11, 2019

Conversation

roberthbailey
Copy link
Member

Part of #717.

A couple of notes:

  1. The RBAC mode has been the default on minikube since minikube switched to kubeadm as the default bootstrapper, so I've removed that flag to simplify the instructions
  2. The role binding is no longer required with Kubernetes 1.12+, which is nice as it also simplifies things.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 368fdfa8-05c7-4e5c-8918-010c544b75a5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/895/head:pr_895 && git checkout pr_895
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-11eaaf3

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4a07e21f-0d35-4cf4-8ab0-724db1ad2fd6

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/895/head:pr_895 && git checkout pr_895
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-87be016

@roberthbailey roberthbailey force-pushed the agones-on-k8s-1-12 branch 2 times, most recently from 2d188cc to 803ee65 Compare July 10, 2019 22:41
@roberthbailey roberthbailey mentioned this pull request Jul 10, 2019
Merged
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 108949f6-7c7e-4da9-bfed-6e54d759315b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 642baa92-f964-471a-be72-2614318ef136

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

This one needs to go in after #897 so that there aren't any forward references to the "Enabling creation of RBAC resources" section.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4f0883fc-06a9-49c3-b9f6-b6d3b32b29ce

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel
markmandel approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit, but only needs changing if you care 👍

build/includes/minikube.mk Outdated Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 894ecd83-e614-4a24-b7d4-46a070e6a0c5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d9addebc-d23e-43b5-980a-ba029ac3c8a7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added this to the 0.12.0 milestone Jul 11, 2019
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 11, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ffb3095b-ac2b-406c-a5d5-c8ee9eeaa40f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/895/head:pr_895 && git checkout pr_895
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-bf468a5

@markmandel markmandel merged commit ebc32a2 into googleforgames:master Jul 11, 2019
@roberthbailey roberthbailey mentioned this pull request Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey deleted the agones-on-k8s-1-12 branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roberthbailey @agones-bot @markmandel