Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GKE documentation to 1.12 #897

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

roberthbailey
Copy link
Member

Part of #717.

Notes:

  1. As in Update minikube documentation and dev tooling to 1.12 #895, the role binding is no longer required with Kubernetes 1.12+ so I've removed the part.
  2. I've removed the flag to disable basic auth now that it is just setting the default behavior.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 960eba4d-ae5a-4e6f-b59d-04fab13ff589

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/897/head:pr_897 && git checkout pr_897
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-2584d7d

@markmandel
Copy link
Member

Not sure if for this PR, but I assume this should also mean it should also be removed from here?
https://github.com/googleforgames/agones/blob/master/build/includes/google-cloud.mk#L68

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@markmandel markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Jul 11, 2019
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c1d18c01-7dac-43e9-b97c-bfe4dcf637a4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member Author

Not sure if for this PR, but I assume this should also mean it should also be removed from here?
https://github.com/googleforgames/agones/blob/master/build/includes/google-cloud.mk#L68

Might as well remove it since we are switching to 1.12. If we don't do it now, it'll probably be forgotten. I've removed it and pushed an updated branch.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 533b2048-4d89-4263-b74b-2b8275965e00

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 5f25e0bf-bc20-4ed4-a86f-1dd117a508cb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 925c8b65-6c12-4239-97d4-07f9fd35f8b4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7fe63332-901d-4a79-b8f7-5929ff0f174d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 34045ab1-f867-4bcf-ba49-4a79fd334591

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6b61679b-a509-49f9-8976-f179504ba47f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/897/head:pr_897 && git checkout pr_897
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-166ede5

@markmandel markmandel merged commit 46a9383 into googleforgames:master Jul 11, 2019
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@markmandel markmandel added the kind/breaking Breaking change label Aug 1, 2019
@roberthbailey roberthbailey deleted the gke-to-1-12 branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking Breaking change kind/documentation Documentation for Agones kind/feature New features for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants