-
-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong source path after renaming a top level folder #514
Comments
@pablomartinezm thank you! Issue is reproducible in version 0.9.0, I was make the PR for eliminate cause of issue. You may try to use this patch for testing purpose. Tests for CI will be added later, but manual testing passed well. |
I've reviewed your fix and I'm using the same workaround to overcome the parent renamed folders in my code. If someone finds a smarter/more elegant solution please notify me! Btw, I let the bug open until a new release is launched. Feel free to close it ;) |
* Fix issue gorakhargosh#325 and gorakhargosh#514. * Test added * Added test for Windows * Added tests from gorakhargosh#574
Steps to reproduce in Ubuntu 18.04
Start monitoring a folder in recursive mode p.e. "/"
Create Folder A
"/A"
Create Folder B inside A
"/A/B"
Rename A -> A2
"/A2/B"
Create a file inside B, named example.txt
/A2/B/example.txt
Bug: The src_path of the event fired when creating the file example.txt is
/A/B/example.txt
and should be
/A2/B/example.txt
The text was updated successfully, but these errors were encountered: